All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Damato <jdamato@fastly.com>
To: Daniel Sedlak <daniel@sedlak.dev>
Cc: Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [Question] Generic way to retrieve IRQ number of Tx/Rx queue
Date: Tue, 14 Jan 2025 15:26:02 -0800	[thread overview]
Message-ID: <Z4byihk_5pqXcLvB@LQ3V64L9R2> (raw)
In-Reply-To: <adf7c053-ffde-4df8-bc24-99740906410d@sedlak.dev>

On Tue, Jan 14, 2025 at 09:32:26AM +0100, Daniel Sedlak wrote:
> 
> 
> On 1/13/25 10:15 PM, Jakub Kicinski wrote:
> > 
> > We do have an API for that
> > https://docs.kernel.org/next/networking/netlink_spec/netdev.html#napi
> > but unfortunately the driver needs to support it, and i40e currently
> > doesn't:
> 
> Thank you for the link, I somehow missed that part of netlink...
> 
> > $ git grep --files-with-matches  netif_napi_set_irq
> > drivers/net/ethernet/amazon/ena/ena_netdev.c
> > drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > drivers/net/ethernet/broadcom/tg3.c
> > drivers/net/ethernet/google/gve/gve_utils.c
> > drivers/net/ethernet/intel/e1000/e1000_main.c
> > drivers/net/ethernet/intel/e1000e/netdev.c
> > drivers/net/ethernet/intel/ice/ice_lib.c
> > drivers/net/ethernet/intel/igc/igc_main.c
> > drivers/net/ethernet/mellanox/mlx4/en_cq.c
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
> > 
> > Should be easy to add. Let me CC the Intel list in case they already
> > have a relevant change queued for i40e..
> 
> Thank you for directions, will check Intel's mailing list and poke around
> with implementing that.

I previously tried to add support for this API to i40e [1], but got
pulled into other stuff and never picked it back up. Wanted to
mention it in case it is useful for you.

[1]: https://lore.kernel.org/lkml/20240410043936.206169-1-jdamato@fastly.com/

WARNING: multiple messages have this Message-ID (diff)
From: Joe Damato <jdamato@fastly.com>
To: Daniel Sedlak <daniel@sedlak.dev>
Cc: Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [Question] Generic way to retrieve IRQ number of Tx/Rx queue
Date: Tue, 14 Jan 2025 15:26:02 -0800	[thread overview]
Message-ID: <Z4byihk_5pqXcLvB@LQ3V64L9R2> (raw)
In-Reply-To: <adf7c053-ffde-4df8-bc24-99740906410d@sedlak.dev>

On Tue, Jan 14, 2025 at 09:32:26AM +0100, Daniel Sedlak wrote:
> 
> 
> On 1/13/25 10:15 PM, Jakub Kicinski wrote:
> > 
> > We do have an API for that
> > https://docs.kernel.org/next/networking/netlink_spec/netdev.html#napi
> > but unfortunately the driver needs to support it, and i40e currently
> > doesn't:
> 
> Thank you for the link, I somehow missed that part of netlink...
> 
> > $ git grep --files-with-matches  netif_napi_set_irq
> > drivers/net/ethernet/amazon/ena/ena_netdev.c
> > drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > drivers/net/ethernet/broadcom/tg3.c
> > drivers/net/ethernet/google/gve/gve_utils.c
> > drivers/net/ethernet/intel/e1000/e1000_main.c
> > drivers/net/ethernet/intel/e1000e/netdev.c
> > drivers/net/ethernet/intel/ice/ice_lib.c
> > drivers/net/ethernet/intel/igc/igc_main.c
> > drivers/net/ethernet/mellanox/mlx4/en_cq.c
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c
> > 
> > Should be easy to add. Let me CC the Intel list in case they already
> > have a relevant change queued for i40e..
> 
> Thank you for directions, will check Intel's mailing list and poke around
> with implementing that.

I previously tried to add support for this API to i40e [1], but got
pulled into other stuff and never picked it back up. Wanted to
mention it in case it is useful for you.

[1]: https://lore.kernel.org/lkml/20240410043936.206169-1-jdamato@fastly.com/

  reply	other threads:[~2025-01-14 23:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  9:07 [Question] Generic way to retrieve IRQ number of Tx/Rx queue Daniel Sedlak
2025-01-10 17:38 ` Stephen Hemminger
2025-01-13 21:15 ` [Intel-wired-lan] " Jakub Kicinski
2025-01-13 21:15   ` Jakub Kicinski
2025-01-14  8:32   ` [Intel-wired-lan] " Daniel Sedlak
2025-01-14  8:32     ` Daniel Sedlak
2025-01-14 23:26     ` Joe Damato [this message]
2025-01-14 23:26       ` Joe Damato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4byihk_5pqXcLvB@LQ3V64L9R2 \
    --to=jdamato@fastly.com \
    --cc=daniel@sedlak.dev \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.