Re: [PATCH v7 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller

From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <bhelgaas@google.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
	<manivannan.sadhasivam@linaro.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <vkoul@kernel.org>,
	<kishon@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <p.zabel@pengutronix.de>,
	<dmitry.baryshkov@linaro.org>, <quic_nsekar@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-phy@lists.infradead.org>
Subject: Re: [PATCH v7 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller
Date: Thu, 23 Jan 2025 13:35:36 +0530	[thread overview]
Message-ID: <Z5H4UPhRjKhbbP9/@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <20250123-red-unicorn-of-piety-3c7de5@krzk-bin>

On Thu, Jan 23, 2025 at 08:58:29AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Jan 22, 2025 at 12:04:09PM +0530, Varadarajan Narayanan wrote:
> > Document the PCIe controller on IPQ5332 platform. IPQ5332 will
> > use IPQ9574 as the fall back compatible.
> >
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > v7: Moved ipq9574 related changes to a separate patch
> >     Add 'global' interrupt
> >
> > v6: Commit message update only. Add info regarding the moving of
> >     ipq9574 from 5 "reg" definition to 5 or 6 reg definition.
> >
> > v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts
> >
> > v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332
> >     * DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able
> >       to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check
> >       and dt_binding_check flag errors.
> > ---
> >  .../devicetree/bindings/pci/qcom,pcie.yaml          | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index 413c6b76c26c..ead97286fd41 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -34,6 +34,10 @@ properties:
> >        - items:
> >            - const: qcom,pcie-msm8998
> >            - const: qcom,pcie-msm8996
> > +      - items:
> > +          - enum:
> > +              - qcom,pcie-ipq5332
> > +          - const: qcom,pcie-ipq9574
>
> Repeated many times on reviews to qcom: don't add to the end of the
> lists. In case of multiple items, these are ordered by fallback, so this
> goes next to other ipq entry... wait, that's already qcom,pcie-ipq9574,
> so why are you duplicating?
>
> On what tree are you working?

Looks like ipq5424 changes got merged between the time I cloned
linux-next, tested and posted the patch. Will fix this and post
a new one.

Thanks
Varada