Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP

[Ingo Molnar <mingo@kernel.org>]

* Jinjie Ruan <ruanjinjie@huawei.com> wrote:

> Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
> remove it.
> 
> Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  arch/x86/include/asm/thread_info.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index 12da7dfd5ef1..734db7221613 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -110,7 +110,6 @@ struct thread_info {
>  #define _TIF_NOTIFY_RESUME	(1 << TIF_NOTIFY_RESUME)
>  #define _TIF_SIGPENDING		(1 << TIF_SIGPENDING)
>  #define _TIF_NEED_RESCHED	(1 << TIF_NEED_RESCHED)
> -#define _TIF_SINGLESTEP		(1 << TIF_SINGLESTEP)
>  #define _TIF_SSBD		(1 << TIF_SSBD)
>  #define _TIF_SPEC_IB		(1 << TIF_SPEC_IB)
>  #define _TIF_SPEC_L1D_FLUSH	(1 << TIF_SPEC_L1D_FLUSH)

While technically _TIF_SINGLESTEP is not used, TIF_SINGLESTEP is very 
much used, and _TIF_SINGLESTEP is its canonical mask definition that we 
construct for all the other TIF bits as well.

Thanks,

	Ingo