* [PATCH] x86: Remove unused _TIF_SINGLESTEP
@ 2024-10-30 1:24 Jinjie Ruan
2024-10-30 1:44 ` H. Peter Anvin
2025-03-03 12:33 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Jinjie Ruan @ 2024-10-30 1:24 UTC (permalink / raw)
To: tglx, mingo, bp, dave.hansen, hpa, xin3.li, krisman, x86,
linux-kernel
Cc: ruanjinjie
Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
remove it.
Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
arch/x86/include/asm/thread_info.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index 12da7dfd5ef1..734db7221613 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -110,7 +110,6 @@ struct thread_info {
#define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
-#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
#define _TIF_SSBD (1 << TIF_SSBD)
#define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
#define _TIF_SPEC_L1D_FLUSH (1 << TIF_SPEC_L1D_FLUSH)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP
2024-10-30 1:24 [PATCH] x86: Remove unused _TIF_SINGLESTEP Jinjie Ruan
@ 2024-10-30 1:44 ` H. Peter Anvin
2024-10-30 1:46 ` Jinjie Ruan
2025-03-03 12:33 ` Ingo Molnar
1 sibling, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2024-10-30 1:44 UTC (permalink / raw)
To: Jinjie Ruan, tglx, mingo, bp, dave.hansen, xin3.li, krisman, x86,
linux-kernel
Cc: ruanjinjie
On October 29, 2024 6:24:38 PM PDT, Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
>remove it.
>
>Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
>Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>---
> arch/x86/include/asm/thread_info.h | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
>index 12da7dfd5ef1..734db7221613 100644
>--- a/arch/x86/include/asm/thread_info.h
>+++ b/arch/x86/include/asm/thread_info.h
>@@ -110,7 +110,6 @@ struct thread_info {
> #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
>-#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
> #define _TIF_SSBD (1 << TIF_SSBD)
> #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
> #define _TIF_SPEC_L1D_FLUSH (1 << TIF_SPEC_L1D_FLUSH)
"Following commit"?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP
2024-10-30 1:44 ` H. Peter Anvin
@ 2024-10-30 1:46 ` Jinjie Ruan
0 siblings, 0 replies; 4+ messages in thread
From: Jinjie Ruan @ 2024-10-30 1:46 UTC (permalink / raw)
To: H. Peter Anvin, tglx, mingo, bp, dave.hansen, xin3.li, krisman,
x86, linux-kernel
On 2024/10/30 9:44, H. Peter Anvin wrote:
> On October 29, 2024 6:24:38 PM PDT, Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>> Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
>> remove it.
>>
>> Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
This commit, sorry, the message is not so clear.
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> arch/x86/include/asm/thread_info.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
>> index 12da7dfd5ef1..734db7221613 100644
>> --- a/arch/x86/include/asm/thread_info.h
>> +++ b/arch/x86/include/asm/thread_info.h
>> @@ -110,7 +110,6 @@ struct thread_info {
>> #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
>> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
>> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
>> -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
>> #define _TIF_SSBD (1 << TIF_SSBD)
>> #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
>> #define _TIF_SPEC_L1D_FLUSH (1 << TIF_SPEC_L1D_FLUSH)
>
> "Following commit"?
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Remove unused _TIF_SINGLESTEP
2024-10-30 1:24 [PATCH] x86: Remove unused _TIF_SINGLESTEP Jinjie Ruan
2024-10-30 1:44 ` H. Peter Anvin
@ 2025-03-03 12:33 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2025-03-03 12:33 UTC (permalink / raw)
To: Jinjie Ruan
Cc: tglx, mingo, bp, dave.hansen, hpa, xin3.li, krisman, x86,
linux-kernel
* Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> Since following commit, _TIF_SINGLESTEP is not used by x86 anymore,
> remove it.
>
> Fixes: 6342adcaa683 ("entry: Ensure trap after single-step on system call return")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> arch/x86/include/asm/thread_info.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index 12da7dfd5ef1..734db7221613 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -110,7 +110,6 @@ struct thread_info {
> #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME)
> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
> -#define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
> #define _TIF_SSBD (1 << TIF_SSBD)
> #define _TIF_SPEC_IB (1 << TIF_SPEC_IB)
> #define _TIF_SPEC_L1D_FLUSH (1 << TIF_SPEC_L1D_FLUSH)
While technically _TIF_SINGLESTEP is not used, TIF_SINGLESTEP is very
much used, and _TIF_SINGLESTEP is its canonical mask definition that we
construct for all the other TIF bits as well.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-03 12:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30 1:24 [PATCH] x86: Remove unused _TIF_SINGLESTEP Jinjie Ruan
2024-10-30 1:44 ` H. Peter Anvin
2024-10-30 1:46 ` Jinjie Ruan
2025-03-03 12:33 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.