All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"arm-scmi@vger.kernel.org" <arm-scmi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq
Date: Wed, 12 Mar 2025 10:52:23 +0000	[thread overview]
Message-ID: <Z9FnZzBQuZ1j5k3I@bogus> (raw)
In-Reply-To: <Z9AdICiyaCmzKh-N@bogus>

On Tue, Mar 11, 2025 at 11:23:12AM +0000, Sudeep Holla wrote:
> On Tue, Mar 11, 2025 at 11:12:45AM +0000, Peng Fan wrote:
> >
> > So it is clear that wrong fw_devlink is created, it is because scmi cpufreq device is
> > created earlier and when device_add, the below logic makes the fwnode pointer points
> > to scmi cpufreq device.
> >         if (dev->fwnode && !dev->fwnode->dev) {
> >                 dev->fwnode->dev = dev;
> >                 fw_devlink_link_device(dev);
> >         }
> >
>
> Thanks, looks like simple way to reproduce the issue. I will give it a try.
>

I could reproduce but none of my solution solved the problem completely
or properly. And I don't like the DT proposal you came up with. I am
not inclined to just drop this fwnode setting in the scmi devices and
just use of_node.

-- 
Regards,
Sudeep

  reply	other threads:[~2025-03-12 10:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-25  8:20 [PATCH 0/4] scmi: Bypass set fwnode to address devlink issue Peng Fan (OSS)
2024-12-25  8:20 ` [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq Peng Fan (OSS)
2024-12-27 15:13   ` Sudeep Holla
2024-12-30  2:05     ` Peng Fan
2024-12-31 18:07     ` Cristian Marussi
2025-01-02  7:38       ` Peng Fan
2025-01-02 17:06         ` Cristian Marussi
2025-01-06  4:37           ` Peng Fan
2025-02-11 17:13   ` Sudeep Holla
2025-02-12  7:01     ` Peng Fan
2025-02-12 10:48       ` Sudeep Holla
2025-02-13  8:03         ` Saravana Kannan
2025-02-13 20:23           ` Cristian Marussi
2025-02-18  1:09             ` Peng Fan
2025-02-18 10:24               ` Sudeep Holla
2025-02-18 13:36                 ` Peng Fan
2025-02-19 10:17                   ` Sudeep Holla
2025-02-20  0:59                     ` Peng Fan
2025-03-10  9:29                       ` Sudeep Holla
2025-03-10 10:45                         ` Peng Fan
2025-03-10 11:59                           ` Sudeep Holla
2025-03-10 13:41                             ` Sudeep Holla
2025-03-11  8:36                               ` Peng Fan
2025-03-11 11:12                                 ` Peng Fan
2025-03-11 11:23                                   ` Sudeep Holla
2025-03-12 10:52                                     ` Sudeep Holla [this message]
2025-03-12 11:28                                       ` Sudeep Holla
2025-03-13  5:23                                         ` Peng Fan
2025-04-09  3:50                                           ` Peng Fan
2025-04-09 11:14                                             ` Sudeep Holla
2025-04-17 14:26                                               ` Sudeep Holla
2025-04-20 14:09                                                 ` Peng Fan
2025-04-22 10:16                                                   ` Sudeep Holla
2025-06-20  3:58                                                     ` Peng Fan
2024-12-25  8:20 ` [PATCH 2/4] firmware: arm_scmi: bus: Bypass setting fwnode for pinctrl Peng Fan (OSS)
2024-12-27 15:28   ` Sudeep Holla
2024-12-30  2:08     ` Peng Fan
2024-12-31 18:16     ` Cristian Marussi
2025-01-06  4:41       ` Peng Fan
2025-01-14  8:31         ` Peng Fan
2025-01-14 10:07           ` Cristian Marussi
2025-01-15  7:22             ` Peng Fan
2024-12-31 18:13   ` Cristian Marussi
2024-12-25  8:20 ` [PATCH 3/4] pinctrl: scmi: Check fwnode instead of machine compatible Peng Fan (OSS)
2024-12-27 15:30   ` Sudeep Holla
2024-12-31 18:18     ` Cristian Marussi
2025-01-02  7:11       ` Peng Fan
2024-12-25  8:20 ` [PATCH 4/4] pinctrl: freescale: " Peng Fan (OSS)
2024-12-27 17:06 ` [PATCH 0/4] scmi: Bypass set fwnode to address devlink issue Linus Walleij
2024-12-30  2:12   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9FnZzBQuZ1j5k3I@bogus \
    --to=sudeep.holla@arm.com \
    --cc=aisheng.dong@nxp.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=saravanak@google.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.