Problem in "Pick a warning, and try to fix it": Don't have a warning to pick

Problem in "Pick a warning, and try to fix it": Don't have a warning to pick

[Kloudifold]

Hello, I am Kloudifold, an Outreachy applicant.

I'm reading https://kernelnewbies.org/Outreachyfirstpatch and trying to make my first patch. It says, "Pick a warning, and try to fix it. For your first patch, only pick one warning.", but when I used the command:

> perl scripts/checkpatch.pl -f drivers/staging/*/* | grep "[1-9] warnings" -B 10 -A 2

I can only find warnings for drivers/staging/axis-fifo/axis-fifo.c, a file that is already being submitted to the mailing list, which means I don't have a warning to pick.
How should I finish my first patch in this case? Should I look for something more difficult than changing the coding style?

Re: Problem in "Pick a warning, and try to fix it": Don't have a warning to pick

[Alison Schofield]

On Thu, Mar 09, 2023 at 05:57:55AM +0800, Kloudifold wrote:
> Hello, I am Kloudifold, an Outreachy applicant.
> 
> I'm reading https://kernelnewbies.org/Outreachyfirstpatch and trying to make my first patch. It says, "Pick a warning, and try to fix it. For your first patch, only pick one warning.", but when I used the command:
> 
> > perl scripts/checkpatch.pl -f drivers/staging/*/* | grep "[1-9] warnings" -B 10 -A 2

Hi Kloudifold,

Your script is quitting after operating on the first dir. 

There are more WARNINGs and CHECKs 
Look up the --strict option to checkpatch to get those CHECKs.

Reminder: don't include drivers/staging/media in your searches.

Alison
> 
> I can only find warnings for drivers/staging/axis-fifo/axis-fifo.c, a file that is already being submitted to the mailing list, which means I don't have a warning to pick.
> How should I finish my first patch in this case? Should I look for something more difficult than changing the coding style?
> 

Re: Problem in "Pick a warning, and try to fix it": Don't have a warning to pick

[Julia Lawall]

On Thu, 9 Mar 2023, Kloudifold wrote:

> Hello, I am Kloudifold, an Outreachy applicant.
>
> I'm reading https://kernelnewbies.org/Outreachyfirstpatch and trying to make my first patch. It says, "Pick a warning, and try to fix it. For your first patch, only pick one warning.", but when I used the command:
>
> > perl scripts/checkpatch.pl -f drivers/staging/*/* | grep "[1-9] warnings" -B 10 -A 2
>
> I can only find warnings for drivers/staging/axis-fifo/axis-fifo.c, a file that is already being submitted to the mailing list, which means I don't have a warning to pick.
> How should I finish my first patch in this case? Should I look for something more difficult than changing the coding style?

I'm surprised that there would only be one warning in all of staging.  But
who knows.

Your grep may be missing cases with eg 10 warnings?

Maybe see if some of the CHECK or ERROR cases are easy to do?

If you find nothing at all, a few days ago I posted a list of cases where
the argument indentation might be undesirable.  You cold look hrough them
for something that could be improved.

julia