From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 2/6] drm/i915: Only initialize dlk phy lock in display 12 and newer
Date: Tue, 11 Apr 2023 11:38:19 +0300 [thread overview]
Message-ID: <ZDUce4jMSzhFyIxO@intel.com> (raw)
In-Reply-To: <20230410183219.191543-2-jose.souza@intel.com>
On Mon, Apr 10, 2023 at 11:32:15AM -0700, José Roberto de Souza wrote:
> This spin lock will not be used in older display versions, so no need
> to initialize it.
>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dkl_phy.c b/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> index 5bce7b5b27bc7..1c5d410b74e5d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> @@ -108,5 +108,6 @@ intel_dkl_phy_posting_read(struct drm_i915_private *i915, struct intel_dkl_phy_r
> void
> intel_dkl_phy_init(struct drm_i915_private *i915)
> {
> - spin_lock_init(&i915->display.dkl.phy_lock);
> + if (DISPLAY_VER(i915) >= 12)
Looks like a pointless check to me. This is so cheap it doesn't
matter, and less LOC is better.
> + spin_lock_init(&i915->display.dkl.phy_lock);
> }
> --
> 2.40.0
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-xe] [Intel-gfx] [PATCH v3 2/6] drm/i915: Only initialize dlk phy lock in display 12 and newer
Date: Tue, 11 Apr 2023 11:38:19 +0300 [thread overview]
Message-ID: <ZDUce4jMSzhFyIxO@intel.com> (raw)
In-Reply-To: <20230410183219.191543-2-jose.souza@intel.com>
On Mon, Apr 10, 2023 at 11:32:15AM -0700, José Roberto de Souza wrote:
> This spin lock will not be used in older display versions, so no need
> to initialize it.
>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dkl_phy.c b/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> index 5bce7b5b27bc7..1c5d410b74e5d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> @@ -108,5 +108,6 @@ intel_dkl_phy_posting_read(struct drm_i915_private *i915, struct intel_dkl_phy_r
> void
> intel_dkl_phy_init(struct drm_i915_private *i915)
> {
> - spin_lock_init(&i915->display.dkl.phy_lock);
> + if (DISPLAY_VER(i915) >= 12)
Looks like a pointless check to me. This is so cheap it doesn't
matter, and less LOC is better.
> + spin_lock_init(&i915->display.dkl.phy_lock);
> }
> --
> 2.40.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-04-11 8:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 18:32 [Intel-gfx] [PATCH v3 1/6] drm/i915: Initialize dkl_phy spin lock from display code path José Roberto de Souza
2023-04-10 18:32 ` [Intel-xe] " José Roberto de Souza
2023-04-10 18:32 ` [Intel-gfx] [PATCH v3 2/6] drm/i915: Only initialize dlk phy lock in display 12 and newer José Roberto de Souza
2023-04-10 18:32 ` [Intel-xe] " José Roberto de Souza
2023-04-11 8:38 ` Ville Syrjälä [this message]
2023-04-11 8:38 ` [Intel-xe] [Intel-gfx] " Ville Syrjälä
2023-04-10 18:32 ` [Intel-xe] [PATCH v3 3/6] fixup! drm/i915/display: Remaining changes to make xe compile José Roberto de Souza
2023-04-10 18:32 ` [Intel-xe] [PATCH v3 4/6] TEMPORARY: drm/xe/display: Enable modular fia in TGL José Roberto de Souza
2023-04-10 18:32 ` [Intel-xe] [PATCH v3 5/6] drm/xe/display: Disable PSR HW tracking by default in all display versions José Roberto de Souza
2023-04-10 18:32 ` [Intel-xe] [PATCH v3 6/6] drm/xe: Enable Raptorlake-P José Roberto de Souza
2023-04-10 19:02 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [v3,1/6] drm/i915: Initialize dkl_phy spin lock from display code path Patchwork
2023-04-10 19:03 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-04-10 19:07 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-04-10 19:29 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-04-11 8:32 ` [Intel-gfx] [Intel-xe] [PATCH v3 1/6] " Jani Nikula
2023-04-11 8:32 ` Jani Nikula
2023-04-11 8:33 ` [Intel-gfx] " Jani Nikula
2023-04-11 8:33 ` Jani Nikula
2023-04-11 13:24 ` [Intel-gfx] " Souza, Jose
2023-04-11 13:24 ` Souza, Jose
2023-04-11 8:39 ` [Intel-gfx] " Ville Syrjälä
2023-04-11 8:39 ` [Intel-xe] " Ville Syrjälä
2023-04-11 8:51 ` [Intel-gfx] [Intel-xe] " Jani Nikula
2023-04-11 8:51 ` [Intel-xe] [Intel-gfx] " Jani Nikula
2023-04-11 9:12 ` [Intel-gfx] [Intel-xe] " Ville Syrjälä
2023-04-11 9:12 ` [Intel-xe] [Intel-gfx] " Ville Syrjälä
2023-04-11 9:14 ` [Intel-gfx] [Intel-xe] " Jani Nikula
2023-04-11 9:14 ` [Intel-xe] [Intel-gfx] " Jani Nikula
2023-04-11 14:51 ` [Intel-gfx] [Intel-xe] " Rodrigo Vivi
2023-04-11 14:51 ` [Intel-xe] [Intel-gfx] " Rodrigo Vivi
2023-04-11 19:59 ` [Intel-gfx] [Intel-xe] " Lucas De Marchi
2023-04-11 19:59 ` [Intel-xe] [Intel-gfx] " Lucas De Marchi
2023-04-11 20:07 ` [Intel-gfx] [Intel-xe] " Souza, Jose
2023-04-11 20:07 ` [Intel-xe] [Intel-gfx] " Souza, Jose
2023-04-11 21:20 ` [Intel-gfx] [Intel-xe] " Lucas De Marchi
2023-04-11 21:20 ` [Intel-xe] [Intel-gfx] " Lucas De Marchi
2023-04-12 17:13 ` [Intel-gfx] [Intel-xe] " Souza, Jose
2023-04-12 17:13 ` [Intel-xe] [Intel-gfx] " Souza, Jose
2023-04-13 8:22 ` [Intel-gfx] [Intel-xe] " Jani Nikula
2023-04-13 8:22 ` [Intel-xe] [Intel-gfx] " Jani Nikula
2023-04-13 9:49 ` [Intel-gfx] [Intel-xe] " Jani Nikula
2023-04-13 9:49 ` [Intel-xe] [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDUce4jMSzhFyIxO@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.