Re: [PATCH v2 2/2] dt-bindings: MFD: Convert STMPE to YAML schema

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Lee Jones <lee@kernel.org>,
	Philippe Schenker <philippe.schenker@toradex.com>,
	Stefan Agner <stefan@agner.ch>, Marek Vasut <marex@denx.de>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: MFD: Convert STMPE to YAML schema
Date: Mon, 1 May 2023 09:25:00 -0700	[thread overview]
Message-ID: <ZE/n3O6eZRCeBTJy@google.com> (raw)
In-Reply-To: <20230427161633.GA3112472-robh@kernel.org>

On Thu, Apr 27, 2023 at 11:16:33AM -0500, Rob Herring wrote:
> On Wed, Apr 26, 2023 at 01:21:39PM +0200, Linus Walleij wrote:
> > This converts the STMPE MFD device tree bindings to the YAML
> > schema.
> > 
> > Reference the existing schema for the ADC, just define the
> > other subnode schemas directly in the MFD schema.
> > 
> > Add two examples so we have examples covering both the simple
> > GPIO expander and the more complex with ADC and touchscreen.
> > 
> > Some in-tree users do not follow the naming conventions for nodes
> > so these DTS files need to be augmented to use proper node names
> > like "adc", "pwm", "gpio", "keyboard-controller" etc before the
> > bindings take effect on them.
> > 
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > ChangeLog v1->v2:
> > - Split off the GPIO bindings to their own schema, as the old
> >   bindings didn't even have any GPIO bindings. Put the GPIO
> >   schema before this schema so we can use GPIO in the examples.
> > - Drop nodename and pattern as STMPE is not a generic name.
> > - Add maxItems to the resets.
> > - Make wakeup-source just :true, as it is a generic property.
> > - Move unevaluatedProperties for subnodes right before properties
> >   as requested.
> > - Name devices "port-expander" in the examples.
> > - Use lowercase hex in line init.
> > ---
> >  .../devicetree/bindings/input/stmpe-keypad.txt     |  41 ---
> >  .../bindings/input/touchscreen/stmpe.txt           | 108 --------

Since Rob is happy with the bindings, for the input bits:

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry