All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, NeilBrown <neilb@suse.de>,
	linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH v5 1/5] nfs_lib.sh: Cleanup local and remote directories setup
Date: Thu, 4 May 2023 15:58:15 +0200	[thread overview]
Message-ID: <ZFO597l50v9PEQPP@yuki> (raw)
In-Reply-To: <20230504131414.3826283-2-pvorel@suse.cz>

Hi!
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/nfs/nfs_stress/nfs_lib.sh | 52 ++++++++++++++-------
>  1 file changed, 34 insertions(+), 18 deletions(-)
> 
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index af7d46a21..1b5604ab5 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0-or-later
> -# Copyright (c) Linux Test Project, 2016-2022
> +# Copyright (c) Linux Test Project, 2016-2023
>  # Copyright (c) 2015-2018 Oracle and/or its affiliates. All Rights Reserved.
>  # Copyright (c) International Business Machines  Corp., 2001
>  
> @@ -53,6 +53,24 @@ get_socket_type()
>  	done
>  }
>  
> +# directory mounted by NFS client
> +get_local_dir()
> +{
> +	local v="$1"
> +	local n="$2"
> +
> +	echo "$TST_TMPDIR/$v/$n"
> +}
> +
> +# directory on NFS server
> +get_remote_dir()
> +{
> +	local v="$1"
> +	local n="$2"
> +
> +	echo "$TST_TMPDIR/$v/$n"
> +}

It's a bit puzzling why we have two identical functions with a different
name...

-- 
Cyril Hrubis
chrubis@suse.cz

WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: NeilBrown <neilb@suse.de>,
	linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 1/5] nfs_lib.sh: Cleanup local and remote directories setup
Date: Thu, 4 May 2023 15:58:15 +0200	[thread overview]
Message-ID: <ZFO597l50v9PEQPP@yuki> (raw)
In-Reply-To: <20230504131414.3826283-2-pvorel@suse.cz>

Hi!
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/nfs/nfs_stress/nfs_lib.sh | 52 ++++++++++++++-------
>  1 file changed, 34 insertions(+), 18 deletions(-)
> 
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index af7d46a21..1b5604ab5 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0-or-later
> -# Copyright (c) Linux Test Project, 2016-2022
> +# Copyright (c) Linux Test Project, 2016-2023
>  # Copyright (c) 2015-2018 Oracle and/or its affiliates. All Rights Reserved.
>  # Copyright (c) International Business Machines  Corp., 2001
>  
> @@ -53,6 +53,24 @@ get_socket_type()
>  	done
>  }
>  
> +# directory mounted by NFS client
> +get_local_dir()
> +{
> +	local v="$1"
> +	local n="$2"
> +
> +	echo "$TST_TMPDIR/$v/$n"
> +}
> +
> +# directory on NFS server
> +get_remote_dir()
> +{
> +	local v="$1"
> +	local n="$2"
> +
> +	echo "$TST_TMPDIR/$v/$n"
> +}

It's a bit puzzling why we have two identical functions with a different
name...

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-05-04 13:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 13:14 [PATCH v5 0/5] NFS: test on btrfs, ext4, xfs filesystems Petr Vorel
2023-05-04 13:14 ` [LTP] " Petr Vorel
2023-05-04 13:14 ` [PATCH v5 1/5] nfs_lib.sh: Cleanup local and remote directories setup Petr Vorel
2023-05-04 13:14   ` [LTP] " Petr Vorel
2023-05-04 13:58   ` Cyril Hrubis [this message]
2023-05-04 13:58     ` Cyril Hrubis
2023-05-04 21:16     ` Petr Vorel
2023-05-04 21:16       ` [LTP] " Petr Vorel
2023-05-05 10:42       ` Cyril Hrubis
2023-05-05 10:42         ` [LTP] " Cyril Hrubis
2023-05-05 10:44         ` Petr Vorel
2023-05-05 10:44           ` [LTP] " Petr Vorel
2023-05-04 13:14 ` [PATCH v5 2/5] nfs_lib.sh: Unexport on proper side on netns Petr Vorel
2023-05-04 13:14   ` [LTP] " Petr Vorel
2023-05-04 13:14 ` [PATCH v5 3/5] nfs05.sh: Lower down the default values Petr Vorel
2023-05-04 13:14   ` [LTP] " Petr Vorel
2023-05-04 13:14 ` [PATCH v5 4/5] nfs03.sh: " Petr Vorel
2023-05-04 13:14   ` [LTP] " Petr Vorel
2023-05-05 12:56   ` Petr Vorel
2023-05-05 12:56     ` [LTP] " Petr Vorel
2023-05-04 13:14 ` [PATCH v5 5/5] nfs: Run on btrfs, ext4, xfs Petr Vorel
2023-05-04 13:14   ` [LTP] " Petr Vorel
2023-05-04 14:01   ` Cyril Hrubis
2023-05-04 14:01     ` [LTP] " Cyril Hrubis
2023-05-04 22:00     ` Petr Vorel
2023-05-04 22:00       ` [LTP] " Petr Vorel
2023-05-04 22:02       ` Petr Vorel
2023-05-04 22:02         ` [LTP] " Petr Vorel
2023-05-04 23:23       ` Petr Vorel
2023-05-04 23:23         ` [LTP] " Petr Vorel
2023-05-05 11:08         ` Cyril Hrubis
2023-05-05 11:08           ` [LTP] " Cyril Hrubis
2023-05-05 12:59           ` Petr Vorel
2023-05-05 12:59             ` [LTP] " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFO597l50v9PEQPP@yuki \
    --to=chrubis@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=neilb@suse.de \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.