From: Simon Horman <simon.horman@corigine.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: taras.chornyi@plvision.eu, petrm@nvidia.com,
alexandre.belloni@bootlin.com, jiri@resnulli.us,
taspelund@nvidia.com, leon@kernel.org, netdev@vger.kernel.org,
razor@blackwall.org, bridge@lists.linux-foundation.org,
claudiu.manoil@nxp.com, UNGLinuxDriver@microchip.com,
vladimir.oltean@nxp.com, xiyou.wangcong@gmail.com,
edumazet@google.com, jhs@mojatatu.com, roopa@nvidia.com,
kuba@kernel.org, pabeni@redhat.com, saeedm@nvidia.com,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 2/5] net/sched: flower: Allow matching on layer 2 miss
Date: Fri, 19 May 2023 13:27:56 +0200 [thread overview]
Message-ID: <ZGddPLS4LM1LJYgc@corigine.com> (raw)
In-Reply-To: <20230518113328.1952135-3-idosch@nvidia.com>
On Thu, May 18, 2023 at 02:33:25PM +0300, Ido Schimmel wrote:
> Add the 'TCA_FLOWER_L2_MISS' netlink attribute that allows user space to
> match on packets that encountered a layer 2 miss. The miss indication is
> set as metadata in the skb by the bridge driver upon FDB/MDB lookup
> miss.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Hi Ido,
these changes look good to me.
If I was doing this I would split the flow_dissector and cls_flower
changes into separate patches: they are different, though related, things.
But I don't feel strongly about that.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, razor@blackwall.org, roopa@nvidia.com,
taras.chornyi@plvision.eu, saeedm@nvidia.com, leon@kernel.org,
petrm@nvidia.com, vladimir.oltean@nxp.com,
claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com,
UNGLinuxDriver@microchip.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, taspelund@nvidia.com
Subject: Re: [PATCH net-next 2/5] net/sched: flower: Allow matching on layer 2 miss
Date: Fri, 19 May 2023 13:27:56 +0200 [thread overview]
Message-ID: <ZGddPLS4LM1LJYgc@corigine.com> (raw)
In-Reply-To: <20230518113328.1952135-3-idosch@nvidia.com>
On Thu, May 18, 2023 at 02:33:25PM +0300, Ido Schimmel wrote:
> Add the 'TCA_FLOWER_L2_MISS' netlink attribute that allows user space to
> match on packets that encountered a layer 2 miss. The miss indication is
> set as metadata in the skb by the bridge driver upon FDB/MDB lookup
> miss.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Hi Ido,
these changes look good to me.
If I was doing this I would split the flow_dissector and cls_flower
changes into separate patches: they are different, though related, things.
But I don't feel strongly about that.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-19 11:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 11:33 [Bridge] [PATCH net-next 0/5] Add layer 2 miss indication and filtering Ido Schimmel
2023-05-18 11:33 ` Ido Schimmel
2023-05-18 11:33 ` [Bridge] [PATCH net-next 1/5] skbuff: bridge: Add layer 2 miss indication Ido Schimmel
2023-05-18 11:33 ` Ido Schimmel
2023-05-18 16:08 ` [Bridge] " Nikolay Aleksandrov
2023-05-18 16:08 ` Nikolay Aleksandrov
2023-05-19 13:51 ` [Bridge] " Ido Schimmel
2023-05-19 13:51 ` Ido Schimmel
2023-05-19 21:52 ` [Bridge] " Jakub Kicinski
2023-05-19 21:52 ` Jakub Kicinski
2023-05-23 8:10 ` [Bridge] " Ido Schimmel
2023-05-23 8:10 ` Ido Schimmel
2023-05-23 9:04 ` [Bridge] " Paolo Abeni
2023-05-23 9:04 ` Paolo Abeni
2023-05-23 11:34 ` [Bridge] " Ido Schimmel
2023-05-23 11:34 ` Ido Schimmel
2023-05-23 13:03 ` [Bridge] " Nikolay Aleksandrov
2023-05-23 13:03 ` Nikolay Aleksandrov
2023-05-23 20:29 ` [Bridge] " Jakub Kicinski
2023-05-23 20:29 ` Jakub Kicinski
2023-05-21 7:34 ` [Bridge] " Nikolay Aleksandrov
2023-05-21 7:34 ` Nikolay Aleksandrov
2023-05-18 11:33 ` [Bridge] [PATCH net-next 2/5] net/sched: flower: Allow matching on layer 2 miss Ido Schimmel
2023-05-18 11:33 ` Ido Schimmel
2023-05-19 11:27 ` Simon Horman [this message]
2023-05-19 11:27 ` Simon Horman
2023-05-18 11:33 ` [Bridge] [PATCH net-next 3/5] flow_offload: Reject " Ido Schimmel
2023-05-18 11:33 ` Ido Schimmel
2023-05-19 11:33 ` [Bridge] " Simon Horman
2023-05-19 11:33 ` Simon Horman
2023-05-19 14:10 ` [Bridge] " Ido Schimmel
2023-05-19 14:10 ` Ido Schimmel
2023-05-19 14:15 ` [Bridge] " Simon Horman
2023-05-19 14:15 ` Simon Horman
2023-05-18 11:33 ` [Bridge] [PATCH net-next 4/5] mlxsw: spectrum_flower: Add ability to match " Ido Schimmel
2023-05-18 11:33 ` Ido Schimmel
2023-05-19 11:35 ` [Bridge] " Simon Horman
2023-05-19 11:35 ` Simon Horman
2023-05-18 11:33 ` [Bridge] [PATCH net-next 5/5] selftests: forwarding: Add layer 2 miss test cases Ido Schimmel
2023-05-18 11:33 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGddPLS4LM1LJYgc@corigine.com \
--to=simon.horman@corigine.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=taras.chornyi@plvision.eu \
--cc=taspelund@nvidia.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.