From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net 2/2] net: phylink: use a dedicated helper to parse usgmii control word
Date: Thu, 8 Jun 2023 17:33:46 +0100 [thread overview]
Message-ID: <ZIIC6mi2LtrD5P2m@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230608163415.511762-3-maxime.chevallier@bootlin.com>
On Thu, Jun 08, 2023 at 06:34:14PM +0200, Maxime Chevallier wrote:
> Q-USGMII is a derivative of USGMII, that uses a specific formatting for
> the control word. The layout is close to the USXGMII control word, but
> doesn't support speeds over 1Gbps. Use a dedicated decoding logic for
> the USGMII control word, re-using USXGMII definitions with a custom mask
> and only considering 10/100/1000 speeds
Seems to be a duplicate patch?
Please see my comments on the other submission of this patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com,
UNGLinuxDriver@microchip.com,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net 2/2] net: phylink: use a dedicated helper to parse usgmii control word
Date: Thu, 8 Jun 2023 17:33:46 +0100 [thread overview]
Message-ID: <ZIIC6mi2LtrD5P2m@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230608163415.511762-3-maxime.chevallier@bootlin.com>
On Thu, Jun 08, 2023 at 06:34:14PM +0200, Maxime Chevallier wrote:
> Q-USGMII is a derivative of USGMII, that uses a specific formatting for
> the control word. The layout is close to the USXGMII control word, but
> doesn't support speeds over 1Gbps. Use a dedicated decoding logic for
> the USGMII control word, re-using USXGMII definitions with a custom mask
> and only considering 10/100/1000 speeds
Seems to be a duplicate patch?
Please see my comments on the other submission of this patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-08 16:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:34 [PATCH net 0/2] fixes for Q-USGMII speeds and autoneg Maxime Chevallier
2023-06-08 16:34 ` Maxime Chevallier
2023-06-08 16:34 ` [PATCH net 1/2] net: phylink: report correct max speed for QUSGMII Maxime Chevallier
2023-06-08 16:34 ` Maxime Chevallier
2023-06-08 16:34 ` [PATCH net 2/2] net: phylink: use a dedicated helper to parse usgmii control word Maxime Chevallier
2023-06-08 16:34 ` Maxime Chevallier
2023-06-08 16:33 ` Russell King (Oracle) [this message]
2023-06-08 16:33 ` Russell King (Oracle)
2023-06-08 17:54 ` Maxime Chevallier
2023-06-08 17:54 ` Maxime Chevallier
2023-06-08 16:34 ` [PATCH net 2/2] net: phylink: use USXGMII control-word format to parse Q-USGMII word Maxime Chevallier
2023-06-08 16:34 ` Maxime Chevallier
2023-06-08 16:32 ` Russell King (Oracle)
2023-06-08 16:32 ` Russell King (Oracle)
2023-06-08 17:53 ` Maxime Chevallier
2023-06-08 17:53 ` Maxime Chevallier
2023-06-08 17:30 ` Russell King (Oracle)
2023-06-08 17:30 ` Russell King (Oracle)
2023-06-09 8:09 ` Maxime Chevallier
2023-06-09 8:09 ` Maxime Chevallier
2023-06-08 17:45 ` Simon Horman
2023-06-08 17:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIIC6mi2LtrD5P2m@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Allan.Nielsen@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.