From: Mark Rutland <mark.rutland@arm.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthias Kaehlcke <mka@chromium.org>,
kgdb-bugreport@lists.sourceforge.net,
Stephane Eranian <eranian@google.com>,
mpe@ellerman.id.au, Tzung-Bi Shih <tzungbi@chromium.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linuxppc-dev@lists.ozlabs.org, Sumit Garg <sumit.garg@linaro.org>,
npiggin@gmail.com, davem@davemloft.net,
Marc Zyngier <maz@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
sparclinux@vger.kernel.org, christophe.leroy@csgroup.eu,
Catalin Marinas <catalin.marinas@arm.com>,
ravi.v.shankar@intel.com, Randy Dunlap <rdunlap@infradead.org>,
Pingfan Liu <kernelfans@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Ian Rogers <irogers@google.com>,
ito-yuichi@fujitsu.com, ricardo.neri@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, Will Deacon <will@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs
Date: Mon, 12 Jun 2023 14:59:13 +0100 [thread overview]
Message-ID: <ZIckscgmirrgxZ75@FVFF77S0Q05N> (raw)
In-Reply-To: <CAD=FV=WyLKygSsArCaSzid47Rz5=ozR6Yh9L6Q3JStpzF9Tn9w@mail.gmail.com>
On Mon, Jun 12, 2023 at 06:55:37AM -0700, Doug Anderson wrote:
> Mark,
>
> On Mon, Jun 12, 2023 at 3:33 AM Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > On Fri, May 19, 2023 at 10:18:39AM -0700, Douglas Anderson wrote:
> > > On arm64, NMI support needs to be detected at runtime. Add a weak
> > > function to the perf hardlockup detector so that an architecture can
> > > implement it to detect whether NMIs are available.
> > >
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > ---
> > > While I won't object to this patch landing, I consider it part of the
> > > arm64 perf hardlockup effort. I would be OK with the earlier patches
> > > in the series landing and then not landing ${SUBJECT} patch nor
> > > anything else later.
> >
> > FWIW, everything prior to this looks fine to me, so I reckon it'd be worth
> > splitting the series here and getting the buddy lockup detector in first, to
> > avoid a log-jam on all the subsequent NMI bits.
>
> I think the whole series has already landed in Andrew's tree,
> including the arm64 "perf" lockup detector bits. I saw all the
> notifications from Andrew go through over the weekend that they were
> moved from an "unstable" branch to a "stable" one and I see them at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-nonmm-stable
>
> When I first saw Anderw land the arm64 perf lockup detector bits in
> his unstable branch several weeks ago, I sent a private message to the
> arm64 maintainers (yourself included) to make sure you were aware of
> it and that it hadn't been caught in mail filters. I got the
> impression that everything was OK. Is that not the case?
Sorry; I'm slowly catching up with a backlog of email, and I'm just behind.
Feel free to ignore this; sorry for the noise!
If we spot anything going wrong in testing we can look at fixing those up.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Ian Rogers <irogers@google.com>,
ito-yuichi@fujitsu.com,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
ravi.v.shankar@intel.com,
Catalin Marinas <catalin.marinas@arm.com>,
ricardo.neri@intel.com, Stephane Eranian <eranian@google.com>,
sparclinux@vger.kernel.org, Guenter Roeck <groeck@chromium.org>,
Will Deacon <will@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Andi Kleen <ak@linux.intel.com>, Marc Zyngier <maz@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Matthias Kaehlcke <mka@chromium.org>,
kgdb-bugreport@lists.sourceforge.net,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Tzung-Bi Shih <tzungbi@chromium.org>,
npiggin@gmail.com, Stephen Boyd <swboyd@chromium.org>,
Pingfan Liu <kernelfans@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Sumit Garg <sumit.garg@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.o rg, davem@davemloft.net
Subject: Re: [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs
Date: Mon, 12 Jun 2023 14:59:13 +0100 [thread overview]
Message-ID: <ZIckscgmirrgxZ75@FVFF77S0Q05N> (raw)
In-Reply-To: <CAD=FV=WyLKygSsArCaSzid47Rz5=ozR6Yh9L6Q3JStpzF9Tn9w@mail.gmail.com>
On Mon, Jun 12, 2023 at 06:55:37AM -0700, Doug Anderson wrote:
> Mark,
>
> On Mon, Jun 12, 2023 at 3:33 AM Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > On Fri, May 19, 2023 at 10:18:39AM -0700, Douglas Anderson wrote:
> > > On arm64, NMI support needs to be detected at runtime. Add a weak
> > > function to the perf hardlockup detector so that an architecture can
> > > implement it to detect whether NMIs are available.
> > >
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > ---
> > > While I won't object to this patch landing, I consider it part of the
> > > arm64 perf hardlockup effort. I would be OK with the earlier patches
> > > in the series landing and then not landing ${SUBJECT} patch nor
> > > anything else later.
> >
> > FWIW, everything prior to this looks fine to me, so I reckon it'd be worth
> > splitting the series here and getting the buddy lockup detector in first, to
> > avoid a log-jam on all the subsequent NMI bits.
>
> I think the whole series has already landed in Andrew's tree,
> including the arm64 "perf" lockup detector bits. I saw all the
> notifications from Andrew go through over the weekend that they were
> moved from an "unstable" branch to a "stable" one and I see them at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-nonmm-stable
>
> When I first saw Anderw land the arm64 perf lockup detector bits in
> his unstable branch several weeks ago, I sent a private message to the
> arm64 maintainers (yourself included) to make sure you were aware of
> it and that it hadn't been caught in mail filters. I got the
> impression that everything was OK. Is that not the case?
Sorry; I'm slowly catching up with a backlog of email, and I'm just behind.
Feel free to ignore this; sorry for the noise!
If we spot anything going wrong in testing we can look at fixing those up.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthias Kaehlcke <mka@chromium.org>,
kgdb-bugreport@lists.sourceforge.net,
Stephane Eranian <eranian@google.com>,
mpe@ellerman.id.au, Tzung-Bi Shih <tzungbi@chromium.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linuxppc-dev@lists.ozlabs.org, Sumit Garg <sumit.garg@linaro.org>,
npiggin@gmail.com, davem@davemloft.net,
Marc Zyngier <maz@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
sparclinux@vger.kernel.org, christophe.leroy@csgroup.eu,
Catalin Marinas <catalin.marinas@arm.com>,
ravi.v.shankar@intel.com, Randy Dunlap <rdunlap@infradead.org>,
Pingfan Liu <kernelfans@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Ian Rogers <irogers@google.com>,
ito-yuichi@fujitsu.com, ricardo.neri@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, Will Deacon <will@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
Masayoshi Mizuma <msys.mizuma@gmail.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs
Date: Mon, 12 Jun 2023 14:59:13 +0100 [thread overview]
Message-ID: <ZIckscgmirrgxZ75@FVFF77S0Q05N> (raw)
In-Reply-To: <CAD=FV=WyLKygSsArCaSzid47Rz5=ozR6Yh9L6Q3JStpzF9Tn9w@mail.gmail.com>
On Mon, Jun 12, 2023 at 06:55:37AM -0700, Doug Anderson wrote:
> Mark,
>
> On Mon, Jun 12, 2023 at 3:33 AM Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > On Fri, May 19, 2023 at 10:18:39AM -0700, Douglas Anderson wrote:
> > > On arm64, NMI support needs to be detected at runtime. Add a weak
> > > function to the perf hardlockup detector so that an architecture can
> > > implement it to detect whether NMIs are available.
> > >
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > ---
> > > While I won't object to this patch landing, I consider it part of the
> > > arm64 perf hardlockup effort. I would be OK with the earlier patches
> > > in the series landing and then not landing ${SUBJECT} patch nor
> > > anything else later.
> >
> > FWIW, everything prior to this looks fine to me, so I reckon it'd be worth
> > splitting the series here and getting the buddy lockup detector in first, to
> > avoid a log-jam on all the subsequent NMI bits.
>
> I think the whole series has already landed in Andrew's tree,
> including the arm64 "perf" lockup detector bits. I saw all the
> notifications from Andrew go through over the weekend that they were
> moved from an "unstable" branch to a "stable" one and I see them at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-nonmm-stable
>
> When I first saw Anderw land the arm64 perf lockup detector bits in
> his unstable branch several weeks ago, I sent a private message to the
> arm64 maintainers (yourself included) to make sure you were aware of
> it and that it hadn't been caught in mail filters. I got the
> impression that everything was OK. Is that not the case?
Sorry; I'm slowly catching up with a backlog of email, and I'm just behind.
Feel free to ignore this; sorry for the noise!
If we spot anything going wrong in testing we can look at fixing those up.
Thanks,
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-12 14:00 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 17:18 [PATCH v5 00/18] watchdog/hardlockup: Add the buddy hardlockup detector Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 18/18] arm64: Enable perf events based hard lockup detector Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 00/18] watchdog/hardlockup: Add the buddy hardlockup detector Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 01/18] watchdog/perf: Define dummy watchdog_update_hrtimer_threshold() on correct config Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 02/18] watchdog/perf: More properly prevent false positives with turbo modes Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-23 9:35 ` Petr Mladek
2023-05-23 9:35 ` Petr Mladek
2023-05-23 9:35 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 03/18] watchdog: remove WATCHDOG_DEFAULT Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 04/18] watchdog/hardlockup: change watchdog_nmi_enable() to void Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 05/18] watchdog/perf: Ensure CPU-bound context when creating hardlockup detector event Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 06/18] watchdog/hardlockup: Add comments to touch_nmi_watchdog() Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-23 9:58 ` Petr Mladek
2023-05-23 9:58 ` Petr Mladek
2023-05-23 9:58 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 07/18] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 08/18] watchdog/hardlockup: Move perf hardlockup checking/panic to common watchdog.c Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-23 11:45 ` Petr Mladek
2023-05-23 11:45 ` Petr Mladek
2023-05-23 11:45 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 09/18] watchdog/hardlockup: Style changes to watchdog_hardlockup_check() / is_hardlockup() Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 10/18] watchdog/hardlockup: Add a "cpu" param to watchdog_hardlockup_check() Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-23 16:02 ` Petr Mladek
2023-05-23 16:02 ` Petr Mladek
2023-05-23 16:02 ` Petr Mladek
2023-05-23 16:34 ` Doug Anderson
2023-05-23 16:34 ` Doug Anderson
2023-05-23 16:34 ` Doug Anderson
2023-05-24 11:36 ` Petr Mladek
2023-05-24 11:36 ` Petr Mladek
2023-05-24 11:36 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 11/18] watchdog/hardlockup: Move perf hardlockup watchdog petting to watchdog.c Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-24 13:07 ` Petr Mladek
2023-05-24 13:07 ` Petr Mladek
2023-05-24 13:07 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 12/18] watchdog/hardlockup: Rename some "NMI watchdog" constants/function Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-24 13:38 ` Petr Mladek
2023-05-24 13:38 ` Petr Mladek
2023-05-24 13:38 ` Petr Mladek
2023-05-25 23:33 ` Doug Anderson
2023-05-25 23:33 ` Doug Anderson
2023-05-25 23:33 ` Doug Anderson
2023-05-19 17:18 ` [PATCH v5 13/18] watchdog/hardlockup: Have the perf hardlockup use __weak functions more cleanly Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-24 13:59 ` Petr Mladek
2023-05-24 13:59 ` Petr Mladek
2023-05-24 13:59 ` Petr Mladek
2023-05-24 19:38 ` Doug Anderson
2023-05-24 19:38 ` Doug Anderson
2023-05-24 19:38 ` Doug Anderson
2023-05-26 14:44 ` Petr Mladek
2023-05-26 14:44 ` Petr Mladek
2023-05-26 14:44 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 14/18] watchdog/hardlockup: detect hard lockups using secondary (buddy) CPUs Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-25 16:26 ` Petr Mladek
2023-05-25 16:26 ` Petr Mladek
2023-05-25 16:26 ` Petr Mladek
2023-05-25 20:08 ` Doug Anderson
2023-05-25 20:08 ` Doug Anderson
2023-05-25 20:08 ` Doug Anderson
2023-05-26 12:29 ` Petr Mladek
2023-05-26 12:29 ` Petr Mladek
2023-05-26 12:29 ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-26 12:36 ` Petr Mladek
2023-05-26 12:36 ` Petr Mladek
2023-05-26 12:36 ` Petr Mladek
2023-06-12 10:33 ` Mark Rutland
2023-06-12 10:33 ` Mark Rutland
2023-06-12 13:55 ` Doug Anderson
2023-06-12 13:55 ` Doug Anderson
2023-06-12 13:55 ` Doug Anderson
2023-06-12 13:59 ` Mark Rutland [this message]
2023-06-12 13:59 ` Mark Rutland
2023-06-12 13:59 ` Mark Rutland
2023-05-19 17:18 ` [PATCH v5 16/18] watchdog/perf: Adapt the watchdog_perf interface for async model Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 17/18] arm64: add hw_nmi_get_sample_period for preparation of lockup detector Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIckscgmirrgxZ75@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=eranian@google.com \
--cc=groeck@chromium.org \
--cc=irogers@google.com \
--cc=ito-yuichi@fujitsu.com \
--cc=kernelfans@gmail.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=mpe@ellerman.id.au \
--cc=msys.mizuma@gmail.com \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=ravi.v.shankar@intel.com \
--cc=rdunlap@infradead.org \
--cc=ricardo.neri@intel.com \
--cc=sparclinux@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@chromium.org \
--cc=wens@csie.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.