All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: mjrosato@linux.ibm.com, jasowang@redhat.com,
	xudong.hao@intel.com, zhenzhong.duan@intel.com,
	peterx@redhat.com, terrence.xu@intel.com,
	chao.p.peng@linux.intel.com, linux-s390@vger.kernel.org,
	kvm@vger.kernel.org, lulu@redhat.com, yanting.jiang@intel.com,
	joro@8bytes.org, nicolinc@nvidia.com, kevin.tian@intel.com,
	yan.y.zhao@intel.com, intel-gfx@lists.freedesktop.org,
	eric.auger@redhat.com, intel-gvt-dev@lists.freedesktop.org,
	yi.y.sun@linux.intel.com, clegoate@redhat.com, cohuck@redhat.com,
	shameerali.kolothum.thodi@huawei.com,
	suravee.suthikulpanit@amd.com, robin.murphy@arm.com
Subject: Re: [Intel-gfx] [PATCH v12 11/24] vfio-iommufd: Split bind/attach into two steps
Date: Thu, 22 Jun 2023 14:59:17 -0300	[thread overview]
Message-ID: <ZJSL9T1ZXL3WdFHc@nvidia.com> (raw)
In-Reply-To: <20230602121653.80017-12-yi.l.liu@intel.com>

On Fri, Jun 02, 2023 at 05:16:40AM -0700, Yi Liu wrote:
> This aligns the bind/attach logic with the coming vfio device cdev support.
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Terrence Xu <terrence.xu@intel.com>
> Tested-by: Nicolin Chen <nicolinc@nvidia.com>
> Tested-by: Yanting Jiang <yanting.jiang@intel.com>
> Tested-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  drivers/vfio/group.c   | 17 +++++++++++++----
>  drivers/vfio/iommufd.c | 35 +++++++++++++++++------------------
>  drivers/vfio/vfio.h    |  9 +++++++++
>  3 files changed, 39 insertions(+), 22 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: alex.williamson@redhat.com, kevin.tian@intel.com,
	joro@8bytes.org, robin.murphy@arm.com, cohuck@redhat.com,
	eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
	mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
	yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
	shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
	suravee.suthikulpanit@amd.com,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-s390@vger.kernel.org,
	xudong.hao@intel.com, yan.y.zhao@intel.com,
	terrence.xu@intel.com, yanting.jiang@intel.com,
	zhenzhong.duan@intel.com, clegoate@redhat.com
Subject: Re: [PATCH v12 11/24] vfio-iommufd: Split bind/attach into two steps
Date: Thu, 22 Jun 2023 14:59:17 -0300	[thread overview]
Message-ID: <ZJSL9T1ZXL3WdFHc@nvidia.com> (raw)
In-Reply-To: <20230602121653.80017-12-yi.l.liu@intel.com>

On Fri, Jun 02, 2023 at 05:16:40AM -0700, Yi Liu wrote:
> This aligns the bind/attach logic with the coming vfio device cdev support.
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Terrence Xu <terrence.xu@intel.com>
> Tested-by: Nicolin Chen <nicolinc@nvidia.com>
> Tested-by: Yanting Jiang <yanting.jiang@intel.com>
> Tested-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  drivers/vfio/group.c   | 17 +++++++++++++----
>  drivers/vfio/iommufd.c | 35 +++++++++++++++++------------------
>  drivers/vfio/vfio.h    |  9 +++++++++
>  3 files changed, 39 insertions(+), 22 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

  reply	other threads:[~2023-06-22 17:59 UTC|newest]

Thread overview: 180+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 12:16 [Intel-gfx] [PATCH v12 00/24] Add vfio_device cdev for iommufd support Yi Liu
2023-06-02 12:16 ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 01/24] vfio: Allocate per device file structure Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 02/24] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 03/24] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 04/24] kvm/vfio: Prepare for accepting vfio device fd Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 05/24] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 06/24] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 21:52   ` [Intel-gfx] " Alex Williamson
2023-06-12 21:52     ` Alex Williamson
2023-06-13  5:24     ` [Intel-gfx] " Liu, Yi L
2023-06-13  5:24       ` Liu, Yi L
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 21:52   ` [Intel-gfx] " Alex Williamson
2023-06-12 21:52     ` Alex Williamson
2023-06-13  5:46     ` [Intel-gfx] " Liu, Yi L
2023-06-13  5:46       ` Liu, Yi L
2023-06-13 14:16       ` [Intel-gfx] " Alex Williamson
2023-06-13 14:16         ` Alex Williamson
2023-06-13 14:36         ` [Intel-gfx] " Liu, Yi L
2023-06-13 14:36           ` Liu, Yi L
2023-06-13 14:42           ` [Intel-gfx] " Alex Williamson
2023-06-13 14:42             ` Alex Williamson
2023-06-13 14:44             ` [Intel-gfx] " Liu, Yi L
2023-06-13 14:44               ` Liu, Yi L
2023-06-13 17:19         ` [Intel-gfx] " Jason Gunthorpe
2023-06-13 17:19           ` Jason Gunthorpe
2023-06-13 17:31           ` [Intel-gfx] " Alex Williamson
2023-06-13 17:31             ` Alex Williamson
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 08/24] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 09/24] vfio: Make vfio_df_open() single open for device cdev path Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 10/24] vfio-iommufd: Move noiommu compat validation out of vfio_iommufd_bind() Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-22 17:59   ` [Intel-gfx] " Jason Gunthorpe
2023-06-22 17:59     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 11/24] vfio-iommufd: Split bind/attach into two steps Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-22 17:59   ` Jason Gunthorpe [this message]
2023-06-22 17:59     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 12/24] vfio: Record devid in vfio_device_file Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-22 18:00   ` [Intel-gfx] " Jason Gunthorpe
2023-06-22 18:00     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 13/24] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 14:04   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 14:04     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 14/24] iommufd/device: Add iommufd_access_detach() API Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 14:15   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 14:15     ` Jason Gunthorpe
2023-06-25 18:26     ` [Intel-gfx] " Nicolin Chen
2023-06-25 18:26       ` Nicolin Chen
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 15/24] vfio-iommufd: Add detach_ioas support for emulated VFIO devices Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 14:16   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 14:16     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 16/24] vfio: Move vfio_device_group_unregister() to be the first operation in unregister Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 14:22   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 14:22     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 17/24] vfio: Add cdev for vfio_device Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 15:58   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 15:58     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 22:27   ` [Intel-gfx] " Alex Williamson
2023-06-12 22:27     ` Alex Williamson
2023-06-13  5:48     ` [Intel-gfx] " Liu, Yi L
2023-06-13  5:48       ` Liu, Yi L
2023-06-13 14:18       ` [Intel-gfx] " Alex Williamson
2023-06-13 14:18         ` Alex Williamson
2023-06-13 14:28         ` [Intel-gfx] " Liu, Yi L
2023-06-13 14:28           ` Liu, Yi L
2023-06-13 14:39           ` [Intel-gfx] " Alex Williamson
2023-06-13 14:39             ` Alex Williamson
2023-06-13 14:42             ` [Intel-gfx] " Liu, Yi L
2023-06-13 14:42               ` Liu, Yi L
2023-06-13 14:59               ` [Intel-gfx] " Alex Williamson
2023-06-13 14:59                 ` Alex Williamson
2023-06-23 16:15   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 16:15     ` Jason Gunthorpe
2023-06-26  8:34     ` [Intel-gfx] " Liu, Yi L
2023-06-26  8:34       ` Liu, Yi L
2023-06-26 12:56       ` [Intel-gfx] " Jason Gunthorpe
2023-06-26 12:56         ` Jason Gunthorpe
2023-06-26 13:35         ` [Intel-gfx] " Liu, Yi L
2023-06-26 13:35           ` Liu, Yi L
2023-06-26 14:51           ` [Intel-gfx] " Liu, Yi L
2023-06-26 14:51             ` Liu, Yi L
2023-06-28 14:34             ` [Intel-gfx] " Jason Gunthorpe
2023-06-28 14:34               ` Jason Gunthorpe
2023-06-28 14:41               ` [Intel-gfx] " Liu, Yi L
2023-06-28 14:41                 ` Liu, Yi L
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 19/24] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 16:21   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 16:21     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 20/24] vfio: Only check group->type for noiommu test Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 22:37   ` [Intel-gfx] " Alex Williamson
2023-06-12 22:37     ` Alex Williamson
2023-06-13  9:20     ` [Intel-gfx] " Liu, Yi L
2023-06-13  9:20       ` Liu, Yi L
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev() Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 22:42   ` [Intel-gfx] " Alex Williamson
2023-06-12 22:42     ` Alex Williamson
2023-06-13  5:53     ` [Intel-gfx] " Liu, Yi L
2023-06-13  5:53       ` Liu, Yi L
2023-06-13 14:19       ` [Intel-gfx] " Alex Williamson
2023-06-13 14:19         ` Alex Williamson
2023-06-13 14:33         ` [Intel-gfx] " Liu, Yi L
2023-06-13 14:33           ` Liu, Yi L
2023-06-13 14:48           ` [Intel-gfx] " Alex Williamson
2023-06-13 14:48             ` Alex Williamson
2023-06-13 15:01             ` [Intel-gfx] " Liu, Yi L
2023-06-13 15:01               ` Liu, Yi L
2023-06-13 15:13               ` [Intel-gfx] " Alex Williamson
2023-06-13 17:15                 ` Alex Williamson
2023-06-13 17:35                   ` Jason Gunthorpe
2023-06-13 17:35                     ` Jason Gunthorpe
2023-06-13 20:10                     ` [Intel-gfx] " Alex Williamson
2023-06-13 20:10                       ` Alex Williamson
2023-06-14  3:24                       ` [Intel-gfx] " Liu, Yi L
2023-06-14  3:24                         ` Liu, Yi L
2023-06-14  5:42                         ` [Intel-gfx] " Tian, Kevin
2023-06-14  5:42                           ` Tian, Kevin
2023-06-14  6:14                           ` [Intel-gfx] " Liu, Yi L
2023-06-14  6:14                             ` Liu, Yi L
2023-06-14  6:20                             ` [Intel-gfx] " Tian, Kevin
2023-06-14  6:20                               ` Tian, Kevin
2023-06-14 12:23                               ` [Intel-gfx] " Jason Gunthorpe
2023-06-14 12:23                                 ` Jason Gunthorpe
2023-06-14 13:12                                 ` [Intel-gfx] " Liu, Yi L
2023-06-14 13:12                                   ` Liu, Yi L
2023-06-14 17:30                                   ` [Intel-gfx] " Jason Gunthorpe
2023-06-14 17:30                                     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 22/24] vfio: Remove vfio_device_is_noiommu() Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 22:46   ` [Intel-gfx] " Alex Williamson
2023-06-12 22:46     ` Alex Williamson
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 23/24] vfio: Compile vfio_group infrastructure optionally Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-23 16:35   ` [Intel-gfx] " Jason Gunthorpe
2023-06-23 16:35     ` Jason Gunthorpe
2023-06-02 12:16 ` [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description Yi Liu
2023-06-02 12:16   ` Yi Liu
2023-06-12 23:06   ` [Intel-gfx] " Alex Williamson
2023-06-12 23:06     ` Alex Williamson
2023-06-13 12:01     ` [Intel-gfx] " Liu, Yi L
2023-06-13 12:01       ` Liu, Yi L
2023-06-13 14:24       ` [Intel-gfx] " Alex Williamson
2023-06-13 14:24         ` Alex Williamson
2023-06-13 14:48         ` [Intel-gfx] " Liu, Yi L
2023-06-13 14:48           ` Liu, Yi L
2023-06-13 15:04           ` [Intel-gfx] " Alex Williamson
2023-06-13 15:04             ` Alex Williamson
2023-06-13 15:11             ` [Intel-gfx] " Liu, Yi L
2023-06-13 15:11               ` Liu, Yi L
2023-06-13 17:30               ` [Intel-gfx] " Alex Williamson
2023-06-13 17:30                 ` Alex Williamson
2023-06-02 16:19 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev15) Patchwork
2023-06-07  8:27 ` [Intel-gfx] [PATCH v12 00/24] Add vfio_device cdev for iommufd support Nicolin Chen
2023-06-07  8:27   ` Nicolin Chen
2023-06-08  6:58 ` [Intel-gfx] " Jiang, Yanting
2023-06-08  6:58   ` Jiang, Yanting
2023-06-09 16:47 ` [Intel-gfx] " Matthew Rosato
2023-06-09 16:47   ` Matthew Rosato
2023-06-14 15:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev16) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJSL9T1ZXL3WdFHc@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=clegoate@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jasowang@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=nicolinc@nvidia.com \
    --cc=peterx@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=terrence.xu@intel.com \
    --cc=xudong.hao@intel.com \
    --cc=yan.y.zhao@intel.com \
    --cc=yanting.jiang@intel.com \
    --cc=yi.l.liu@intel.com \
    --cc=yi.y.sun@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.