Re: [Intel-xe] [PATCH v4 5/7] drm/xe/gt: tweak placement for signalling TLB fences after GT reset

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Jul 05, 2023 at 05:06:08PM +0100, Matthew Auld wrote:
> Assumption here is that submission is disabled along with CT, and full
> GT reset will also nuke TLBs, so should be safe to signal all in-flight
> TLB fences, but only after the actual reset so move the placement
> slightly.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Cc: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index bc76678a8276..a21d44bfe9e8 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -519,7 +519,6 @@ static int gt_reset(struct xe_gt *gt)
>  
>  	xe_uc_stop_prepare(&gt->uc);
>  	xe_gt_pagefault_reset(gt);
> -	xe_gt_tlb_invalidation_reset(gt);
>  
>  	err = xe_uc_stop(&gt->uc);
>  	if (err)
> @@ -529,6 +528,8 @@ static int gt_reset(struct xe_gt *gt)
>  	if (err)
>  		goto err_out;
>  
> +	xe_gt_tlb_invalidation_reset(gt);
> +
>  	err = do_gt_restart(gt);
>  	if (err)
>  		goto err_out;
> -- 
> 2.41.0
>