All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: YE Chengfeng <cyeaa@connect.ust.hk>
Cc: "andi.shyti@kernel.org" <andi.shyti@kernel.org>,
	"rjui@broadcom.com" <rjui@broadcom.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com" 
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue
Date: Thu, 6 Jul 2023 21:36:14 +0200	[thread overview]
Message-ID: <ZKcXrt3vGzncO/0d@shikoro> (raw)
In-Reply-To: <TYCP286MB1188708B1CE64D95FBACF9E78A20A@TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

On Sat, Jun 24, 2023 at 07:36:02PM +0000, YE Chengfeng wrote:
> iproc_i2c_rd_reg and iproc_i2c_wr_reg are called from both
> interrupt context (e.g. bcm_iproc_i2c_isr) and process context
> (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be
> disabled to avoid potential deadlock. To prevent this deadlock,
> use spin_lock_irqsave.
> 
> Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>

I can't apply it, what version is this against? Also, if someone could
supply a proper Fixes-tag, this would be much appreciated.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: YE Chengfeng <cyeaa@connect.ust.hk>
Cc: "andi.shyti@kernel.org" <andi.shyti@kernel.org>,
	"rjui@broadcom.com" <rjui@broadcom.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue
Date: Thu, 6 Jul 2023 21:36:14 +0200	[thread overview]
Message-ID: <ZKcXrt3vGzncO/0d@shikoro> (raw)
In-Reply-To: <TYCP286MB1188708B1CE64D95FBACF9E78A20A@TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM>


[-- Attachment #1.1: Type: text/plain, Size: 543 bytes --]

On Sat, Jun 24, 2023 at 07:36:02PM +0000, YE Chengfeng wrote:
> iproc_i2c_rd_reg and iproc_i2c_wr_reg are called from both
> interrupt context (e.g. bcm_iproc_i2c_isr) and process context
> (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be
> disabled to avoid potential deadlock. To prevent this deadlock,
> use spin_lock_irqsave.
> 
> Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>

I can't apply it, what version is this against? Also, if someone could
supply a proper Fixes-tag, this would be much appreciated.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-07-06 19:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 19:36 [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue YE Chengfeng
2023-06-24 19:36 ` YE Chengfeng
2023-06-26 16:42 ` Ray Jui
2023-06-26 16:42   ` Ray Jui
2023-06-26 17:05   ` YE Chengfeng
2023-06-26 17:05     ` YE Chengfeng
2023-06-26 17:18     ` Ray Jui
2023-06-26 17:18       ` Ray Jui
2023-07-06 19:36 ` Wolfram Sang [this message]
2023-07-06 19:36   ` Wolfram Sang
2023-07-06 20:08   ` Ray Jui
2023-07-06 20:08     ` Ray Jui
2023-07-06 21:28     ` YE Chengfeng
2023-07-06 21:28       ` YE Chengfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZKcXrt3vGzncO/0d@shikoro \
    --to=wsa@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cyeaa@connect.ust.hk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.