All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ray Jui <ray.jui@broadcom.com>
To: YE Chengfeng <cyeaa@connect.ust.hk>
Cc: "andi.shyti@kernel.org" <andi.shyti@kernel.org>,
	"rjui@broadcom.com" <rjui@broadcom.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com" 
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue
Date: Mon, 26 Jun 2023 10:18:15 -0700	[thread overview]
Message-ID: <f945b683-dc1e-df50-adb1-5bbe41562d1e@broadcom.com> (raw)
In-Reply-To: <60931201-FD2A-4579-861E-E9573B7C2B38@connect.ust.hk>

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]



On 6/26/2023 10:05 AM, YE Chengfeng wrote:
>> This fix looks good to me. Thanks. Just curious, did you actually see a
>> race condition issue as a result of this, or the fix is done completely
>> based on the analysis of the code?
> 
> Thanks for the reply!
> 
> This bug is detected by a static analysis tool built by me, I just notice I should 
> mention this in the commit message and sorry for not have made it clear. I noticed 
> lockdep occasionally reported such similar deadlocks in other place thus built the 
> static tool to locate such bugs.
> 
> Just feel free to let me know if anything in the patch should be improved.
> 
> Best Regards,
> Chengfeng

This sounds good. Thanks again, Chengfeng!

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Ray Jui <ray.jui@broadcom.com>
To: YE Chengfeng <cyeaa@connect.ust.hk>
Cc: "andi.shyti@kernel.org" <andi.shyti@kernel.org>,
	"rjui@broadcom.com" <rjui@broadcom.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue
Date: Mon, 26 Jun 2023 10:18:15 -0700	[thread overview]
Message-ID: <f945b683-dc1e-df50-adb1-5bbe41562d1e@broadcom.com> (raw)
In-Reply-To: <60931201-FD2A-4579-861E-E9573B7C2B38@connect.ust.hk>


[-- Attachment #1.1: Type: text/plain, Size: 711 bytes --]



On 6/26/2023 10:05 AM, YE Chengfeng wrote:
>> This fix looks good to me. Thanks. Just curious, did you actually see a
>> race condition issue as a result of this, or the fix is done completely
>> based on the analysis of the code?
> 
> Thanks for the reply!
> 
> This bug is detected by a static analysis tool built by me, I just notice I should 
> mention this in the commit message and sorry for not have made it clear. I noticed 
> lockdep occasionally reported such similar deadlocks in other place thus built the 
> static tool to locate such bugs.
> 
> Just feel free to let me know if anything in the patch should be improved.
> 
> Best Regards,
> Chengfeng

This sounds good. Thanks again, Chengfeng!

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-26 17:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 19:36 [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue YE Chengfeng
2023-06-24 19:36 ` YE Chengfeng
2023-06-26 16:42 ` Ray Jui
2023-06-26 16:42   ` Ray Jui
2023-06-26 17:05   ` YE Chengfeng
2023-06-26 17:05     ` YE Chengfeng
2023-06-26 17:18     ` Ray Jui [this message]
2023-06-26 17:18       ` Ray Jui
2023-07-06 19:36 ` Wolfram Sang
2023-07-06 19:36   ` Wolfram Sang
2023-07-06 20:08   ` Ray Jui
2023-07-06 20:08     ` Ray Jui
2023-07-06 21:28     ` YE Chengfeng
2023-07-06 21:28       ` YE Chengfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f945b683-dc1e-df50-adb1-5bbe41562d1e@broadcom.com \
    --to=ray.jui@broadcom.com \
    --cc=andi.shyti@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cyeaa@connect.ust.hk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.