All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Bin Meng <bmeng.cn@gmail.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG
Date: Mon, 31 Jul 2023 06:04:50 +0000	[thread overview]
Message-ID: <ZMdPAoKwSThZ7VTm@ubuntu01> (raw)
In-Reply-To: <20230728135415.15055-1-heinrich.schuchardt@canonical.com>

On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote:
> The EFI_RNG_PROTOCOL is needed for Linux' KASLR.
> 
> QEMU can provide a virtio-rng device to emulate a hardware random number
> generator which is supported by our virtio_rng driver.
> 
> Enabling CONFIG_DM_RNG will enable CONFIG_VIRTIO_RNG and
> CONFIG_EFI_RNG_PROTOCOL by default too.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  board/emulation/qemu-riscv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
> index 6114e1b812..21d6160f01 100644
> --- a/board/emulation/qemu-riscv/Kconfig
> +++ b/board/emulation/qemu-riscv/Kconfig
> @@ -53,6 +53,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>  	imply NVME
>  	imply PCI
>  	imply PCIE_ECAM_GENERIC
> +	imply DM_RNG
>  	imply SCSI
>  	imply DM_SCSI
>  	imply SYS_NS16550
> -- 
> 2.40.1
> 

Hi Heinrich,

This patch seems to cause CI: test/py/tests/test_efi_selftest.py to fail.
(https://source.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/666642)
Could you take a look at this and check if anything else needs modification?

Best regards,
Leo

  parent reply	other threads:[~2023-07-31  6:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 13:54 [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG Heinrich Schuchardt
2023-07-28 15:50 ` Bin Meng
2023-07-31  6:04 ` Leo Liang [this message]
2023-07-31  6:37   ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMdPAoKwSThZ7VTm@ubuntu01 \
    --to=ycliang@andestech.com \
    --cc=bmeng.cn@gmail.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.