[PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

[PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

[Heinrich Schuchardt]

The EFI_RNG_PROTOCOL is needed for Linux' KASLR.

QEMU can provide a virtio-rng device to emulate a hardware random number
generator which is supported by our virtio_rng driver.

Enabling CONFIG_DM_RNG will enable CONFIG_VIRTIO_RNG and
CONFIG_EFI_RNG_PROTOCOL by default too.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 board/emulation/qemu-riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
index 6114e1b812..21d6160f01 100644
--- a/board/emulation/qemu-riscv/Kconfig
+++ b/board/emulation/qemu-riscv/Kconfig
@@ -53,6 +53,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply NVME
 	imply PCI
 	imply PCIE_ECAM_GENERIC
+	imply DM_RNG
 	imply SCSI
 	imply DM_SCSI
 	imply SYS_NS16550
-- 
2.40.1

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

[Bin Meng]

On Fri, Jul 28, 2023 at 9:54 PM Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> The EFI_RNG_PROTOCOL is needed for Linux' KASLR.
>
> QEMU can provide a virtio-rng device to emulate a hardware random number
> generator which is supported by our virtio_rng driver.
>
> Enabling CONFIG_DM_RNG will enable CONFIG_VIRTIO_RNG and
> CONFIG_EFI_RNG_PROTOCOL by default too.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  board/emulation/qemu-riscv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

[Leo Liang]

On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote:
> The EFI_RNG_PROTOCOL is needed for Linux' KASLR.
> 
> QEMU can provide a virtio-rng device to emulate a hardware random number
> generator which is supported by our virtio_rng driver.
> 
> Enabling CONFIG_DM_RNG will enable CONFIG_VIRTIO_RNG and
> CONFIG_EFI_RNG_PROTOCOL by default too.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  board/emulation/qemu-riscv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
> index 6114e1b812..21d6160f01 100644
> --- a/board/emulation/qemu-riscv/Kconfig
> +++ b/board/emulation/qemu-riscv/Kconfig
> @@ -53,6 +53,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>  	imply NVME
>  	imply PCI
>  	imply PCIE_ECAM_GENERIC
> +	imply DM_RNG
>  	imply SCSI
>  	imply DM_SCSI
>  	imply SYS_NS16550
> -- 
> 2.40.1
> 

Hi Heinrich,

This patch seems to cause CI: test/py/tests/test_efi_selftest.py to fail.
(https://source.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/666642)
Could you take a look at this and check if anything else needs modification?

Best regards,
Leo

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

[Heinrich Schuchardt]

On 7/31/23 08:04, Leo Liang wrote:
> On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote:
>> The EFI_RNG_PROTOCOL is needed for Linux' KASLR.
>>
>> QEMU can provide a virtio-rng device to emulate a hardware random number
>> generator which is supported by our virtio_rng driver.
>>
>> Enabling CONFIG_DM_RNG will enable CONFIG_VIRTIO_RNG and
>> CONFIG_EFI_RNG_PROTOCOL by default too.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> ---
>>   board/emulation/qemu-riscv/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
>> index 6114e1b812..21d6160f01 100644
>> --- a/board/emulation/qemu-riscv/Kconfig
>> +++ b/board/emulation/qemu-riscv/Kconfig
>> @@ -53,6 +53,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>>   	imply NVME
>>   	imply PCI
>>   	imply PCIE_ECAM_GENERIC
>> +	imply DM_RNG
>>   	imply SCSI
>>   	imply DM_SCSI
>>   	imply SYS_NS16550
>> -- 
>> 2.40.1
>>
> 
> Hi Heinrich,
> 
> This patch seems to cause CI: test/py/tests/test_efi_selftest.py to fail.
> (https://source.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/666642)
> Could you take a look at this and check if anything else needs modification?
> 
> Best regards,
> Leo

Hello Leo,

thanks for sharing the test result.

u-boot-test-hooks does not enable device virtio-rng-pci on RISC-V. I 
will adjust this.

Best regards

Heinrich