From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Shavit <mshavit@google.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org,
robin.murphy@arm.com, nicolinc@nvidia.com,
jean-philippe@linaro.org
Subject: Re: [PATCH v2 1/8] iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg
Date: Tue, 1 Aug 2023 11:08:20 -0300 [thread overview]
Message-ID: <ZMkR1KgvohRuNzn4@nvidia.com> (raw)
In-Reply-To: <20230731184817.v2.1.I67ab103c18d882aedc8a08985af1fba70bca084e@changeid>
On Mon, Jul 31, 2023 at 06:48:11PM +0800, Michael Shavit wrote:
> s1_cfg describes the CD table that is inserted into an SMMU's STEs. It's
> weird for s1_cfg to also own ctx_desc which describes a CD that is
> inserted into that table. It is more appropriate for arm_smmu_domain to
> own ctx_desc.
>
> Signed-off-by: Michael Shavit <mshavit@google.com>
> ---
> Changes in v2:
> - Undo over-reaching column alignment change
>
> .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 2 +-
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 23 ++++++++++---------
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 6 +++--
> 3 files changed, 17 insertions(+), 14 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Shavit <mshavit@google.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org,
robin.murphy@arm.com, nicolinc@nvidia.com,
jean-philippe@linaro.org
Subject: Re: [PATCH v2 1/8] iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg
Date: Tue, 1 Aug 2023 11:08:20 -0300 [thread overview]
Message-ID: <ZMkR1KgvohRuNzn4@nvidia.com> (raw)
In-Reply-To: <20230731184817.v2.1.I67ab103c18d882aedc8a08985af1fba70bca084e@changeid>
On Mon, Jul 31, 2023 at 06:48:11PM +0800, Michael Shavit wrote:
> s1_cfg describes the CD table that is inserted into an SMMU's STEs. It's
> weird for s1_cfg to also own ctx_desc which describes a CD that is
> inserted into that table. It is more appropriate for arm_smmu_domain to
> own ctx_desc.
>
> Signed-off-by: Michael Shavit <mshavit@google.com>
> ---
> Changes in v2:
> - Undo over-reaching column alignment change
>
> .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 2 +-
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 23 ++++++++++---------
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 6 +++--
> 3 files changed, 17 insertions(+), 14 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-01 14:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 10:48 [PATCH v2 0/8] Refactor the SMMU's CD table ownership Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-07-31 10:48 ` [PATCH v2 1/8] iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 14:08 ` Jason Gunthorpe [this message]
2023-08-01 14:08 ` Jason Gunthorpe
2023-07-31 10:48 ` [PATCH v2 2/8] iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 4:14 ` Nicolin Chen
2023-08-01 4:14 ` Nicolin Chen
2023-08-01 8:00 ` Michael Shavit
2023-08-01 8:00 ` Michael Shavit
2023-08-01 13:43 ` Jason Gunthorpe
2023-08-01 13:43 ` Jason Gunthorpe
2023-07-31 10:48 ` [PATCH v2 3/8] iommu/arm-smmu-v3: Encapsulate ctx_desc_cfg init in alloc_cd_tables Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 14:09 ` Jason Gunthorpe
2023-08-01 14:09 ` Jason Gunthorpe
2023-07-31 10:48 ` [PATCH v2 4/8] iommu/arm-smmu-v3: move stall_enabled to the cd table Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 4:28 ` Nicolin Chen
2023-08-01 4:28 ` Nicolin Chen
2023-08-01 4:52 ` Nicolin Chen
2023-08-01 4:52 ` Nicolin Chen
2023-08-01 8:09 ` Michael Shavit
2023-08-01 8:09 ` Michael Shavit
2023-08-01 13:31 ` Jason Gunthorpe
2023-08-01 13:31 ` Jason Gunthorpe
2023-08-01 14:12 ` Jason Gunthorpe
2023-08-01 14:12 ` Jason Gunthorpe
2023-07-31 10:48 ` [PATCH v2 5/8] iommu/arm-smmu-v3: Skip cd sync if CD table isn't active Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 14:13 ` Jason Gunthorpe
2023-08-01 14:13 ` Jason Gunthorpe
2023-07-31 10:48 ` [PATCH v2 6/8] iommu/arm-smmu-v3: Refactor write_ctx_desc Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 14:18 ` Jason Gunthorpe
2023-08-01 14:18 ` Jason Gunthorpe
2023-08-01 17:03 ` Michael Shavit
2023-08-01 17:03 ` Michael Shavit
2023-07-31 10:48 ` [PATCH v2 7/8] iommu/arm-smmu-v3: Move CD table to arm_smmu_master Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 14:42 ` Jason Gunthorpe
2023-08-01 14:42 ` Jason Gunthorpe
2023-07-31 10:48 ` [PATCH v2 8/8] iommu/arm-smmu-v3: Rename cdcfg to cd_table Michael Shavit
2023-07-31 10:48 ` Michael Shavit
2023-08-01 14:44 ` Jason Gunthorpe
2023-08-01 14:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMkR1KgvohRuNzn4@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.