* [Nouveau] [PATCH] drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()
@ 2023-08-07 23:41 ` Faith Ekstrand
0 siblings, 0 replies; 4+ messages in thread
From: Faith Ekstrand @ 2023-08-07 23:41 UTC (permalink / raw)
To: dri-devel, nouveau; +Cc: Dave Airlie, Faith Ekstrand
The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
we actually want is 0 flags which tells it to just try to find the
fence and then return without waiting.
Signed-off-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_sched.c b/drivers/gpu/drm/nouveau/nouveau_sched.c
index b3b59fbec291..3424a1bf6af3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_sched.c
+++ b/drivers/gpu/drm/nouveau/nouveau_sched.c
@@ -142,7 +142,7 @@ sync_find_fence(struct nouveau_job *job,
ret = drm_syncobj_find_fence(job->file_priv,
sync->handle, point,
- sync->flags, fence);
+ 0 /* flags */, fence);
if (ret)
return ret;
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()
@ 2023-08-07 23:41 ` Faith Ekstrand
0 siblings, 0 replies; 4+ messages in thread
From: Faith Ekstrand @ 2023-08-07 23:41 UTC (permalink / raw)
To: dri-devel, nouveau; +Cc: Dave Airlie, Danilo Krummrich, Faith Ekstrand
The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
we actually want is 0 flags which tells it to just try to find the
fence and then return without waiting.
Signed-off-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_sched.c b/drivers/gpu/drm/nouveau/nouveau_sched.c
index b3b59fbec291..3424a1bf6af3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_sched.c
+++ b/drivers/gpu/drm/nouveau/nouveau_sched.c
@@ -142,7 +142,7 @@ sync_find_fence(struct nouveau_job *job,
ret = drm_syncobj_find_fence(job->file_priv,
sync->handle, point,
- sync->flags, fence);
+ 0 /* flags */, fence);
if (ret)
return ret;
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()
2023-08-07 23:41 ` Faith Ekstrand
@ 2023-08-08 1:08 ` Danilo Krummrich
-1 siblings, 0 replies; 4+ messages in thread
From: Danilo Krummrich @ 2023-08-08 1:08 UTC (permalink / raw)
To: Faith Ekstrand; +Cc: nouveau, Faith Ekstrand, dri-devel, Dave Airlie
On Mon, Aug 07, 2023 at 06:41:44PM -0500, Faith Ekstrand wrote:
> The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
> from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
> we actually want is 0 flags which tells it to just try to find the
> fence and then return without waiting.
Good catch!
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
>
> Signed-off-by: Faith Ekstrand <faith.ekstrand@collabora.com>
> Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_sched.c b/drivers/gpu/drm/nouveau/nouveau_sched.c
> index b3b59fbec291..3424a1bf6af3 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_sched.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_sched.c
> @@ -142,7 +142,7 @@ sync_find_fence(struct nouveau_job *job,
>
> ret = drm_syncobj_find_fence(job->file_priv,
> sync->handle, point,
> - sync->flags, fence);
> + 0 /* flags */, fence);
> if (ret)
> return ret;
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()
@ 2023-08-08 1:08 ` Danilo Krummrich
0 siblings, 0 replies; 4+ messages in thread
From: Danilo Krummrich @ 2023-08-08 1:08 UTC (permalink / raw)
To: Faith Ekstrand; +Cc: nouveau, Faith Ekstrand, dri-devel, Dave Airlie
On Mon, Aug 07, 2023 at 06:41:44PM -0500, Faith Ekstrand wrote:
> The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
> from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
> we actually want is 0 flags which tells it to just try to find the
> fence and then return without waiting.
Good catch!
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
>
> Signed-off-by: Faith Ekstrand <faith.ekstrand@collabora.com>
> Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_sched.c b/drivers/gpu/drm/nouveau/nouveau_sched.c
> index b3b59fbec291..3424a1bf6af3 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_sched.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_sched.c
> @@ -142,7 +142,7 @@ sync_find_fence(struct nouveau_job *job,
>
> ret = drm_syncobj_find_fence(job->file_priv,
> sync->handle, point,
> - sync->flags, fence);
> + 0 /* flags */, fence);
> if (ret)
> return ret;
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-08 1:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 23:41 [Nouveau] [PATCH] drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence() Faith Ekstrand
2023-08-07 23:41 ` Faith Ekstrand
2023-08-08 1:08 ` [Nouveau] " Danilo Krummrich
2023-08-08 1:08 ` Danilo Krummrich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.