All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
	"Andy Gross" <agross@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	alsa-devel@alsa-project.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	ath10k@lists.infradead.org, ath11k@lists.infradead.org,
	"Mark Brown" <broonie@kernel.org>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Christian Gmeiner" <christian.gmeiner@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	dri-devel@lists.freedesktop.org, "Emma Anholt" <emma@anholt.net>,
	etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	"Frank Rowand" <frowand.list@gmail.com>,
	iommu@lists.linux.dev,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Russell King" <linux+etnaviv@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Sinan Kaya" <okaya@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Vikash Garodia" <quic_vgarodia@quicinc.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Sean Paul" <sean@poorly.run>,
	"Stanimir Varbanov" <stanimir.k.varbanov@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Takashi Iwai" <tiwai@suse.com>, "Vinod Koul" <vkoul@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>, "Will Deacon" <will@kernel.org>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	"Joerg Roedel" <jroedel@suse.de>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Chen-Yu Tsai" <wenst@chromium.org>
Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()
Date: Mon, 21 Aug 2023 09:47:46 -0300	[thread overview]
Message-ID: <ZONc8myQKuBceAMf@nvidia.com> (raw)
In-Reply-To: <ZONYQyMSG17YMc_b@8bytes.org>

On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote:
> On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote:
> > The solution is to drop those locking patches entirely and rethink the whole
> > thing.
> 
> Agreed, that was exactly what I thought when looking at this patch.
> 
> I dropped the original 10 patches and the 4 fixes on-top from the IOMMU
> tree. This needs more investigation and adaption of the actual API users
> before it can be reconsidered.

Why did you drop the whole series? The group changes are fine

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
	"Andy Gross" <agross@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	alsa-devel@alsa-project.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	ath10k@lists.infradead.org, ath11k@lists.infradead.org,
	"Mark Brown" <broonie@kernel.org>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Christian Gmeiner" <christian.gmeiner@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	dri-devel@lists.freedesktop.org, "Emma Anholt" <emma@anholt.net>,
	etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	"Frank Rowand" <frowand.list@gmail.com>,
	iommu@lists.linux.dev,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Russell King" <linux+etnaviv@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Sinan Kaya" <okaya@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Vikash Garodia" <quic_vgarodia@quicinc.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Sean Paul" <sean@poorly.run>,
	"Stanimir Varbanov" <stanimir.k.varbanov@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Takashi Iwai" <tiwai@suse.com>, "Vinod Koul" <vkoul@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>, "Will Deacon" <will@kernel.org>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	"Joerg Roedel" <jroedel@suse.de>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Chen-Yu Tsai" <wenst@chromium.org>
Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()
Date: Mon, 21 Aug 2023 09:47:46 -0300	[thread overview]
Message-ID: <ZONc8myQKuBceAMf@nvidia.com> (raw)
In-Reply-To: <ZONYQyMSG17YMc_b@8bytes.org>

On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote:
> On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote:
> > The solution is to drop those locking patches entirely and rethink the whole
> > thing.
> 
> Agreed, that was exactly what I thought when looking at this patch.
> 
> I dropped the original 10 patches and the 4 fixes on-top from the IOMMU
> tree. This needs more investigation and adaption of the actual API users
> before it can be reconsidered.

Why did you drop the whole series? The group changes are fine

Jason

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
	"Andy Gross" <agross@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	alsa-devel@alsa-project.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	ath10k@lists.infradead.org, ath11k@lists.infradead.org,
	"Mark Brown" <broonie@kernel.org>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Christian Gmeiner" <christian.gmeiner@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	dri-devel@lists.freedesktop.org, "Emma Anholt" <emma@anholt.net>,
	etnaviv@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	"Frank Rowand" <frowand.list@gmail.com>,
	iommu@lists.linux.dev,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Russell King" <linux+etnaviv@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Sinan Kaya" <okaya@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Vikash Garodia" <quic_vgarodia@quicinc.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Sean Paul" <sean@poorly.run>,
	"Stanimir Varbanov" <stanimir.k.varbanov@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Takashi Iwai" <tiwai@suse.com>, "Vinod Koul" <vkoul@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>, "Will Deacon" <will@kernel.org>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	"Joerg Roedel" <jroedel@suse.de>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Chen-Yu Tsai" <wenst@chromium.org>
Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()
Date: Mon, 21 Aug 2023 09:47:46 -0300	[thread overview]
Message-ID: <ZONc8myQKuBceAMf@nvidia.com> (raw)
In-Reply-To: <ZONYQyMSG17YMc_b@8bytes.org>

On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote:
> On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote:
> > The solution is to drop those locking patches entirely and rethink the whole
> > thing.
> 
> Agreed, that was exactly what I thought when looking at this patch.
> 
> I dropped the original 10 patches and the 4 fixes on-top from the IOMMU
> tree. This needs more investigation and adaption of the actual API users
> before it can be reconsidered.

Why did you drop the whole series? The group changes are fine

Jason

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: alsa-devel@alsa-project.org, "Rafał Miłecki" <zajec5@gmail.com>,
	"Emma Anholt" <emma@anholt.net>,
	"Kevin Tian" <kevin.tian@intel.com>,
	dri-devel@lists.freedesktop.org,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Vikash Garodia" <quic_vgarodia@quicinc.com>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	ath10k@lists.infradead.org,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Takashi Iwai" <tiwai@suse.com>, "Sinan Kaya" <okaya@kernel.org>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	iommu@lists.linux.dev, "Andy Gross" <agross@kernel.org>,
	"Russell King" <linux+etnaviv@armlinux.org.uk>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	ath11k@lists.infradead.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, "Jaroslav Kysela" <perex@perex.cz>,
	"Joerg Roedel" <jroedel@suse.de>, "Will Deacon" <will@kernel.org>,
	linux-arm-msm@vger.kernel.org, "Kalle Valo" <kvalo@kernel.org>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	etnaviv@lists.freedesktop.org,
	"Maxime Ripard" <mripard@kernel.org>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	dmaengine@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
	linux-tegra@vger.kernel.org,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Sean Paul" <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org,
	freedreno@lists.freedesktop.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Stanimir Varbanov" <stanimir.k.varbanov@gmail.com>,
	linux-wireless@vger.kernel.org,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	linux-sunxi@lists.linux.dev,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	"Robin Murphy" <robin.murphy@arm.com>
Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()
Date: Mon, 21 Aug 2023 09:47:46 -0300	[thread overview]
Message-ID: <ZONc8myQKuBceAMf@nvidia.com> (raw)
In-Reply-To: <ZONYQyMSG17YMc_b@8bytes.org>

On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote:
> On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote:
> > The solution is to drop those locking patches entirely and rethink the whole
> > thing.
> 
> Agreed, that was exactly what I thought when looking at this patch.
> 
> I dropped the original 10 patches and the 4 fixes on-top from the IOMMU
> tree. This needs more investigation and adaption of the actual API users
> before it can be reconsidered.

Why did you drop the whole series? The group changes are fine

Jason

  reply	other threads:[~2023-08-24  7:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 21:32 [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Jason Gunthorpe
2023-08-18 21:32 ` Jason Gunthorpe
2023-08-18 21:32 ` Jason Gunthorpe
2023-08-18 21:32 ` Jason Gunthorpe
2023-08-18 22:47 ` Mark Brown
2023-08-18 22:47   ` Mark Brown
2023-08-18 22:47   ` Mark Brown
2023-08-18 22:47   ` Mark Brown
2023-08-21 11:06 ` Robin Murphy
2023-08-21 11:06   ` Robin Murphy
2023-08-21 11:06   ` Robin Murphy
2023-08-21 11:06   ` Robin Murphy
2023-08-21 12:27   ` Joerg Roedel
2023-08-21 12:27     ` Joerg Roedel
2023-08-21 12:27     ` Joerg Roedel
2023-08-21 12:27     ` Joerg Roedel
2023-08-21 12:47     ` Jason Gunthorpe [this message]
2023-08-21 12:47       ` Jason Gunthorpe
2023-08-21 12:47       ` Jason Gunthorpe
2023-08-21 12:47       ` Jason Gunthorpe
2023-08-21 12:51   ` Jason Gunthorpe
2023-08-21 12:51     ` Jason Gunthorpe
2023-08-21 12:51     ` Jason Gunthorpe
2023-08-21 12:51     ` Jason Gunthorpe
2023-08-21 14:36     ` Joerg Roedel
2023-08-21 14:36       ` Joerg Roedel
2023-08-21 14:36       ` Joerg Roedel
2023-08-21 14:36       ` Joerg Roedel
2023-08-21 14:40       ` Jason Gunthorpe
2023-08-21 14:40         ` Jason Gunthorpe
2023-08-21 14:40         ` Jason Gunthorpe
2023-08-21 14:40         ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZONc8myQKuBceAMf@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=andrzej.hajda@intel.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=christian.gmeiner@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=frowand.list@gmail.com \
    --cc=iommu@lists.linux.dev \
    --cc=jernej.skrabec@gmail.com \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=kevin.tian@intel.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=kvalo@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux+etnaviv@armlinux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mchehab@kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=mripard@kernel.org \
    --cc=okaya@kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=samuel@sholland.org \
    --cc=sean@poorly.run \
    --cc=stanimir.k.varbanov@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    --cc=wenst@chromium.org \
    --cc=will@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.