* [PATCH 0/2] Rpmsg support for i.MX DSP with resource table @ 2023-09-11 22:44 ` Iuliana Prodan (OSS) 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan (OSS) @ 2023-09-11 22:44 UTC (permalink / raw) To: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi From: Iuliana Prodan <iuliana.prodan@nxp.com> These patches are needed in order to support rpmsg on DSP when a resource table is available. Iuliana Prodan (2): remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op arm64: dts: imx8mp: add reserve-memory nodes for DSP arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ drivers/remoteproc/imx_dsp_rproc.c | 1 + 2 files changed, 13 insertions(+) -- 2.17.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 0/2] Rpmsg support for i.MX DSP with resource table @ 2023-09-11 22:44 ` Iuliana Prodan (OSS) 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan (OSS) @ 2023-09-11 22:44 UTC (permalink / raw) To: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi From: Iuliana Prodan <iuliana.prodan@nxp.com> These patches are needed in order to support rpmsg on DSP when a resource table is available. Iuliana Prodan (2): remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op arm64: dts: imx8mp: add reserve-memory nodes for DSP arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ drivers/remoteproc/imx_dsp_rproc.c | 1 + 2 files changed, 13 insertions(+) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op 2023-09-11 22:44 ` Iuliana Prodan (OSS) @ 2023-09-11 22:44 ` Iuliana Prodan (OSS) -1 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan (OSS) @ 2023-09-11 22:44 UTC (permalink / raw) To: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi From: Iuliana Prodan <iuliana.prodan@nxp.com> Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other allocated resources (carveouts etc) are stored. If this is not found, the vrings are not allocated and the IPC between cores will not work. Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> --- drivers/remoteproc/imx_dsp_rproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index 8fcda9b74545..a1c62d15f16c 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -940,6 +940,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = { .kick = imx_dsp_rproc_kick, .load = imx_dsp_rproc_elf_load_segments, .parse_fw = imx_dsp_rproc_parse_fw, + .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, .sanity_check = rproc_elf_sanity_check, .get_boot_addr = rproc_elf_get_boot_addr, }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op @ 2023-09-11 22:44 ` Iuliana Prodan (OSS) 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan (OSS) @ 2023-09-11 22:44 UTC (permalink / raw) To: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi From: Iuliana Prodan <iuliana.prodan@nxp.com> Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other allocated resources (carveouts etc) are stored. If this is not found, the vrings are not allocated and the IPC between cores will not work. Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> --- drivers/remoteproc/imx_dsp_rproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index 8fcda9b74545..a1c62d15f16c 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -940,6 +940,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = { .kick = imx_dsp_rproc_kick, .load = imx_dsp_rproc_elf_load_segments, .parse_fw = imx_dsp_rproc_parse_fw, + .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, .sanity_check = rproc_elf_sanity_check, .get_boot_addr = rproc_elf_get_boot_addr, }; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-11 22:44 ` Iuliana Prodan (OSS) @ 2023-09-11 22:44 ` Iuliana Prodan (OSS) -1 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan (OSS) @ 2023-09-11 22:44 UTC (permalink / raw) To: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi From: Iuliana Prodan <iuliana.prodan@nxp.com> Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. These can be later used in a dsp node, like: dsp: dsp@3b6e8000 { compatible = "fsl,imx8mp-dsp"; reg = <0x3b6e8000 0x88000>; mbox-names = "tx0", "rx0", "rxdb0"; mboxes = <&mu2 2 0>, <&mu2 2 1>, <&mu2 3 0>, <&mu2 3 1>; memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, <&dsp_vdev0vring1>, <&dsp_reserved>; status = "okay"; }; Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index cc406bb338fe..eedc1921af62 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -210,6 +210,18 @@ dsp_reserved: dsp@92400000 { reg = <0 0x92400000 0 0x2000000>; no-map; + dsp_vdev0vring0: vdev0vring0@942f0000 { + reg = <0 0x942f0000 0 0x8000>; + no-map; + }; + dsp_vdev0vring1: vdev0vring1@942f8000 { + reg = <0 0x942f8000 0 0x8000>; + no-map; + }; + dsp_vdev0buffer: vdev0buffer@94300000 { + compatible = "shared-dma-pool"; + reg = <0 0x94300000 0 0x100000>; + no-map; }; }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-11 22:44 ` Iuliana Prodan (OSS) 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan (OSS) @ 2023-09-11 22:44 UTC (permalink / raw) To: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi From: Iuliana Prodan <iuliana.prodan@nxp.com> Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. These can be later used in a dsp node, like: dsp: dsp@3b6e8000 { compatible = "fsl,imx8mp-dsp"; reg = <0x3b6e8000 0x88000>; mbox-names = "tx0", "rx0", "rxdb0"; mboxes = <&mu2 2 0>, <&mu2 2 1>, <&mu2 3 0>, <&mu2 3 1>; memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, <&dsp_vdev0vring1>, <&dsp_reserved>; status = "okay"; }; Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index cc406bb338fe..eedc1921af62 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -210,6 +210,18 @@ dsp_reserved: dsp@92400000 { reg = <0 0x92400000 0 0x2000000>; no-map; + dsp_vdev0vring0: vdev0vring0@942f0000 { + reg = <0 0x942f0000 0 0x8000>; + no-map; + }; + dsp_vdev0vring1: vdev0vring1@942f8000 { + reg = <0 0x942f8000 0 0x8000>; + no-map; + }; + dsp_vdev0buffer: vdev0buffer@94300000 { + compatible = "shared-dma-pool"; + reg = <0 0x94300000 0 0x100000>; + no-map; }; }; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-11 22:44 ` Iuliana Prodan (OSS) @ 2023-09-12 7:07 ` Krzysztof Kozlowski -1 siblings, 0 replies; 28+ messages in thread From: Krzysztof Kozlowski @ 2023-09-12 7:07 UTC (permalink / raw) To: Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan <iuliana.prodan@nxp.com> > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000 0x88000>; > mbox-names = "tx0", "rx0", "rxdb0"; > mboxes = <&mu2 2 0>, <&mu2 2 1>, > <&mu2 3 0>, <&mu2 3 1>; > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > <&dsp_vdev0vring1>, <&dsp_reserved>; > status = "okay"; Drop this example from commit msg, useless and not really correct. > }; > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index cc406bb338fe..eedc1921af62 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -210,6 +210,18 @@ > dsp_reserved: dsp@92400000 { > reg = <0 0x92400000 0 0x2000000>; > no-map; Please test the patches before sending. This does not build. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 7:07 ` Krzysztof Kozlowski 0 siblings, 0 replies; 28+ messages in thread From: Krzysztof Kozlowski @ 2023-09-12 7:07 UTC (permalink / raw) To: Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan <iuliana.prodan@nxp.com> > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000 0x88000>; > mbox-names = "tx0", "rx0", "rxdb0"; > mboxes = <&mu2 2 0>, <&mu2 2 1>, > <&mu2 3 0>, <&mu2 3 1>; > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > <&dsp_vdev0vring1>, <&dsp_reserved>; > status = "okay"; Drop this example from commit msg, useless and not really correct. > }; > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index cc406bb338fe..eedc1921af62 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -210,6 +210,18 @@ > dsp_reserved: dsp@92400000 { > reg = <0 0x92400000 0 0x2000000>; > no-map; Please test the patches before sending. This does not build. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 7:07 ` Krzysztof Kozlowski @ 2023-09-12 8:13 ` Iuliana Prodan -1 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 8:13 UTC (permalink / raw) To: Krzysztof Kozlowski, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: > On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >> From: Iuliana Prodan <iuliana.prodan@nxp.com> >> >> Add the reserve-memory nodes used by DSP when the rpmsg >> feature is enabled. >> These can be later used in a dsp node, like: >> dsp: dsp@3b6e8000 { >> compatible = "fsl,imx8mp-dsp"; >> reg = <0x3b6e8000 0x88000>; >> mbox-names = "tx0", "rx0", "rxdb0"; >> mboxes = <&mu2 2 0>, <&mu2 2 1>, >> <&mu2 3 0>, <&mu2 3 1>; >> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >> <&dsp_vdev0vring1>, <&dsp_reserved>; >> status = "okay"; > Drop this example from commit msg, useless and not really correct. Ok, will drop it. But this is a correct example, is just incomplete. >> }; >> >> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >> --- >> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> index cc406bb338fe..eedc1921af62 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> @@ -210,6 +210,18 @@ >> dsp_reserved: dsp@92400000 { >> reg = <0 0x92400000 0 0x2000000>; >> no-map; > Please test the patches before sending. This does not build. I've tested on remoteproc tree, but it seems I missed a bracket when sending upstream. Sorry abut this, will fix it in v2. Should I test this on other tree(s)? Thanks, Iulia > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 8:13 ` Iuliana Prodan 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 8:13 UTC (permalink / raw) To: Krzysztof Kozlowski, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: > On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >> From: Iuliana Prodan <iuliana.prodan@nxp.com> >> >> Add the reserve-memory nodes used by DSP when the rpmsg >> feature is enabled. >> These can be later used in a dsp node, like: >> dsp: dsp@3b6e8000 { >> compatible = "fsl,imx8mp-dsp"; >> reg = <0x3b6e8000 0x88000>; >> mbox-names = "tx0", "rx0", "rxdb0"; >> mboxes = <&mu2 2 0>, <&mu2 2 1>, >> <&mu2 3 0>, <&mu2 3 1>; >> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >> <&dsp_vdev0vring1>, <&dsp_reserved>; >> status = "okay"; > Drop this example from commit msg, useless and not really correct. Ok, will drop it. But this is a correct example, is just incomplete. >> }; >> >> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >> --- >> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> index cc406bb338fe..eedc1921af62 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> @@ -210,6 +210,18 @@ >> dsp_reserved: dsp@92400000 { >> reg = <0 0x92400000 0 0x2000000>; >> no-map; > Please test the patches before sending. This does not build. I've tested on remoteproc tree, but it seems I missed a bracket when sending upstream. Sorry abut this, will fix it in v2. Should I test this on other tree(s)? Thanks, Iulia > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 8:13 ` Iuliana Prodan @ 2023-09-12 8:26 ` Krzysztof Kozlowski -1 siblings, 0 replies; 28+ messages in thread From: Krzysztof Kozlowski @ 2023-09-12 8:26 UTC (permalink / raw) To: Iuliana Prodan, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 12/09/2023 10:13, Iuliana Prodan wrote: > On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: >> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >>> From: Iuliana Prodan <iuliana.prodan@nxp.com> >>> >>> Add the reserve-memory nodes used by DSP when the rpmsg >>> feature is enabled. >>> These can be later used in a dsp node, like: >>> dsp: dsp@3b6e8000 { >>> compatible = "fsl,imx8mp-dsp"; >>> reg = <0x3b6e8000 0x88000>; >>> mbox-names = "tx0", "rx0", "rxdb0"; >>> mboxes = <&mu2 2 0>, <&mu2 2 1>, >>> <&mu2 3 0>, <&mu2 3 1>; >>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >>> <&dsp_vdev0vring1>, <&dsp_reserved>; >>> status = "okay"; >> Drop this example from commit msg, useless and not really correct. > Ok, will drop it. But this is a correct example, is just incomplete. No, status=okay is redundant, thus it is not a correct example. >>> }; >>> >>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> index cc406bb338fe..eedc1921af62 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -210,6 +210,18 @@ >>> dsp_reserved: dsp@92400000 { >>> reg = <0 0x92400000 0 0x2000000>; >>> no-map; >> Please test the patches before sending. This does not build. > > I've tested on remoteproc tree, but it seems I missed a bracket when > sending upstream. Sorry abut this, will fix it in v2. No, this is not how testing works. You must test this patch. This means you tested something, then ported patch to entirely different tree, resolved conflicts in buggy way and send it without testing. Nope. > Should I test this on other tree(s)? You test the patch on the tree you send it. What is the point to test it on some old code, cherry-pick with bugs and then send? If you have cross-tree dependencies between subsystem, isn't linux-next for this? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 8:26 ` Krzysztof Kozlowski 0 siblings, 0 replies; 28+ messages in thread From: Krzysztof Kozlowski @ 2023-09-12 8:26 UTC (permalink / raw) To: Iuliana Prodan, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 12/09/2023 10:13, Iuliana Prodan wrote: > On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: >> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >>> From: Iuliana Prodan <iuliana.prodan@nxp.com> >>> >>> Add the reserve-memory nodes used by DSP when the rpmsg >>> feature is enabled. >>> These can be later used in a dsp node, like: >>> dsp: dsp@3b6e8000 { >>> compatible = "fsl,imx8mp-dsp"; >>> reg = <0x3b6e8000 0x88000>; >>> mbox-names = "tx0", "rx0", "rxdb0"; >>> mboxes = <&mu2 2 0>, <&mu2 2 1>, >>> <&mu2 3 0>, <&mu2 3 1>; >>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >>> <&dsp_vdev0vring1>, <&dsp_reserved>; >>> status = "okay"; >> Drop this example from commit msg, useless and not really correct. > Ok, will drop it. But this is a correct example, is just incomplete. No, status=okay is redundant, thus it is not a correct example. >>> }; >>> >>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> index cc406bb338fe..eedc1921af62 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -210,6 +210,18 @@ >>> dsp_reserved: dsp@92400000 { >>> reg = <0 0x92400000 0 0x2000000>; >>> no-map; >> Please test the patches before sending. This does not build. > > I've tested on remoteproc tree, but it seems I missed a bracket when > sending upstream. Sorry abut this, will fix it in v2. No, this is not how testing works. You must test this patch. This means you tested something, then ported patch to entirely different tree, resolved conflicts in buggy way and send it without testing. Nope. > Should I test this on other tree(s)? You test the patch on the tree you send it. What is the point to test it on some old code, cherry-pick with bugs and then send? If you have cross-tree dependencies between subsystem, isn't linux-next for this? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 8:26 ` Krzysztof Kozlowski @ 2023-09-12 8:49 ` Iuliana Prodan -1 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 8:49 UTC (permalink / raw) To: Krzysztof Kozlowski, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: > On 12/09/2023 10:13, Iuliana Prodan wrote: >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >>>> From: Iuliana Prodan <iuliana.prodan@nxp.com> >>>> >>>> Add the reserve-memory nodes used by DSP when the rpmsg >>>> feature is enabled. >>>> These can be later used in a dsp node, like: >>>> dsp: dsp@3b6e8000 { >>>> compatible = "fsl,imx8mp-dsp"; >>>> reg = <0x3b6e8000 0x88000>; >>>> mbox-names = "tx0", "rx0", "rxdb0"; >>>> mboxes = <&mu2 2 0>, <&mu2 2 1>, >>>> <&mu2 3 0>, <&mu2 3 1>; >>>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >>>> <&dsp_vdev0vring1>, <&dsp_reserved>; >>>> status = "okay"; >>> Drop this example from commit msg, useless and not really correct. >> Ok, will drop it. But this is a correct example, is just incomplete. > No, status=okay is redundant, thus it is not a correct example. ok >>>> }; >>>> >>>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >>>> --- >>>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>>> index cc406bb338fe..eedc1921af62 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>>> @@ -210,6 +210,18 @@ >>>> dsp_reserved: dsp@92400000 { >>>> reg = <0 0x92400000 0 0x2000000>; >>>> no-map; >>> Please test the patches before sending. This does not build. >> I've tested on remoteproc tree, but it seems I missed a bracket when >> sending upstream. Sorry abut this, will fix it in v2. > No, this is not how testing works. You must test this patch. This means > you tested something, then ported patch to entirely different tree, > resolved conflicts in buggy way and send it without testing. Nope. > >> Should I test this on other tree(s)? > You test the patch on the tree you send it. What is the point to test it > on some old code, cherry-pick with bugs and then send? > > If you have cross-tree dependencies between subsystem, isn't linux-next > for this? TBH, I don't know, that's why I asked. For sure one patch is for remoteproc. For the other, I don't know who will pick it, but I'll tested on linux-next, as you suggested. Thanks, Iulia > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 8:49 ` Iuliana Prodan 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 8:49 UTC (permalink / raw) To: Krzysztof Kozlowski, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: > On 12/09/2023 10:13, Iuliana Prodan wrote: >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >>>> From: Iuliana Prodan <iuliana.prodan@nxp.com> >>>> >>>> Add the reserve-memory nodes used by DSP when the rpmsg >>>> feature is enabled. >>>> These can be later used in a dsp node, like: >>>> dsp: dsp@3b6e8000 { >>>> compatible = "fsl,imx8mp-dsp"; >>>> reg = <0x3b6e8000 0x88000>; >>>> mbox-names = "tx0", "rx0", "rxdb0"; >>>> mboxes = <&mu2 2 0>, <&mu2 2 1>, >>>> <&mu2 3 0>, <&mu2 3 1>; >>>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >>>> <&dsp_vdev0vring1>, <&dsp_reserved>; >>>> status = "okay"; >>> Drop this example from commit msg, useless and not really correct. >> Ok, will drop it. But this is a correct example, is just incomplete. > No, status=okay is redundant, thus it is not a correct example. ok >>>> }; >>>> >>>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >>>> --- >>>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>>> index cc406bb338fe..eedc1921af62 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>>> @@ -210,6 +210,18 @@ >>>> dsp_reserved: dsp@92400000 { >>>> reg = <0 0x92400000 0 0x2000000>; >>>> no-map; >>> Please test the patches before sending. This does not build. >> I've tested on remoteproc tree, but it seems I missed a bracket when >> sending upstream. Sorry abut this, will fix it in v2. > No, this is not how testing works. You must test this patch. This means > you tested something, then ported patch to entirely different tree, > resolved conflicts in buggy way and send it without testing. Nope. > >> Should I test this on other tree(s)? > You test the patch on the tree you send it. What is the point to test it > on some old code, cherry-pick with bugs and then send? > > If you have cross-tree dependencies between subsystem, isn't linux-next > for this? TBH, I don't know, that's why I asked. For sure one patch is for remoteproc. For the other, I don't know who will pick it, but I'll tested on linux-next, as you suggested. Thanks, Iulia > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 8:49 ` Iuliana Prodan @ 2023-09-12 9:36 ` Krzysztof Kozlowski -1 siblings, 0 replies; 28+ messages in thread From: Krzysztof Kozlowski @ 2023-09-12 9:36 UTC (permalink / raw) To: Iuliana Prodan, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 12/09/2023 10:49, Iuliana Prodan wrote: >>> Should I test this on other tree(s)? >> You test the patch on the tree you send it. What is the point to test it >> on some old code, cherry-pick with bugs and then send? >> >> If you have cross-tree dependencies between subsystem, isn't linux-next >> for this? > > TBH, I don't know, that's why I asked. > > For sure one patch is for remoteproc. > For the other, I don't know who will pick it, but I'll tested on > linux-next, as you suggested. MAINTAINERS file (and get_maintainers.pl) will tell you. Specifically, this does not look really related to remoteproc patch, so it should not be together in one patchset. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 9:36 ` Krzysztof Kozlowski 0 siblings, 0 replies; 28+ messages in thread From: Krzysztof Kozlowski @ 2023-09-12 9:36 UTC (permalink / raw) To: Iuliana Prodan, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw Cc: linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On 12/09/2023 10:49, Iuliana Prodan wrote: >>> Should I test this on other tree(s)? >> You test the patch on the tree you send it. What is the point to test it >> on some old code, cherry-pick with bugs and then send? >> >> If you have cross-tree dependencies between subsystem, isn't linux-next >> for this? > > TBH, I don't know, that's why I asked. > > For sure one patch is for remoteproc. > For the other, I don't know who will pick it, but I'll tested on > linux-next, as you suggested. MAINTAINERS file (and get_maintainers.pl) will tell you. Specifically, this does not look really related to remoteproc patch, so it should not be together in one patchset. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 9:36 ` Krzysztof Kozlowski @ 2023-09-12 10:51 ` Iuliana Prodan -1 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 10:51 UTC (permalink / raw) To: Mathieu Poirier Cc: Krzysztof Kozlowski, robh+dt, devicetree, Fabio Estevam, S.J. Wang, Sascha Hauer, Bjorn Andersson, Shawn Guo, conor+dt, krzysztof.kozlowski+dt, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi, Daniel Baluta, Mpuaudiosw, Iuliana Prodan (OSS) On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote: > On 12/09/2023 10:49, Iuliana Prodan wrote: >>>> Should I test this on other tree(s)? >>> You test the patch on the tree you send it. What is the point to test it >>> on some old code, cherry-pick with bugs and then send? >>> >>> If you have cross-tree dependencies between subsystem, isn't linux-next >>> for this? >> TBH, I don't know, that's why I asked. >> >> For sure one patch is for remoteproc. >> For the other, I don't know who will pick it, but I'll tested on >> linux-next, as you suggested. > MAINTAINERS file (and get_maintainers.pl) will tell you. Specifically, > this does not look really related to remoteproc patch, so it should not > be together in one patchset. Hi Mathieu, I need to send a v2 - to fix the dtsi missing bracket on patch 2. So, should I keep the 2 patches together or send them separately? Thanks, Iulia ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 10:51 ` Iuliana Prodan 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 10:51 UTC (permalink / raw) To: Mathieu Poirier Cc: Krzysztof Kozlowski, robh+dt, devicetree, Fabio Estevam, S.J. Wang, Sascha Hauer, Bjorn Andersson, Shawn Guo, conor+dt, krzysztof.kozlowski+dt, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi, Daniel Baluta, Mpuaudiosw, Iuliana Prodan (OSS) On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote: > On 12/09/2023 10:49, Iuliana Prodan wrote: >>>> Should I test this on other tree(s)? >>> You test the patch on the tree you send it. What is the point to test it >>> on some old code, cherry-pick with bugs and then send? >>> >>> If you have cross-tree dependencies between subsystem, isn't linux-next >>> for this? >> TBH, I don't know, that's why I asked. >> >> For sure one patch is for remoteproc. >> For the other, I don't know who will pick it, but I'll tested on >> linux-next, as you suggested. > MAINTAINERS file (and get_maintainers.pl) will tell you. Specifically, > this does not look really related to remoteproc patch, so it should not > be together in one patchset. Hi Mathieu, I need to send a v2 - to fix the dtsi missing bracket on patch 2. So, should I keep the 2 patches together or send them separately? Thanks, Iulia _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 10:51 ` Iuliana Prodan @ 2023-09-12 14:41 ` Mathieu Poirier -1 siblings, 0 replies; 28+ messages in thread From: Mathieu Poirier @ 2023-09-12 14:41 UTC (permalink / raw) To: Iuliana Prodan Cc: Krzysztof Kozlowski, robh+dt, devicetree, Fabio Estevam, S.J. Wang, Sascha Hauer, Bjorn Andersson, Shawn Guo, conor+dt, krzysztof.kozlowski+dt, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi, Daniel Baluta, Mpuaudiosw, Iuliana Prodan (OSS) On Tue, Sep 12, 2023 at 01:51:42PM +0300, Iuliana Prodan wrote: > On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:49, Iuliana Prodan wrote: > > > > > Should I test this on other tree(s)? > > > > You test the patch on the tree you send it. What is the point to test it > > > > on some old code, cherry-pick with bugs and then send? > > > > > > > > If you have cross-tree dependencies between subsystem, isn't linux-next > > > > for this? > > > TBH, I don't know, that's why I asked. > > > > > > For sure one patch is for remoteproc. > > > For the other, I don't know who will pick it, but I'll tested on > > > linux-next, as you suggested. > > MAINTAINERS file (and get_maintainers.pl) will tell you. Specifically, > > this does not look really related to remoteproc patch, so it should not > > be together in one patchset. > > Hi Mathieu, > > I need to send a v2 - to fix the dtsi missing bracket on patch 2. > So, should I keep the 2 patches together or send them separately? > Marco is already aware of this patchset so I would keep them together. > Thanks, > Iulia > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 14:41 ` Mathieu Poirier 0 siblings, 0 replies; 28+ messages in thread From: Mathieu Poirier @ 2023-09-12 14:41 UTC (permalink / raw) To: Iuliana Prodan Cc: Krzysztof Kozlowski, robh+dt, devicetree, Fabio Estevam, S.J. Wang, Sascha Hauer, Bjorn Andersson, Shawn Guo, conor+dt, krzysztof.kozlowski+dt, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi, Daniel Baluta, Mpuaudiosw, Iuliana Prodan (OSS) On Tue, Sep 12, 2023 at 01:51:42PM +0300, Iuliana Prodan wrote: > On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:49, Iuliana Prodan wrote: > > > > > Should I test this on other tree(s)? > > > > You test the patch on the tree you send it. What is the point to test it > > > > on some old code, cherry-pick with bugs and then send? > > > > > > > > If you have cross-tree dependencies between subsystem, isn't linux-next > > > > for this? > > > TBH, I don't know, that's why I asked. > > > > > > For sure one patch is for remoteproc. > > > For the other, I don't know who will pick it, but I'll tested on > > > linux-next, as you suggested. > > MAINTAINERS file (and get_maintainers.pl) will tell you. Specifically, > > this does not look really related to remoteproc patch, so it should not > > be together in one patchset. > > Hi Mathieu, > > I need to send a v2 - to fix the dtsi missing bracket on patch 2. > So, should I keep the 2 patches together or send them separately? > Marco is already aware of this patchset so I would keep them together. > Thanks, > Iulia > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 8:49 ` Iuliana Prodan @ 2023-09-12 10:58 ` Daniel Baluta -1 siblings, 0 replies; 28+ messages in thread From: Daniel Baluta @ 2023-09-12 10:58 UTC (permalink / raw) To: Iuliana Prodan Cc: Krzysztof Kozlowski, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On Tue, Sep 12, 2023 at 12:54 PM Iuliana Prodan <iuliana.prodan@nxp.com> wrote: > > On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:13, Iuliana Prodan wrote: > >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: > >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > >>>> From: Iuliana Prodan <iuliana.prodan@nxp.com> > >>>> > >>>> Add the reserve-memory nodes used by DSP when the rpmsg > >>>> feature is enabled. > >>>> These can be later used in a dsp node, like: > >>>> dsp: dsp@3b6e8000 { > >>>> compatible = "fsl,imx8mp-dsp"; > >>>> reg = <0x3b6e8000 0x88000>; > >>>> mbox-names = "tx0", "rx0", "rxdb0"; > >>>> mboxes = <&mu2 2 0>, <&mu2 2 1>, > >>>> <&mu2 3 0>, <&mu2 3 1>; > >>>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > >>>> <&dsp_vdev0vring1>, <&dsp_reserved>; > >>>> status = "okay"; > >>> Drop this example from commit msg, useless and not really correct. > >> Ok, will drop it. But this is a correct example, is just incomplete. > > No, status=okay is redundant, thus it is not a correct example. > ok > >>>> }; > >>>> > >>>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > >>>> --- > >>>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > >>>> 1 file changed, 12 insertions(+) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>>> index cc406bb338fe..eedc1921af62 100644 > >>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>>> @@ -210,6 +210,18 @@ > >>>> dsp_reserved: dsp@92400000 { > >>>> reg = <0 0x92400000 0 0x2000000>; > >>>> no-map; > >>> Please test the patches before sending. This does not build. > >> I've tested on remoteproc tree, but it seems I missed a bracket when > >> sending upstream. Sorry abut this, will fix it in v2. > > No, this is not how testing works. You must test this patch. This means > > you tested something, then ported patch to entirely different tree, > > resolved conflicts in buggy way and send it without testing. Nope. > > > >> Should I test this on other tree(s)? > > You test the patch on the tree you send it. What is the point to test it > > on some old code, cherry-pick with bugs and then send? > > > > If you have cross-tree dependencies between subsystem, isn't linux-next > > for this? linux-next tree is the tree we want. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 10:58 ` Daniel Baluta 0 siblings, 0 replies; 28+ messages in thread From: Daniel Baluta @ 2023-09-12 10:58 UTC (permalink / raw) To: Iuliana Prodan Cc: Krzysztof Kozlowski, Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Pengutronix Kernel Team, LnxRevLi On Tue, Sep 12, 2023 at 12:54 PM Iuliana Prodan <iuliana.prodan@nxp.com> wrote: > > On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:13, Iuliana Prodan wrote: > >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: > >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > >>>> From: Iuliana Prodan <iuliana.prodan@nxp.com> > >>>> > >>>> Add the reserve-memory nodes used by DSP when the rpmsg > >>>> feature is enabled. > >>>> These can be later used in a dsp node, like: > >>>> dsp: dsp@3b6e8000 { > >>>> compatible = "fsl,imx8mp-dsp"; > >>>> reg = <0x3b6e8000 0x88000>; > >>>> mbox-names = "tx0", "rx0", "rxdb0"; > >>>> mboxes = <&mu2 2 0>, <&mu2 2 1>, > >>>> <&mu2 3 0>, <&mu2 3 1>; > >>>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > >>>> <&dsp_vdev0vring1>, <&dsp_reserved>; > >>>> status = "okay"; > >>> Drop this example from commit msg, useless and not really correct. > >> Ok, will drop it. But this is a correct example, is just incomplete. > > No, status=okay is redundant, thus it is not a correct example. > ok > >>>> }; > >>>> > >>>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > >>>> --- > >>>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > >>>> 1 file changed, 12 insertions(+) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>>> index cc406bb338fe..eedc1921af62 100644 > >>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > >>>> @@ -210,6 +210,18 @@ > >>>> dsp_reserved: dsp@92400000 { > >>>> reg = <0 0x92400000 0 0x2000000>; > >>>> no-map; > >>> Please test the patches before sending. This does not build. > >> I've tested on remoteproc tree, but it seems I missed a bracket when > >> sending upstream. Sorry abut this, will fix it in v2. > > No, this is not how testing works. You must test this patch. This means > > you tested something, then ported patch to entirely different tree, > > resolved conflicts in buggy way and send it without testing. Nope. > > > >> Should I test this on other tree(s)? > > You test the patch on the tree you send it. What is the point to test it > > on some old code, cherry-pick with bugs and then send? > > > > If you have cross-tree dependencies between subsystem, isn't linux-next > > for this? linux-next tree is the tree we want. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-11 22:44 ` Iuliana Prodan (OSS) @ 2023-09-12 11:30 ` Marco Felsch -1 siblings, 0 replies; 28+ messages in thread From: Marco Felsch @ 2023-09-12 11:30 UTC (permalink / raw) To: Iuliana Prodan (OSS) Cc: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan, linux-remoteproc, linux-kernel, LnxRevLi, linux-imx, Pengutronix Kernel Team, linux-arm-kernel Hi Iuliana, On 23-09-12, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan <iuliana.prodan@nxp.com> > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000 0x88000>; > mbox-names = "tx0", "rx0", "rxdb0"; > mboxes = <&mu2 2 0>, <&mu2 2 1>, > <&mu2 3 0>, <&mu2 3 1>; > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > <&dsp_vdev0vring1>, <&dsp_reserved>; > status = "okay"; > }; > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index cc406bb338fe..eedc1921af62 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -210,6 +210,18 @@ > dsp_reserved: dsp@92400000 { > reg = <0 0x92400000 0 0x2000000>; > no-map; This seems broken. Regards, Marco > + dsp_vdev0vring0: vdev0vring0@942f0000 { > + reg = <0 0x942f0000 0 0x8000>; > + no-map; > + }; > + dsp_vdev0vring1: vdev0vring1@942f8000 { > + reg = <0 0x942f8000 0 0x8000>; > + no-map; > + }; > + dsp_vdev0buffer: vdev0buffer@94300000 { > + compatible = "shared-dma-pool"; > + reg = <0 0x94300000 0 0x100000>; > + no-map; > }; > }; > > -- > 2.17.1 > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 11:30 ` Marco Felsch 0 siblings, 0 replies; 28+ messages in thread From: Marco Felsch @ 2023-09-12 11:30 UTC (permalink / raw) To: Iuliana Prodan (OSS) Cc: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, Iuliana Prodan, linux-remoteproc, linux-kernel, LnxRevLi, linux-imx, Pengutronix Kernel Team, linux-arm-kernel Hi Iuliana, On 23-09-12, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan <iuliana.prodan@nxp.com> > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000 0x88000>; > mbox-names = "tx0", "rx0", "rxdb0"; > mboxes = <&mu2 2 0>, <&mu2 2 1>, > <&mu2 3 0>, <&mu2 3 1>; > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > <&dsp_vdev0vring1>, <&dsp_reserved>; > status = "okay"; > }; > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index cc406bb338fe..eedc1921af62 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -210,6 +210,18 @@ > dsp_reserved: dsp@92400000 { > reg = <0 0x92400000 0 0x2000000>; > no-map; This seems broken. Regards, Marco > + dsp_vdev0vring0: vdev0vring0@942f0000 { > + reg = <0 0x942f0000 0 0x8000>; > + no-map; > + }; > + dsp_vdev0vring1: vdev0vring1@942f8000 { > + reg = <0 0x942f8000 0 0x8000>; > + no-map; > + }; > + dsp_vdev0buffer: vdev0buffer@94300000 { > + compatible = "shared-dma-pool"; > + reg = <0 0x94300000 0 0x100000>; > + no-map; > }; > }; > > -- > 2.17.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 11:30 ` Marco Felsch @ 2023-09-12 11:33 ` Iuliana Prodan -1 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 11:33 UTC (permalink / raw) To: Marco Felsch, Iuliana Prodan (OSS) Cc: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, linux-remoteproc, linux-kernel, LnxRevLi, linux-imx, Pengutronix Kernel Team, linux-arm-kernel On 9/12/2023 2:30 PM, Marco Felsch wrote: > Hi Iuliana, > > On 23-09-12, Iuliana Prodan (OSS) wrote: >> From: Iuliana Prodan <iuliana.prodan@nxp.com> >> >> Add the reserve-memory nodes used by DSP when the rpmsg >> feature is enabled. >> These can be later used in a dsp node, like: >> dsp: dsp@3b6e8000 { >> compatible = "fsl,imx8mp-dsp"; >> reg = <0x3b6e8000 0x88000>; >> mbox-names = "tx0", "rx0", "rxdb0"; >> mboxes = <&mu2 2 0>, <&mu2 2 1>, >> <&mu2 3 0>, <&mu2 3 1>; >> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >> <&dsp_vdev0vring1>, <&dsp_reserved>; >> status = "okay"; >> }; >> >> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >> --- >> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> index cc406bb338fe..eedc1921af62 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> @@ -210,6 +210,18 @@ >> dsp_reserved: dsp@92400000 { >> reg = <0 0x92400000 0 0x2000000>; >> no-map; > This seems broken. You're right. Already answered to this here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2558691.html Thanks, Iulia > Regards, > Marco > >> + dsp_vdev0vring0: vdev0vring0@942f0000 { >> + reg = <0 0x942f0000 0 0x8000>; >> + no-map; >> + }; >> + dsp_vdev0vring1: vdev0vring1@942f8000 { >> + reg = <0 0x942f8000 0 0x8000>; >> + no-map; >> + }; >> + dsp_vdev0buffer: vdev0buffer@94300000 { >> + compatible = "shared-dma-pool"; >> + reg = <0 0x94300000 0 0x100000>; >> + no-map; >> }; >> }; >> >> -- >> 2.17.1 >> >> >> ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 11:33 ` Iuliana Prodan 0 siblings, 0 replies; 28+ messages in thread From: Iuliana Prodan @ 2023-09-12 11:33 UTC (permalink / raw) To: Marco Felsch, Iuliana Prodan (OSS) Cc: Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, linux-remoteproc, linux-kernel, LnxRevLi, linux-imx, Pengutronix Kernel Team, linux-arm-kernel On 9/12/2023 2:30 PM, Marco Felsch wrote: > Hi Iuliana, > > On 23-09-12, Iuliana Prodan (OSS) wrote: >> From: Iuliana Prodan <iuliana.prodan@nxp.com> >> >> Add the reserve-memory nodes used by DSP when the rpmsg >> feature is enabled. >> These can be later used in a dsp node, like: >> dsp: dsp@3b6e8000 { >> compatible = "fsl,imx8mp-dsp"; >> reg = <0x3b6e8000 0x88000>; >> mbox-names = "tx0", "rx0", "rxdb0"; >> mboxes = <&mu2 2 0>, <&mu2 2 1>, >> <&mu2 3 0>, <&mu2 3 1>; >> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >> <&dsp_vdev0vring1>, <&dsp_reserved>; >> status = "okay"; >> }; >> >> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> >> --- >> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> index cc406bb338fe..eedc1921af62 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >> @@ -210,6 +210,18 @@ >> dsp_reserved: dsp@92400000 { >> reg = <0 0x92400000 0 0x2000000>; >> no-map; > This seems broken. You're right. Already answered to this here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2558691.html Thanks, Iulia > Regards, > Marco > >> + dsp_vdev0vring0: vdev0vring0@942f0000 { >> + reg = <0 0x942f0000 0 0x8000>; >> + no-map; >> + }; >> + dsp_vdev0vring1: vdev0vring1@942f8000 { >> + reg = <0 0x942f8000 0 0x8000>; >> + no-map; >> + }; >> + dsp_vdev0buffer: vdev0buffer@94300000 { >> + compatible = "shared-dma-pool"; >> + reg = <0 0x94300000 0 0x100000>; >> + no-map; >> }; >> }; >> >> -- >> 2.17.1 >> >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP 2023-09-12 11:33 ` Iuliana Prodan @ 2023-09-12 11:42 ` Marco Felsch -1 siblings, 0 replies; 28+ messages in thread From: Marco Felsch @ 2023-09-12 11:42 UTC (permalink / raw) To: Iuliana Prodan Cc: Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, linux-remoteproc, linux-kernel, LnxRevLi, linux-imx, Pengutronix Kernel Team, linux-arm-kernel On 23-09-12, Iuliana Prodan wrote: > On 9/12/2023 2:30 PM, Marco Felsch wrote: > > Hi Iuliana, > > > > On 23-09-12, Iuliana Prodan (OSS) wrote: > > > From: Iuliana Prodan <iuliana.prodan@nxp.com> > > > > > > Add the reserve-memory nodes used by DSP when the rpmsg > > > feature is enabled. > > > These can be later used in a dsp node, like: > > > dsp: dsp@3b6e8000 { > > > compatible = "fsl,imx8mp-dsp"; > > > reg = <0x3b6e8000 0x88000>; > > > mbox-names = "tx0", "rx0", "rxdb0"; > > > mboxes = <&mu2 2 0>, <&mu2 2 1>, > > > <&mu2 3 0>, <&mu2 3 1>; > > > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > > > <&dsp_vdev0vring1>, <&dsp_reserved>; > > > status = "okay"; > > > }; > > > > > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > index cc406bb338fe..eedc1921af62 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -210,6 +210,18 @@ > > > dsp_reserved: dsp@92400000 { > > > reg = <0 0x92400000 0 0x2000000>; > > > no-map; > > This seems broken. > > > You're right. > Already answered to this here: > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2558691.html Sorry, saw it to late.. Regards, Marco ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP @ 2023-09-12 11:42 ` Marco Felsch 0 siblings, 0 replies; 28+ messages in thread From: Marco Felsch @ 2023-09-12 11:42 UTC (permalink / raw) To: Iuliana Prodan Cc: Iuliana Prodan (OSS), Mathieu Poirier, robh+dt, krzysztof.kozlowski+dt, conor+dt, Shawn Guo, Bjorn Andersson, Sascha Hauer, S.J. Wang, Fabio Estevam, devicetree, Daniel Baluta, Mpuaudiosw, linux-remoteproc, linux-kernel, LnxRevLi, linux-imx, Pengutronix Kernel Team, linux-arm-kernel On 23-09-12, Iuliana Prodan wrote: > On 9/12/2023 2:30 PM, Marco Felsch wrote: > > Hi Iuliana, > > > > On 23-09-12, Iuliana Prodan (OSS) wrote: > > > From: Iuliana Prodan <iuliana.prodan@nxp.com> > > > > > > Add the reserve-memory nodes used by DSP when the rpmsg > > > feature is enabled. > > > These can be later used in a dsp node, like: > > > dsp: dsp@3b6e8000 { > > > compatible = "fsl,imx8mp-dsp"; > > > reg = <0x3b6e8000 0x88000>; > > > mbox-names = "tx0", "rx0", "rxdb0"; > > > mboxes = <&mu2 2 0>, <&mu2 2 1>, > > > <&mu2 3 0>, <&mu2 3 1>; > > > memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > > > <&dsp_vdev0vring1>, <&dsp_reserved>; > > > status = "okay"; > > > }; > > > > > > Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > index cc406bb338fe..eedc1921af62 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -210,6 +210,18 @@ > > > dsp_reserved: dsp@92400000 { > > > reg = <0 0x92400000 0 0x2000000>; > > > no-map; > > This seems broken. > > > You're right. > Already answered to this here: > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2558691.html Sorry, saw it to late.. Regards, Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2023-09-12 14:41 UTC | newest] Thread overview: 28+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-11 22:44 [PATCH 0/2] Rpmsg support for i.MX DSP with resource table Iuliana Prodan (OSS) 2023-09-11 22:44 ` Iuliana Prodan (OSS) 2023-09-11 22:44 ` [PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op Iuliana Prodan (OSS) 2023-09-11 22:44 ` Iuliana Prodan (OSS) 2023-09-11 22:44 ` [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP Iuliana Prodan (OSS) 2023-09-11 22:44 ` Iuliana Prodan (OSS) 2023-09-12 7:07 ` Krzysztof Kozlowski 2023-09-12 7:07 ` Krzysztof Kozlowski 2023-09-12 8:13 ` Iuliana Prodan 2023-09-12 8:13 ` Iuliana Prodan 2023-09-12 8:26 ` Krzysztof Kozlowski 2023-09-12 8:26 ` Krzysztof Kozlowski 2023-09-12 8:49 ` Iuliana Prodan 2023-09-12 8:49 ` Iuliana Prodan 2023-09-12 9:36 ` Krzysztof Kozlowski 2023-09-12 9:36 ` Krzysztof Kozlowski 2023-09-12 10:51 ` Iuliana Prodan 2023-09-12 10:51 ` Iuliana Prodan 2023-09-12 14:41 ` Mathieu Poirier 2023-09-12 14:41 ` Mathieu Poirier 2023-09-12 10:58 ` Daniel Baluta 2023-09-12 10:58 ` Daniel Baluta 2023-09-12 11:30 ` Marco Felsch 2023-09-12 11:30 ` Marco Felsch 2023-09-12 11:33 ` Iuliana Prodan 2023-09-12 11:33 ` Iuliana Prodan 2023-09-12 11:42 ` Marco Felsch 2023-09-12 11:42 ` Marco Felsch
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.