From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: linux-hwmon@vger.kernel.org, intel-xe@lists.freedesktop.org,
linux@roeck-us.net
Subject: Re: [Intel-xe] [PATCH v5 1/6] drm/xe: Add XE_MISSING_CASE macro
Date: Thu, 21 Sep 2023 12:03:26 -0400 [thread overview]
Message-ID: <ZQxpTss3+OYdbJks@intel.com> (raw)
In-Reply-To: <20230921102519.3355538-2-badal.nilawar@intel.com>
On Thu, Sep 21, 2023 at 03:55:14PM +0530, Badal Nilawar wrote:
> Add XE_MISSING_CASE macro to handle missing switch case
>
> v2: Add comment about macro usage (Himal)
>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> drivers/gpu/drm/xe/xe_macros.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_macros.h b/drivers/gpu/drm/xe/xe_macros.h
> index daf56c846d03..6c74c69920ed 100644
> --- a/drivers/gpu/drm/xe/xe_macros.h
> +++ b/drivers/gpu/drm/xe/xe_macros.h
> @@ -15,4 +15,8 @@
> "Ioctl argument check failed at %s:%d: %s", \
> __FILE__, __LINE__, #cond), 1))
>
> +/* Parameter to macro should be a variable name */
> +#define XE_MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> + __stringify(x), (long)(x))
> +
No, please! Let's not add unnecessary macros.
> #endif
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <linux-hwmon@vger.kernel.org>,
<anshuman.gupta@intel.com>, <ashutosh.dixit@intel.com>,
<linux@roeck-us.net>, <andi.shyti@linux.intel.com>,
<riana.tauro@intel.com>, <matthew.brost@intel.com>
Subject: Re: [PATCH v5 1/6] drm/xe: Add XE_MISSING_CASE macro
Date: Thu, 21 Sep 2023 12:03:26 -0400 [thread overview]
Message-ID: <ZQxpTss3+OYdbJks@intel.com> (raw)
In-Reply-To: <20230921102519.3355538-2-badal.nilawar@intel.com>
On Thu, Sep 21, 2023 at 03:55:14PM +0530, Badal Nilawar wrote:
> Add XE_MISSING_CASE macro to handle missing switch case
>
> v2: Add comment about macro usage (Himal)
>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> drivers/gpu/drm/xe/xe_macros.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_macros.h b/drivers/gpu/drm/xe/xe_macros.h
> index daf56c846d03..6c74c69920ed 100644
> --- a/drivers/gpu/drm/xe/xe_macros.h
> +++ b/drivers/gpu/drm/xe/xe_macros.h
> @@ -15,4 +15,8 @@
> "Ioctl argument check failed at %s:%d: %s", \
> __FILE__, __LINE__, #cond), 1))
>
> +/* Parameter to macro should be a variable name */
> +#define XE_MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> + __stringify(x), (long)(x))
> +
No, please! Let's not add unnecessary macros.
> #endif
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-09-21 16:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 10:25 [Intel-xe] [PATCH v5 0/6] Add HWMON support for DGFX Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 10:21 ` [Intel-xe] ✓ CI.Patch_applied: success for Add HWMON support for DGFX (rev5) Patchwork
2023-09-21 10:21 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-21 10:23 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-21 10:25 ` [Intel-xe] [PATCH v5 1/6] drm/xe: Add XE_MISSING_CASE macro Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 16:03 ` Rodrigo Vivi [this message]
2023-09-21 16:03 ` Rodrigo Vivi
2023-09-21 16:59 ` [Intel-xe] " Nilawar, Badal
2023-09-21 16:59 ` Nilawar, Badal
2023-09-22 10:05 ` [Intel-xe] " Jani Nikula
2023-09-22 15:16 ` Andi Shyti
2023-09-22 15:16 ` Andi Shyti
2023-09-22 15:19 ` [Intel-xe] " Gupta, Anshuman
2023-09-22 15:19 ` Gupta, Anshuman
2023-09-25 12:08 ` [Intel-xe] " Jani Nikula
2023-09-22 19:03 ` Rodrigo Vivi
2023-09-22 19:03 ` Rodrigo Vivi
2023-09-25 4:07 ` [Intel-xe] " Nilawar, Badal
2023-09-25 4:07 ` Nilawar, Badal
2023-09-21 10:25 ` [Intel-xe] [PATCH v5 2/6] drm/xe/hwmon: Expose power attributes Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 13:22 ` [Intel-xe] " Riana Tauro
2023-09-21 13:22 ` Riana Tauro
2023-09-21 16:25 ` [Intel-xe] " Rodrigo Vivi
2023-09-21 16:25 ` Rodrigo Vivi
2023-09-22 9:57 ` Nilawar, Badal
2023-09-22 9:57 ` Nilawar, Badal
2023-09-22 17:24 ` Andi Shyti
2023-09-22 17:24 ` Andi Shyti
2023-09-25 4:34 ` [Intel-xe] " Nilawar, Badal
2023-09-25 4:34 ` Nilawar, Badal
2023-09-21 10:25 ` [Intel-xe] [PATCH v5 3/6] drm/xe/hwmon: Expose card reactive critical power Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 10:25 ` [Intel-xe] [PATCH v5 4/6] drm/xe/hwmon: Expose input voltage attribute Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 10:25 ` [Intel-xe] [PATCH v5 5/6] drm/xe/hwmon: Expose hwmon energy attribute Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 14:09 ` [Intel-xe] " Riana Tauro
2023-09-21 14:09 ` Riana Tauro
2023-09-21 10:25 ` [Intel-xe] [PATCH v5 6/6] drm/xe/hwmon: Expose power1_max_interval Badal Nilawar
2023-09-21 10:25 ` Badal Nilawar
2023-09-21 11:43 ` [Intel-xe] " Ghimiray, Himal Prasad
2023-09-21 11:43 ` Ghimiray, Himal Prasad
2023-09-22 9:49 ` Nilawar, Badal
2023-09-22 9:49 ` Nilawar, Badal
2023-09-22 12:43 ` Ghimiray, Himal Prasad
2023-09-22 12:43 ` Ghimiray, Himal Prasad
2023-09-21 10:30 ` [Intel-xe] ✓ CI.Build: success for Add HWMON support for DGFX (rev5) Patchwork
2023-09-21 10:30 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-21 10:31 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-09-21 11:05 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQxpTss3+OYdbJks@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.