From: Joel Becker <jlbec@evilplan.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
Eric Dumazet <edumazet@google.com>,
hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
horms@kernel.org
Subject: Re: [PATCH 1/3] netconsole: Initialize configfs_item for default targets
Date: Wed, 4 Oct 2023 12:59:38 -0700 [thread overview]
Message-ID: <ZR3EKnepIOKlVGgZ@google.com> (raw)
In-Reply-To: <20231002155349.2032826-2-leitao@debian.org>
On Mon, Oct 02, 2023 at 08:53:47AM -0700, Breno Leitao wrote:
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index 3111e1648592..b68456054a0c 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -53,6 +53,8 @@ static bool oops_only = false;
> module_param(oops_only, bool, 0600);
> MODULE_PARM_DESC(oops_only, "Only log oops messages");
>
> +#define DEFAULT_TARGET_NAME "cmdline"
> +
I'm not sure `DEFAULT` is the right terminology here. e.g. it's not a
default for dynamic targets, etc. Perhaps `BOOT_TARGET_NAME` or
`NETCONSOLE_PARAM_TARGET_NAME`?
Joel
--
"Friends may come and go, but enemies accumulate."
- Thomas Jones
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2023-10-04 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 15:53 [PATCH 0/3] net: netconsole: configfs entries for boot target Breno Leitao
2023-10-02 15:53 ` [PATCH 1/3] netconsole: Initialize configfs_item for default targets Breno Leitao
2023-10-04 19:59 ` Joel Becker [this message]
2023-10-02 15:53 ` [PATCH 2/3] netconsole: Attach cmdline target to dynamic target Breno Leitao
2023-10-04 20:02 ` Joel Becker
2023-10-02 15:53 ` [PATCH 3/3] Documentation: netconsole: add support for cmdline targets Breno Leitao
2023-10-04 20:09 ` Joel Becker
2023-10-05 10:29 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR3EKnepIOKlVGgZ@google.com \
--to=jlbec@evilplan.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.