All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <jlbec@evilplan.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
	Eric Dumazet <edumazet@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	horms@kernel.org,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 3/3] Documentation: netconsole: add support for cmdline targets
Date: Wed, 4 Oct 2023 13:09:16 -0700	[thread overview]
Message-ID: <ZR3GbHOyxx+J4FUn@google.com> (raw)
In-Reply-To: <20231002155349.2032826-4-leitao@debian.org>

On Mon, Oct 02, 2023 at 08:53:49AM -0700, Breno Leitao wrote:
> @@ -155,6 +152,24 @@ You can also update the local interface dynamically. This is especially
>  useful if you want to use interfaces that have newly come up (and may not
>  have existed when netconsole was loaded / initialized).
>  
> +You can control and modify the targets defined at boot time (or module load
> +time) by creating special targets names. These special targets are named
> +`cmdline` concatenated to an integer, example: `cmdline0`.

The special names are already "created", so perhaps it's a little
clearer to say something like:

```
+Netconsole targets defined at boot time (or module load time) with the
+`netconsole=` param are assigned the name `cmdline<index>`.  For
+example, the first target in the parameter is named `cmdline0`.  You
+can control and modify these targets by creating configfs directories
+with the matching name.
```

> +
> +Let's suppose you have two netconsole targets defined at boot time::
> +
> + netconsole=4444@10.0.0.1/eth1,9353@10.0.0.2/12:34:56:78:9a:bc;4444@10.0.0.1/eth1,9353@10.0.0.3/12:34:56:78:9a:bc
> +
> +You can modify these targets in runtime by creating the following targets::
> +
> + mkdir cmdline0
> + cat cmdline0/remote_ip
> + 10.0.0.2
> +
> + mkdir cmdline1
> + cat cmdline1/remote_ip
> + 10.0.0.3
> +

And of course keep the examples as you've described them.

Thanks,
Joel

-- 

Life's Little Instruction Book #337

	"Reread your favorite book."

			http://www.jlbec.org/
			jlbec@evilplan.org

  reply	other threads:[~2023-10-04 20:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 15:53 [PATCH 0/3] net: netconsole: configfs entries for boot target Breno Leitao
2023-10-02 15:53 ` [PATCH 1/3] netconsole: Initialize configfs_item for default targets Breno Leitao
2023-10-04 19:59   ` Joel Becker
2023-10-02 15:53 ` [PATCH 2/3] netconsole: Attach cmdline target to dynamic target Breno Leitao
2023-10-04 20:02   ` Joel Becker
2023-10-02 15:53 ` [PATCH 3/3] Documentation: netconsole: add support for cmdline targets Breno Leitao
2023-10-04 20:09   ` Joel Becker [this message]
2023-10-05 10:29     ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZR3GbHOyxx+J4FUn@google.com \
    --to=jlbec@evilplan.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hch@lst.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.