From: Breno Leitao <leitao@debian.org>
To: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
Eric Dumazet <edumazet@google.com>,
Jonathan Corbet <corbet@lwn.net>,
hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
horms@kernel.org,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 3/3] Documentation: netconsole: add support for cmdline targets
Date: Thu, 5 Oct 2023 03:29:02 -0700 [thread overview]
Message-ID: <ZR6P7isP8eEy9vdF@gmail.com> (raw)
In-Reply-To: <ZR3GbHOyxx+J4FUn@google.com>
On Wed, Oct 04, 2023 at 01:09:16PM -0700, Joel Becker wrote:
> On Mon, Oct 02, 2023 at 08:53:49AM -0700, Breno Leitao wrote:
> > @@ -155,6 +152,24 @@ You can also update the local interface dynamically. This is especially
> > useful if you want to use interfaces that have newly come up (and may not
> > have existed when netconsole was loaded / initialized).
> >
> > +You can control and modify the targets defined at boot time (or module load
> > +time) by creating special targets names. These special targets are named
> > +`cmdline` concatenated to an integer, example: `cmdline0`.
>
> The special names are already "created", so perhaps it's a little
> clearer to say something like:
>
> ```
> +Netconsole targets defined at boot time (or module load time) with the
> +`netconsole=` param are assigned the name `cmdline<index>`. For
> +example, the first target in the parameter is named `cmdline0`. You
> +can control and modify these targets by creating configfs directories
> +with the matching name.
> ```
That is way better. Thanks for the review.
I will send an updated version soon.
prev parent reply other threads:[~2023-10-05 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 15:53 [PATCH 0/3] net: netconsole: configfs entries for boot target Breno Leitao
2023-10-02 15:53 ` [PATCH 1/3] netconsole: Initialize configfs_item for default targets Breno Leitao
2023-10-04 19:59 ` Joel Becker
2023-10-02 15:53 ` [PATCH 2/3] netconsole: Attach cmdline target to dynamic target Breno Leitao
2023-10-04 20:02 ` Joel Becker
2023-10-02 15:53 ` [PATCH 3/3] Documentation: netconsole: add support for cmdline targets Breno Leitao
2023-10-04 20:09 ` Joel Becker
2023-10-05 10:29 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR6P7isP8eEy9vdF@gmail.com \
--to=leitao@debian.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.