From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: patches@armlinux.org.uk, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: make <linux/uaccess.h> self-contained for ARM
Date: Tue, 26 Sep 2023 18:28:32 +0100 [thread overview]
Message-ID: <ZRMUwGbWKN6OgMzM@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230926172253.73204-1-masahiroy@kernel.org>
On Wed, Sep 27, 2023 at 02:22:53AM +0900, Masahiro Yamada wrote:
> When I compiled the following code for ARM, I encountered numerous
> errors.
>
> [Test Code]
>
> #include <linux/compiler.h>
> #include <linux/uaccess.h>
>
> int foo(int *x, int __user *ptr)
> {
> return get_user(*x, ptr);
> }
>
> To fix them, make some asm headers self-contained:
>
> 1. In arch/arm/include/asm/traps.h, include <linux/init.h> for __init,
> and <linux/linkage.h> for asmlinkage.
Please drop the __init marking instead of adding linux/init.h, it's
not necessary.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: patches@armlinux.org.uk, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: make <linux/uaccess.h> self-contained for ARM
Date: Tue, 26 Sep 2023 18:28:32 +0100 [thread overview]
Message-ID: <ZRMUwGbWKN6OgMzM@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230926172253.73204-1-masahiroy@kernel.org>
On Wed, Sep 27, 2023 at 02:22:53AM +0900, Masahiro Yamada wrote:
> When I compiled the following code for ARM, I encountered numerous
> errors.
>
> [Test Code]
>
> #include <linux/compiler.h>
> #include <linux/uaccess.h>
>
> int foo(int *x, int __user *ptr)
> {
> return get_user(*x, ptr);
> }
>
> To fix them, make some asm headers self-contained:
>
> 1. In arch/arm/include/asm/traps.h, include <linux/init.h> for __init,
> and <linux/linkage.h> for asmlinkage.
Please drop the __init marking instead of adding linux/init.h, it's
not necessary.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-09-26 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 17:22 [PATCH] ARM: make <linux/uaccess.h> self-contained for ARM Masahiro Yamada
2023-09-26 17:22 ` Masahiro Yamada
2023-09-26 17:28 ` Russell King (Oracle) [this message]
2023-09-26 17:28 ` Russell King (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2023-09-27 17:06 Masahiro Yamada
2023-09-27 17:06 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRMUwGbWKN6OgMzM@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=patches@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.