From: Matthew Brost <matthew.brost@intel.com>
To: Luben Tuikov <luben.tuikov@amd.com>
Cc: robdclark@chromium.org, sarah.walker@imgtec.com,
ketil.johnsen@arm.com, Liviu.Dudau@arm.com, mcanal@igalia.com,
frank.binns@imgtec.com, dri-devel@lists.freedesktop.org,
christian.koenig@amd.com, boris.brezillon@collabora.com,
dakr@redhat.com, donald.robson@imgtec.com, daniel@ffwll.ch,
lina@asahilina.net, airlied@gmail.com,
intel-xe@lists.freedesktop.org, faith.ekstrand@collabora.com
Subject: Re: [Intel-xe] [PATCH v5 5/7] drm/sched: Split free_job into own work item
Date: Mon, 16 Oct 2023 15:12:09 +0000 [thread overview]
Message-ID: <ZS1SyZUvMLJFEEbB@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <c91d3a47-df4a-4be8-8f27-c850289df281@amd.com>
On Sat, Oct 14, 2023 at 08:09:31PM -0400, Luben Tuikov wrote:
> On 2023-10-13 22:49, Luben Tuikov wrote:
> > On 2023-10-11 19:58, Matthew Brost wrote:
> >> Rather than call free_job and run_job in same work item have a dedicated
> >> work item for each. This aligns with the design and intended use of work
> >> queues.
> >>
> >> v2:
> >> - Test for DMA_FENCE_FLAG_TIMESTAMP_BIT before setting
> >> timestamp in free_job() work item (Danilo)
> >> v3:
> >> - Drop forward dec of drm_sched_select_entity (Boris)
> >> - Return in drm_sched_run_job_work if entity NULL (Boris)
> >> v4:
> >> - Replace dequeue with peek and invert logic (Luben)
> >> - Wrap to 100 lines (Luben)
> >> - Update comments for *_queue / *_queue_if_ready functions (Luben)
> >>
> >> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> >
> > I wasn't able to apply this patch on top of drm-misc-next at a48e2cc92835fa.
> >
> > Create a branch off of a *clean* drm-misc-next and rebase/reapply/cherry-pick all
> > 7 patches on top of that clean drm-misc-next branch. You should also run
> > scripts/checkpatch.pl --strict on all your patches, or integrate it into the precommit
> > hook, see githooks(5), so you don't have to run it manually.
> >
> > Set format.useAutobase to whenAble somewhere in your Git configs (global/local),
> > or use --base=auto to git-format-patch when you format your patches before
> > git-send-email-ing them.
> >
> > Repost your patches.
> >
> > The base commit will be added to the bottom of the cover letter. It should
> > be an ancestor (or tip) of drm-misc-next (git branch --contains <base> --list etc.).
> > If it is not, your base tree wasn't clean, and you should redo this process.
>
> Poking around I found out that this patch set is based off of drm-misc-fixes.
> Had the base been included, it would've made this easier.
I believe I based this off of drm-tip. Will follow the flow mentioned above in next rev.
Matt
> --
> Regards,
> Luben
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Brost <matthew.brost@intel.com>
To: Luben Tuikov <luben.tuikov@amd.com>
Cc: robdclark@chromium.org, thomas.hellstrom@linux.intel.com,
sarah.walker@imgtec.com, ketil.johnsen@arm.com,
Liviu.Dudau@arm.com, mcanal@igalia.com,
dri-devel@lists.freedesktop.org, christian.koenig@amd.com,
boris.brezillon@collabora.com, dakr@redhat.com,
donald.robson@imgtec.com, lina@asahilina.net,
intel-xe@lists.freedesktop.org, faith.ekstrand@collabora.com
Subject: Re: [PATCH v5 5/7] drm/sched: Split free_job into own work item
Date: Mon, 16 Oct 2023 15:12:09 +0000 [thread overview]
Message-ID: <ZS1SyZUvMLJFEEbB@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <c91d3a47-df4a-4be8-8f27-c850289df281@amd.com>
On Sat, Oct 14, 2023 at 08:09:31PM -0400, Luben Tuikov wrote:
> On 2023-10-13 22:49, Luben Tuikov wrote:
> > On 2023-10-11 19:58, Matthew Brost wrote:
> >> Rather than call free_job and run_job in same work item have a dedicated
> >> work item for each. This aligns with the design and intended use of work
> >> queues.
> >>
> >> v2:
> >> - Test for DMA_FENCE_FLAG_TIMESTAMP_BIT before setting
> >> timestamp in free_job() work item (Danilo)
> >> v3:
> >> - Drop forward dec of drm_sched_select_entity (Boris)
> >> - Return in drm_sched_run_job_work if entity NULL (Boris)
> >> v4:
> >> - Replace dequeue with peek and invert logic (Luben)
> >> - Wrap to 100 lines (Luben)
> >> - Update comments for *_queue / *_queue_if_ready functions (Luben)
> >>
> >> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> >
> > I wasn't able to apply this patch on top of drm-misc-next at a48e2cc92835fa.
> >
> > Create a branch off of a *clean* drm-misc-next and rebase/reapply/cherry-pick all
> > 7 patches on top of that clean drm-misc-next branch. You should also run
> > scripts/checkpatch.pl --strict on all your patches, or integrate it into the precommit
> > hook, see githooks(5), so you don't have to run it manually.
> >
> > Set format.useAutobase to whenAble somewhere in your Git configs (global/local),
> > or use --base=auto to git-format-patch when you format your patches before
> > git-send-email-ing them.
> >
> > Repost your patches.
> >
> > The base commit will be added to the bottom of the cover letter. It should
> > be an ancestor (or tip) of drm-misc-next (git branch --contains <base> --list etc.).
> > If it is not, your base tree wasn't clean, and you should redo this process.
>
> Poking around I found out that this patch set is based off of drm-misc-fixes.
> Had the base been included, it would've made this easier.
I believe I based this off of drm-tip. Will follow the flow mentioned above in next rev.
Matt
> --
> Regards,
> Luben
>
next prev parent reply other threads:[~2023-10-16 15:14 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 23:58 [Intel-xe] [PATCH v5 0/7] DRM scheduler changes for Xe Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 1/7] drm/sched: Add drm_sched_wqueue_* helpers Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 1:24 ` [Intel-xe] " Luben Tuikov
2023-10-14 1:24 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 2/7] drm/sched: Convert drm scheduler to use a work queue rather than kthread Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 1:30 ` [Intel-xe] " Luben Tuikov
2023-10-14 1:30 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-12 0:39 ` [Intel-xe] " Luben Tuikov
2023-10-12 0:39 ` Luben Tuikov
2023-10-12 4:31 ` [Intel-xe] " Matthew Brost
2023-10-12 4:31 ` Matthew Brost
2023-10-12 5:54 ` [Intel-xe] " Luben Tuikov
2023-10-12 5:54 ` Luben Tuikov
2023-10-19 1:19 ` [Intel-xe] " Luben Tuikov
2023-10-19 1:19 ` Luben Tuikov
2023-10-13 17:45 ` [Intel-xe] " Luben Tuikov
2023-10-13 17:45 ` Luben Tuikov
2023-10-16 15:08 ` [Intel-xe] " Matthew Brost
2023-10-16 15:08 ` Matthew Brost
2023-10-16 15:23 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:23 ` Luben Tuikov
2023-10-14 1:40 ` [Intel-xe] " Luben Tuikov
2023-10-14 1:40 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 2:06 ` [Intel-xe] " Luben Tuikov
2023-10-14 2:06 ` Luben Tuikov
2023-10-16 15:00 ` [Intel-xe] " Matthew Brost
2023-10-16 15:00 ` Matthew Brost
2023-10-16 15:10 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:10 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 5/7] drm/sched: Split free_job into own work item Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 2:49 ` [Intel-xe] " Luben Tuikov
2023-10-14 2:49 ` Luben Tuikov
2023-10-15 0:09 ` [Intel-xe] " Luben Tuikov
2023-10-15 0:09 ` Luben Tuikov
2023-10-16 15:12 ` Matthew Brost [this message]
2023-10-16 15:12 ` Matthew Brost
2023-10-16 15:29 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:29 ` Luben Tuikov
2023-10-16 15:42 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:42 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 2:52 ` [Intel-xe] " Luben Tuikov
2023-10-14 2:52 ` Luben Tuikov
2023-10-16 14:57 ` [Intel-xe] " Matthew Brost
2023-10-16 14:57 ` Matthew Brost
2023-10-16 15:15 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:15 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 7/7] drm/sched: Add helper to queue TDR immediately for current and future jobs Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 3:04 ` [Intel-xe] " Luben Tuikov
2023-10-14 3:04 ` Luben Tuikov
2023-10-16 15:03 ` [Intel-xe] " Matthew Brost
2023-10-16 15:03 ` Matthew Brost
2023-10-12 2:02 ` [Intel-xe] [PATCH v5 0/7] DRM scheduler changes for Xe Danilo Krummrich
2023-10-12 2:02 ` Danilo Krummrich
2023-10-12 4:49 ` [Intel-xe] " Matthew Brost
2023-10-12 4:49 ` Matthew Brost
2023-10-12 4:24 ` [Intel-xe] ✗ CI.Patch_applied: failure for DRM scheduler changes for Xe (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS1SyZUvMLJFEEbB@DUT025-TGLU.fm.intel.com \
--to=matthew.brost@intel.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=frank.binns@imgtec.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=ketil.johnsen@arm.com \
--cc=lina@asahilina.net \
--cc=luben.tuikov@amd.com \
--cc=mcanal@igalia.com \
--cc=robdclark@chromium.org \
--cc=sarah.walker@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.