From: Luben Tuikov <luben.tuikov@amd.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: robdclark@chromium.org, sarah.walker@imgtec.com,
ketil.johnsen@arm.com, lina@asahilina.net, mcanal@igalia.com,
Liviu.Dudau@arm.com, dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, boris.brezillon@collabora.com,
dakr@redhat.com, donald.robson@imgtec.com,
christian.koenig@amd.com, faith.ekstrand@collabora.com
Subject: Re: [Intel-xe] [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper
Date: Mon, 16 Oct 2023 11:15:40 -0400 [thread overview]
Message-ID: <aa84df09-e380-4fc2-86cd-51f443a97f9c@amd.com> (raw)
In-Reply-To: <ZS1PTWsvr8DFNnLj@DUT025-TGLU.fm.intel.com>
On 2023-10-16 10:57, Matthew Brost wrote:
> On Fri, Oct 13, 2023 at 10:52:22PM -0400, Luben Tuikov wrote:
>> On 2023-10-11 19:58, Matthew Brost wrote:
>>> Also add a lockdep assert to drm_sched_start_timeout.
>>>
>>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>>> Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
>>
>> I don't remember sending a Reviewed-by email to this patch.
>>
>
> I believe you did send a RB:
> https://patchwork.freedesktop.org/patch/558222/?series=121745&rev=6
>
>> I'll add the R-V to the commit when I apply and push this patch,
>> after replying with a R-V email.
>>
>
> Is manually adding a RB ok if it is in the correct place like it is in this patch?
If you've received an R-B email and you're reposting the patch, you should
append the R-B tag at the bottom of the other tags, like a tool would do it.
--
Regards,
Luben
WARNING: multiple messages have this Message-ID (diff)
From: Luben Tuikov <luben.tuikov@amd.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: robdclark@chromium.org, thomas.hellstrom@linux.intel.com,
sarah.walker@imgtec.com, ketil.johnsen@arm.com,
lina@asahilina.net, mcanal@igalia.com, Liviu.Dudau@arm.com,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
boris.brezillon@collabora.com, dakr@redhat.com,
donald.robson@imgtec.com, christian.koenig@amd.com,
faith.ekstrand@collabora.com
Subject: Re: [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper
Date: Mon, 16 Oct 2023 11:15:40 -0400 [thread overview]
Message-ID: <aa84df09-e380-4fc2-86cd-51f443a97f9c@amd.com> (raw)
In-Reply-To: <ZS1PTWsvr8DFNnLj@DUT025-TGLU.fm.intel.com>
On 2023-10-16 10:57, Matthew Brost wrote:
> On Fri, Oct 13, 2023 at 10:52:22PM -0400, Luben Tuikov wrote:
>> On 2023-10-11 19:58, Matthew Brost wrote:
>>> Also add a lockdep assert to drm_sched_start_timeout.
>>>
>>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>>> Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
>>
>> I don't remember sending a Reviewed-by email to this patch.
>>
>
> I believe you did send a RB:
> https://patchwork.freedesktop.org/patch/558222/?series=121745&rev=6
>
>> I'll add the R-V to the commit when I apply and push this patch,
>> after replying with a R-V email.
>>
>
> Is manually adding a RB ok if it is in the correct place like it is in this patch?
If you've received an R-B email and you're reposting the patch, you should
append the R-B tag at the bottom of the other tags, like a tool would do it.
--
Regards,
Luben
next prev parent reply other threads:[~2023-10-16 15:15 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 23:58 [Intel-xe] [PATCH v5 0/7] DRM scheduler changes for Xe Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 1/7] drm/sched: Add drm_sched_wqueue_* helpers Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 1:24 ` [Intel-xe] " Luben Tuikov
2023-10-14 1:24 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 2/7] drm/sched: Convert drm scheduler to use a work queue rather than kthread Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 1:30 ` [Intel-xe] " Luben Tuikov
2023-10-14 1:30 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-12 0:39 ` [Intel-xe] " Luben Tuikov
2023-10-12 0:39 ` Luben Tuikov
2023-10-12 4:31 ` [Intel-xe] " Matthew Brost
2023-10-12 4:31 ` Matthew Brost
2023-10-12 5:54 ` [Intel-xe] " Luben Tuikov
2023-10-12 5:54 ` Luben Tuikov
2023-10-19 1:19 ` [Intel-xe] " Luben Tuikov
2023-10-19 1:19 ` Luben Tuikov
2023-10-13 17:45 ` [Intel-xe] " Luben Tuikov
2023-10-13 17:45 ` Luben Tuikov
2023-10-16 15:08 ` [Intel-xe] " Matthew Brost
2023-10-16 15:08 ` Matthew Brost
2023-10-16 15:23 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:23 ` Luben Tuikov
2023-10-14 1:40 ` [Intel-xe] " Luben Tuikov
2023-10-14 1:40 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 2:06 ` [Intel-xe] " Luben Tuikov
2023-10-14 2:06 ` Luben Tuikov
2023-10-16 15:00 ` [Intel-xe] " Matthew Brost
2023-10-16 15:00 ` Matthew Brost
2023-10-16 15:10 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:10 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 5/7] drm/sched: Split free_job into own work item Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 2:49 ` [Intel-xe] " Luben Tuikov
2023-10-14 2:49 ` Luben Tuikov
2023-10-15 0:09 ` [Intel-xe] " Luben Tuikov
2023-10-15 0:09 ` Luben Tuikov
2023-10-16 15:12 ` [Intel-xe] " Matthew Brost
2023-10-16 15:12 ` Matthew Brost
2023-10-16 15:29 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:29 ` Luben Tuikov
2023-10-16 15:42 ` [Intel-xe] " Luben Tuikov
2023-10-16 15:42 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 2:52 ` [Intel-xe] " Luben Tuikov
2023-10-14 2:52 ` Luben Tuikov
2023-10-16 14:57 ` [Intel-xe] " Matthew Brost
2023-10-16 14:57 ` Matthew Brost
2023-10-16 15:15 ` Luben Tuikov [this message]
2023-10-16 15:15 ` Luben Tuikov
2023-10-11 23:58 ` [Intel-xe] [PATCH v5 7/7] drm/sched: Add helper to queue TDR immediately for current and future jobs Matthew Brost
2023-10-11 23:58 ` Matthew Brost
2023-10-14 3:04 ` [Intel-xe] " Luben Tuikov
2023-10-14 3:04 ` Luben Tuikov
2023-10-16 15:03 ` [Intel-xe] " Matthew Brost
2023-10-16 15:03 ` Matthew Brost
2023-10-12 2:02 ` [Intel-xe] [PATCH v5 0/7] DRM scheduler changes for Xe Danilo Krummrich
2023-10-12 2:02 ` Danilo Krummrich
2023-10-12 4:49 ` [Intel-xe] " Matthew Brost
2023-10-12 4:49 ` Matthew Brost
2023-10-12 4:24 ` [Intel-xe] ✗ CI.Patch_applied: failure for DRM scheduler changes for Xe (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa84df09-e380-4fc2-86cd-51f443a97f9c@amd.com \
--to=luben.tuikov@amd.com \
--cc=Liviu.Dudau@arm.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=ketil.johnsen@arm.com \
--cc=lina@asahilina.net \
--cc=matthew.brost@intel.com \
--cc=mcanal@igalia.com \
--cc=robdclark@chromium.org \
--cc=sarah.walker@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.