From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Emma Anholt <emma@anholt.net>, Maxime Ripard <mripard@kernel.org>,
Eric Anholt <eric@anholt.net>,
Linux DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vc4: fix typo
Date: Mon, 23 Oct 2023 16:35:34 +0700 [thread overview]
Message-ID: <ZTY-ZqWxW5V-T680@debian.me> (raw)
In-Reply-To: <20231023085929.1445594-1-dario.binacchi@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Mon, Oct 23, 2023 at 10:59:20AM +0200, Dario Binacchi wrote:
> Replace 'pack' with 'back'.
>
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> index f3763bd600f6..8ac9515554f8 100644
> --- a/drivers/gpu/drm/vc4/vc4_regs.h
> +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> @@ -588,7 +588,7 @@ enum {
> # define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
> # define VC4_HDMI_HORZA_HAP_SHIFT 0
>
> -/* Horizontal pack porch (htotal - hsync_end). */
> +/* Horizontal back porch (htotal - hsync_end). */
> # define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
> # define VC4_HDMI_HORZB_HBP_SHIFT 20
> /* Horizontal sync pulse (hsync_end - hsync_start). */
The patch LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Emma Anholt <emma@anholt.net>, Eric Anholt <eric@anholt.net>,
Maxime Ripard <mripard@kernel.org>,
Linux DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vc4: fix typo
Date: Mon, 23 Oct 2023 16:35:34 +0700 [thread overview]
Message-ID: <ZTY-ZqWxW5V-T680@debian.me> (raw)
In-Reply-To: <20231023085929.1445594-1-dario.binacchi@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Mon, Oct 23, 2023 at 10:59:20AM +0200, Dario Binacchi wrote:
> Replace 'pack' with 'back'.
>
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> index f3763bd600f6..8ac9515554f8 100644
> --- a/drivers/gpu/drm/vc4/vc4_regs.h
> +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> @@ -588,7 +588,7 @@ enum {
> # define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
> # define VC4_HDMI_HORZA_HAP_SHIFT 0
>
> -/* Horizontal pack porch (htotal - hsync_end). */
> +/* Horizontal back porch (htotal - hsync_end). */
> # define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
> # define VC4_HDMI_HORZB_HBP_SHIFT 20
> /* Horizontal sync pulse (hsync_end - hsync_start). */
The patch LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-23 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:59 [PATCH] drm/vc4: fix typo Dario Binacchi
2023-10-23 8:59 ` Dario Binacchi
2023-10-23 9:35 ` Bagas Sanjaya [this message]
2023-10-23 9:35 ` Bagas Sanjaya
2023-10-23 10:57 ` Dave Stevenson
2023-10-23 10:57 ` Dave Stevenson
2023-10-23 14:26 ` (subset) " Maxime Ripard
2023-10-23 14:26 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTY-ZqWxW5V-T680@debian.me \
--to=bagasdotme@gmail.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.