* [PATCH] drm/vc4: fix typo
@ 2023-10-23 8:59 ` Dario Binacchi
0 siblings, 0 replies; 8+ messages in thread
From: Dario Binacchi @ 2023-10-23 8:59 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Daniel Vetter, David Airlie, Emma Anholt,
Eric Anholt, Maxime Ripard, dri-devel
Replace 'pack' with 'back'.
Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
index f3763bd600f6..8ac9515554f8 100644
--- a/drivers/gpu/drm/vc4/vc4_regs.h
+++ b/drivers/gpu/drm/vc4/vc4_regs.h
@@ -588,7 +588,7 @@ enum {
# define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
# define VC4_HDMI_HORZA_HAP_SHIFT 0
-/* Horizontal pack porch (htotal - hsync_end). */
+/* Horizontal back porch (htotal - hsync_end). */
# define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
# define VC4_HDMI_HORZB_HBP_SHIFT 20
/* Horizontal sync pulse (hsync_end - hsync_start). */
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/vc4: fix typo
2023-10-23 8:59 ` Dario Binacchi
@ 2023-10-23 9:35 ` Bagas Sanjaya
-1 siblings, 0 replies; 8+ messages in thread
From: Bagas Sanjaya @ 2023-10-23 9:35 UTC (permalink / raw)
To: Dario Binacchi, Linux Kernel Mailing List
Cc: Emma Anholt, Maxime Ripard, Eric Anholt, Linux DRI Development
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Mon, Oct 23, 2023 at 10:59:20AM +0200, Dario Binacchi wrote:
> Replace 'pack' with 'back'.
>
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> index f3763bd600f6..8ac9515554f8 100644
> --- a/drivers/gpu/drm/vc4/vc4_regs.h
> +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> @@ -588,7 +588,7 @@ enum {
> # define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
> # define VC4_HDMI_HORZA_HAP_SHIFT 0
>
> -/* Horizontal pack porch (htotal - hsync_end). */
> +/* Horizontal back porch (htotal - hsync_end). */
> # define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
> # define VC4_HDMI_HORZB_HBP_SHIFT 20
> /* Horizontal sync pulse (hsync_end - hsync_start). */
The patch LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/vc4: fix typo
@ 2023-10-23 9:35 ` Bagas Sanjaya
0 siblings, 0 replies; 8+ messages in thread
From: Bagas Sanjaya @ 2023-10-23 9:35 UTC (permalink / raw)
To: Dario Binacchi, Linux Kernel Mailing List
Cc: Daniel Vetter, David Airlie, Emma Anholt, Eric Anholt,
Maxime Ripard, Linux DRI Development
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Mon, Oct 23, 2023 at 10:59:20AM +0200, Dario Binacchi wrote:
> Replace 'pack' with 'back'.
>
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> index f3763bd600f6..8ac9515554f8 100644
> --- a/drivers/gpu/drm/vc4/vc4_regs.h
> +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> @@ -588,7 +588,7 @@ enum {
> # define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
> # define VC4_HDMI_HORZA_HAP_SHIFT 0
>
> -/* Horizontal pack porch (htotal - hsync_end). */
> +/* Horizontal back porch (htotal - hsync_end). */
> # define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
> # define VC4_HDMI_HORZB_HBP_SHIFT 20
> /* Horizontal sync pulse (hsync_end - hsync_start). */
The patch LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/vc4: fix typo
2023-10-23 8:59 ` Dario Binacchi
@ 2023-10-23 10:57 ` Dave Stevenson
-1 siblings, 0 replies; 8+ messages in thread
From: Dave Stevenson @ 2023-10-23 10:57 UTC (permalink / raw)
To: Dario Binacchi
Cc: Maxime Ripard, Eric Anholt, dri-devel, linux-kernel, Emma Anholt
Hi Dario
Thanks for the patch.
On Mon, 23 Oct 2023 at 09:59, Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> Replace 'pack' with 'back'.
>
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>
> drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> index f3763bd600f6..8ac9515554f8 100644
> --- a/drivers/gpu/drm/vc4/vc4_regs.h
> +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> @@ -588,7 +588,7 @@ enum {
> # define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
> # define VC4_HDMI_HORZA_HAP_SHIFT 0
>
> -/* Horizontal pack porch (htotal - hsync_end). */
> +/* Horizontal back porch (htotal - hsync_end). */
> # define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
> # define VC4_HDMI_HORZB_HBP_SHIFT 20
> /* Horizontal sync pulse (hsync_end - hsync_start). */
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/vc4: fix typo
@ 2023-10-23 10:57 ` Dave Stevenson
0 siblings, 0 replies; 8+ messages in thread
From: Dave Stevenson @ 2023-10-23 10:57 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, Emma Anholt, Maxime Ripard, Eric Anholt, dri-devel
Hi Dario
Thanks for the patch.
On Mon, 23 Oct 2023 at 09:59, Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> Replace 'pack' with 'back'.
>
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>
> drivers/gpu/drm/vc4/vc4_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> index f3763bd600f6..8ac9515554f8 100644
> --- a/drivers/gpu/drm/vc4/vc4_regs.h
> +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> @@ -588,7 +588,7 @@ enum {
> # define VC4_HDMI_HORZA_HAP_MASK VC4_MASK(12, 0)
> # define VC4_HDMI_HORZA_HAP_SHIFT 0
>
> -/* Horizontal pack porch (htotal - hsync_end). */
> +/* Horizontal back porch (htotal - hsync_end). */
> # define VC4_HDMI_HORZB_HBP_MASK VC4_MASK(29, 20)
> # define VC4_HDMI_HORZB_HBP_SHIFT 20
> /* Horizontal sync pulse (hsync_end - hsync_start). */
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH] drm/vc4: fix typo
2023-10-23 8:59 ` Dario Binacchi
@ 2023-10-23 14:26 ` Maxime Ripard
-1 siblings, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2023-10-23 14:26 UTC (permalink / raw)
To: linux-kernel, Dario Binacchi; +Cc: Eric Anholt, dri-devel, Emma Anholt
On Mon, 23 Oct 2023 10:59:20 +0200, Dario Binacchi wrote:
> Replace 'pack' with 'back'.
>
>
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 8+ messages in thread