* [PATCH Resend] Fix line Length
@ 2023-10-29 14:43 Dorine Tipo
2023-10-29 15:11 ` Julia Lawall
0 siblings, 1 reply; 12+ messages in thread
From: Dorine Tipo @ 2023-10-29 14:43 UTC (permalink / raw)
To: outreachy, bagasdotme, julia.lawall; +Cc: Dorine Tipo
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
Fix the line lengths of lines 8 and 49
---
drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
index 2bb759165063..d7b779bb7f64 100755
--- a/drivers/gpu/drm/ci/igt_runner.sh
+++ b/drivers/gpu/drm/ci/igt_runner.sh
@@ -5,7 +5,8 @@ set -ex
export IGT_FORCE_DRIVER=${DRIVER_NAME}
export PATH=$PATH:/igt/bin/
-export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
+export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
+export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
# Uncomment the below to debug problems with driver probing
: '
@@ -46,7 +47,8 @@ else
ARCH="x86_64"
fi
-curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
+curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
+ ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
set +e
igt-runner \
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
2023-10-29 14:43 [PATCH Resend] Fix line Length Dorine Tipo
@ 2023-10-29 15:11 ` Julia Lawall
2023-10-29 23:50 ` Bagas Sanjaya
0 siblings, 1 reply; 12+ messages in thread
From: Julia Lawall @ 2023-10-29 15:11 UTC (permalink / raw)
To: Dorine Tipo; +Cc: outreachy, bagasdotme, julia.lawall
On Sun, 29 Oct 2023, Dorine Tipo wrote:
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
>
> Fix the line lengths of lines 8 and 49
The Signed off by line should be here, below the log message. Please see
the patches sent by others.
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 2bb759165063..d7b779bb7f64 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -5,7 +5,8 @@ set -ex
>
> export IGT_FORCE_DRIVER=${DRIVER_NAME}
> export PATH=$PATH:/igt/bin/
> -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
There was a suggestion that it was better to keep this as one line.
julia
> # Uncomment the below to debug problems with driver probing
> : '
> @@ -46,7 +47,8 @@ else
> ARCH="x86_64"
> fi
>
> -curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
> +curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
> + ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
>
> set +e
> igt-runner \
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
2023-10-29 15:11 ` Julia Lawall
@ 2023-10-29 23:50 ` Bagas Sanjaya
0 siblings, 0 replies; 12+ messages in thread
From: Bagas Sanjaya @ 2023-10-29 23:50 UTC (permalink / raw)
To: Julia Lawall, Dorine Tipo, Greg KH, Tomeu Vizoso, Helen Koike,
David Airlie, Daniel Vetter, Nick Terrell, Daniel Stone,
Rob Clark
Cc: Linux Outreachy, Linux DRI Development, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
>
>
> On Sun, 29 Oct 2023, Dorine Tipo wrote:
>
> > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> >
> > Fix the line lengths of lines 8 and 49
>
> The Signed off by line should be here, below the log message. Please see
> the patches sent by others.
>
> > export IGT_FORCE_DRIVER=${DRIVER_NAME}
> > export PATH=$PATH:/igt/bin/
> > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
>
> There was a suggestion that it was better to keep this as one line.
>
Hi Julia,
The submitter touched one of CI scripts for the DRM subsystem. To test
this patch, there must be a way to run these scripts locally (which
may requires non-trivial setup).
Cc'ed DRM maintainers.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
@ 2023-10-29 23:50 ` Bagas Sanjaya
0 siblings, 0 replies; 12+ messages in thread
From: Bagas Sanjaya @ 2023-10-29 23:50 UTC (permalink / raw)
To: Julia Lawall, Dorine Tipo, Greg KH, Tomeu Vizoso, Helen Koike,
David Airlie, Daniel Vetter, Nick Terrell, Daniel Stone,
Rob Clark
Cc: Linux Kernel Mailing List, Linux DRI Development, Linux Outreachy
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
>
>
> On Sun, 29 Oct 2023, Dorine Tipo wrote:
>
> > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> >
> > Fix the line lengths of lines 8 and 49
>
> The Signed off by line should be here, below the log message. Please see
> the patches sent by others.
>
> > export IGT_FORCE_DRIVER=${DRIVER_NAME}
> > export PATH=$PATH:/igt/bin/
> > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
>
> There was a suggestion that it was better to keep this as one line.
>
Hi Julia,
The submitter touched one of CI scripts for the DRM subsystem. To test
this patch, there must be a way to run these scripts locally (which
may requires non-trivial setup).
Cc'ed DRM maintainers.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
2023-10-29 23:50 ` Bagas Sanjaya
@ 2023-10-30 6:12 ` Julia Lawall
-1 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2023-10-30 6:12 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Julia Lawall, Dorine Tipo, Greg KH, Tomeu Vizoso, Helen Koike,
David Airlie, Daniel Vetter, Nick Terrell, Daniel Stone,
Rob Clark, Linux Outreachy, Linux DRI Development,
Linux Kernel Mailing List
On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
> On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
> >
> >
> > On Sun, 29 Oct 2023, Dorine Tipo wrote:
> >
> > > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> > >
> > > Fix the line lengths of lines 8 and 49
> >
> > The Signed off by line should be here, below the log message. Please see
> > the patches sent by others.
> >
> > > export IGT_FORCE_DRIVER=${DRIVER_NAME}
> > > export PATH=$PATH:/igt/bin/
> > > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
> >
> > There was a suggestion that it was better to keep this as one line.
> >
>
> Hi Julia,
>
> The submitter touched one of CI scripts for the DRM subsystem. To test
> this patch, there must be a way to run these scripts locally (which
> may requires non-trivial setup).
>
> Cc'ed DRM maintainers.
There is a DRM outreachy project. I think that motivated this patch.
julia
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
@ 2023-10-30 6:12 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2023-10-30 6:12 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Daniel Stone, Tomeu Vizoso, Linux Outreachy, Greg KH,
Nick Terrell, Linux DRI Development, Linux Kernel Mailing List,
Julia Lawall, Helen Koike, Dorine Tipo
On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
> On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
> >
> >
> > On Sun, 29 Oct 2023, Dorine Tipo wrote:
> >
> > > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> > >
> > > Fix the line lengths of lines 8 and 49
> >
> > The Signed off by line should be here, below the log message. Please see
> > the patches sent by others.
> >
> > > export IGT_FORCE_DRIVER=${DRIVER_NAME}
> > > export PATH=$PATH:/igt/bin/
> > > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
> >
> > There was a suggestion that it was better to keep this as one line.
> >
>
> Hi Julia,
>
> The submitter touched one of CI scripts for the DRM subsystem. To test
> this patch, there must be a way to run these scripts locally (which
> may requires non-trivial setup).
>
> Cc'ed DRM maintainers.
There is a DRM outreachy project. I think that motivated this patch.
julia
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
2023-10-30 6:12 ` Julia Lawall
@ 2023-10-30 11:36 ` Bagas Sanjaya
-1 siblings, 0 replies; 12+ messages in thread
From: Bagas Sanjaya @ 2023-10-30 11:36 UTC (permalink / raw)
To: Julia Lawall
Cc: Dorine Tipo, Greg KH, Tomeu Vizoso, Helen Koike, David Airlie,
Daniel Vetter, Nick Terrell, Daniel Stone, Rob Clark,
Linux Outreachy, Linux DRI Development, Linux Kernel Mailing List
On 30/10/2023 13:12, Julia Lawall wrote:
>
>
> On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
>
>> Hi Julia,
>>
>> The submitter touched one of CI scripts for the DRM subsystem. To test
>> this patch, there must be a way to run these scripts locally (which
>> may requires non-trivial setup).
>>
>> Cc'ed DRM maintainers.
>
> There is a DRM outreachy project. I think that motivated this patch.
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
@ 2023-10-30 11:36 ` Bagas Sanjaya
0 siblings, 0 replies; 12+ messages in thread
From: Bagas Sanjaya @ 2023-10-30 11:36 UTC (permalink / raw)
To: Julia Lawall
Cc: Daniel Stone, Tomeu Vizoso, Linux Outreachy, Greg KH,
Nick Terrell, Linux DRI Development, Linux Kernel Mailing List,
Helen Koike, Dorine Tipo
On 30/10/2023 13:12, Julia Lawall wrote:
>
>
> On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
>
>> Hi Julia,
>>
>> The submitter touched one of CI scripts for the DRM subsystem. To test
>> this patch, there must be a way to run these scripts locally (which
>> may requires non-trivial setup).
>>
>> Cc'ed DRM maintainers.
>
> There is a DRM outreachy project. I think that motivated this patch.
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
2023-10-30 11:36 ` Bagas Sanjaya
@ 2023-10-31 18:36 ` Helen Koike
-1 siblings, 0 replies; 12+ messages in thread
From: Helen Koike @ 2023-10-31 18:36 UTC (permalink / raw)
To: Bagas Sanjaya, Julia Lawall
Cc: Daniel Stone, Linux Outreachy, Greg KH, Nick Terrell,
Linux DRI Development, Linux Kernel Mailing List, Dorine Tipo
On 30/10/2023 08:36, Bagas Sanjaya wrote:
> On 30/10/2023 13:12, Julia Lawall wrote:
>>
>>
>> On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
>>
>>> Hi Julia,
>>>
>>> The submitter touched one of CI scripts for the DRM subsystem. To test
>>> this patch, there must be a way to run these scripts locally (which
>>> may requires non-trivial setup).
Instructions to test it is on the docs:
https://docs.kernel.org/gpu/automated_testing.html?highlight=drm+ci#how-to-enable-automated-testing-on-your-tree
>>>
>>> Cc'ed DRM maintainers.
>>
>> There is a DRM outreachy project. I think that motivated this patch.
Yes :)
>>
>
> OK, thanks!
>
Thanks
Helen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
@ 2023-10-31 18:36 ` Helen Koike
0 siblings, 0 replies; 12+ messages in thread
From: Helen Koike @ 2023-10-31 18:36 UTC (permalink / raw)
To: Bagas Sanjaya, Julia Lawall
Cc: Daniel Stone, Linux Outreachy, Greg KH, Linux Kernel Mailing List,
Linux DRI Development, Nick Terrell, Dorine Tipo
On 30/10/2023 08:36, Bagas Sanjaya wrote:
> On 30/10/2023 13:12, Julia Lawall wrote:
>>
>>
>> On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
>>
>>> Hi Julia,
>>>
>>> The submitter touched one of CI scripts for the DRM subsystem. To test
>>> this patch, there must be a way to run these scripts locally (which
>>> may requires non-trivial setup).
Instructions to test it is on the docs:
https://docs.kernel.org/gpu/automated_testing.html?highlight=drm+ci#how-to-enable-automated-testing-on-your-tree
>>>
>>> Cc'ed DRM maintainers.
>>
>> There is a DRM outreachy project. I think that motivated this patch.
Yes :)
>>
>
> OK, thanks!
>
Thanks
Helen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
2023-10-31 18:36 ` Helen Koike
@ 2023-11-01 2:10 ` Bagas Sanjaya
-1 siblings, 0 replies; 12+ messages in thread
From: Bagas Sanjaya @ 2023-11-01 2:10 UTC (permalink / raw)
To: Helen Koike, Julia Lawall
Cc: Daniel Stone, Linux Outreachy, Greg KH, Nick Terrell,
Linux DRI Development, Linux Kernel Mailing List, Dorine Tipo
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Tue, Oct 31, 2023 at 03:36:30PM -0300, Helen Koike wrote:
>
>
> On 30/10/2023 08:36, Bagas Sanjaya wrote:
> > On 30/10/2023 13:12, Julia Lawall wrote:
> > >
> > >
> > > On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
> > >
> > > > Hi Julia,
> > > >
> > > > The submitter touched one of CI scripts for the DRM subsystem. To test
> > > > this patch, there must be a way to run these scripts locally (which
> > > > may requires non-trivial setup).
>
> Instructions to test it is on the docs:
>
> https://docs.kernel.org/gpu/automated_testing.html?highlight=drm+ci#how-to-enable-automated-testing-on-your-tree
Thanks for the pointer!
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH Resend] Fix line Length
@ 2023-11-01 2:10 ` Bagas Sanjaya
0 siblings, 0 replies; 12+ messages in thread
From: Bagas Sanjaya @ 2023-11-01 2:10 UTC (permalink / raw)
To: Helen Koike, Julia Lawall
Cc: Daniel Stone, Linux Outreachy, Greg KH, Linux Kernel Mailing List,
Linux DRI Development, Nick Terrell, Dorine Tipo
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Tue, Oct 31, 2023 at 03:36:30PM -0300, Helen Koike wrote:
>
>
> On 30/10/2023 08:36, Bagas Sanjaya wrote:
> > On 30/10/2023 13:12, Julia Lawall wrote:
> > >
> > >
> > > On Mon, 30 Oct 2023, Bagas Sanjaya wrote:
> > >
> > > > Hi Julia,
> > > >
> > > > The submitter touched one of CI scripts for the DRM subsystem. To test
> > > > this patch, there must be a way to run these scripts locally (which
> > > > may requires non-trivial setup).
>
> Instructions to test it is on the docs:
>
> https://docs.kernel.org/gpu/automated_testing.html?highlight=drm+ci#how-to-enable-automated-testing-on-your-tree
Thanks for the pointer!
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-11-01 2:11 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-29 14:43 [PATCH Resend] Fix line Length Dorine Tipo
2023-10-29 15:11 ` Julia Lawall
2023-10-29 23:50 ` Bagas Sanjaya
2023-10-29 23:50 ` Bagas Sanjaya
2023-10-30 6:12 ` Julia Lawall
2023-10-30 6:12 ` Julia Lawall
2023-10-30 11:36 ` Bagas Sanjaya
2023-10-30 11:36 ` Bagas Sanjaya
2023-10-31 18:36 ` Helen Koike
2023-10-31 18:36 ` Helen Koike
2023-11-01 2:10 ` Bagas Sanjaya
2023-11-01 2:10 ` Bagas Sanjaya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.