[Intel-xe] [PATCH v2] drm/xe: clear the serviced bits on INTR_IDENTITY_REG

[Intel-xe] [PATCH v2] drm/xe: clear the serviced bits on INTR_IDENTITY_REG

[Jonathan Cavitt]

The spec for this register, like many other interrupt related ones,
asks software to write back '1' to clear the serviced bits. Let's
respect the spec.

v2:
- Update commit message
- Add missing CC

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Daniele Spurio Ceraolo <daniele.ceraolospurio@intel.com>
CC: Lucas De Marchi <lucas.demarchi@intel.com>
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
CC: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/xe/xe_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 61350ed32c61a..af3765c3fc0e2 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
 		return 0;
 	}
 
-	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
+	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
 
 	return ident;
 }
-- 
2.25.1

[Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)
URL   : https://patchwork.freedesktop.org/series/125971/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: bfa43da8e drm/xe: implement driver initiated function-reset
=== git am output follows ===
Applying: drm/xe: clear the serviced bits on INTR_IDENTITY_REG

Re: [Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)

[Rodrigo Vivi]

On Fri, Nov 03, 2023 at 08:07:34PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/xe: clear the serviced bits on INTR_IDENTITY_REG (rev2)
> URL   : https://patchwork.freedesktop.org/series/125971/
> State : failure
> 
> == Summary ==
> 
> === Applying kernel patches on branch 'drm-xe-next' with base: ===
> Base commit: bfa43da8e drm/xe: implement driver initiated function-reset
> === git am output follows ===
> Applying: drm/xe: clear the serviced bits on INTR_IDENTITY_REG

Please rebase it, but feel free to keep the rv-b.

> 
> 

Re: [Intel-xe] [PATCH v2] drm/xe: clear the serviced bits on INTR_IDENTITY_REG

[Rodrigo Vivi]

On Fri, Nov 03, 2023 at 12:53:38PM -0700, Jonathan Cavitt wrote:
> The spec for this register, like many other interrupt related ones,
> asks software to write back '1' to clear the serviced bits. Let's
> respect the spec.
> 
> v2:
> - Update commit message
> - Add missing CC
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> CC: Daniele Spurio Ceraolo <daniele.ceraolospurio@intel.com>
> CC: Lucas De Marchi <lucas.demarchi@intel.com>
> CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
> CC: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 61350ed32c61a..af3765c3fc0e2 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -232,7 +232,7 @@ gt_engine_identity(struct xe_device *xe,
>  		return 0;
>  	}
>  
> -	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
> +	xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);
>  
>  	return ident;
>  }
> -- 
> 2.25.1
>