Re: [PATCH v5 00/12] KVM: arm64: Support FEAT_LPA2 at hyp s1 and vm s2

From: Oliver Upton <oliver.upton@linux.dev>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	James Morse <james.morse@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v5 00/12] KVM: arm64: Support FEAT_LPA2 at hyp s1 and vm s2
Date: Tue, 21 Nov 2023 23:38:09 +0000	[thread overview]
Message-ID: <ZV0_YSm07-5SXdcz@linux.dev> (raw)
In-Reply-To: <20231116142931.1675485-1-ryan.roberts@arm.com>

Hi Ryan,

On Thu, Nov 16, 2023 at 02:29:19PM +0000, Ryan Roberts wrote:
> Additionally, when running page_fault_test, when run on FVP against v6.7-rc1 and
> newer, I'm seeing RCU stalls. I'm confident that this is not an issue introduced
> by this series because it reproduces without my patches.

Oh, that's interesting. Can you gather any additional details, like what
test case in page_fault_test trips the RCU stalls?

> Anshuman Khandual (1):
>   arm64/mm: Add FEAT_LPA2 specific ID_AA64MMFR0.TGRAN[2]
> 
> Ryan Roberts (11):
>   arm64/mm: Modify range-based tlbi to decrement scale
>   arm64/mm: Add lpa2_is_enabled() kvm_lpa2_is_enabled() stubs
>   arm64/mm: Update tlb invalidation routines for FEAT_LPA2
>   arm64: Add ARM64_HAS_LPA2 CPU capability
>   KVM: arm64: Add new (V)TCR_EL2 field definitions for FEAT_LPA2
>   KVM: arm64: Use LPA2 page-tables for stage2 and hyp stage1
>   KVM: arm64: Convert translation level parameter to s8
>   KVM: arm64: Support up to 5 levels of translation in kvm_pgtable
>   KVM: arm64: Allow guests with >48-bit IPA size on FEAT_LPA2 systems
>   KVM: selftests: arm64: Determine max ipa size per-page size
>   KVM: selftests: arm64: Support P52V48 4K and 16K guest_modes

Besides the nitpicks I left on the series, LGTM.

Reviewed-by: Oliver Upton <oliver.upton@linux.dev>

-- 
Thanks,
Oliver