From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: maarten.lankhorst@linux.intel.com, Takashi Iwai <tiwai@suse.de>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
alsa-devel@alsa-project.org, "Saarinen,
Jani" <jani.saarinen@intel.com>,
"Kurmi, Suresh Kumar" <suresh.kumar.kurmi@intel.com>
Subject: Re: [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.
Date: Tue, 14 Nov 2023 15:39:57 +0200 [thread overview]
Message-ID: <ZVN4rQjLxROOjTE-@intel.com> (raw)
In-Reply-To: <87bkbwsebl.fsf@intel.com>
On Tue, Nov 14, 2023 at 02:35:10PM +0200, Jani Nikula wrote:
> On Tue, 14 Nov 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Oct 02, 2023 at 09:38:44PM +0200, maarten.lankhorst@linux.intel.com wrote:
> >> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >>
> >> Now that we can use -EPROBE_DEFER, it's no longer required to spin off
> >> the snd_hdac_i915_init into a workqueue.
> >>
> >> Use the -EPROBE_DEFER mechanism instead, which must be returned in the
> >> probe function.
> >
> > This completely broke i915 audio!
> >
> > I also can't see any trace of this stuff ever being posted to
> > intel-gfx so it never went through the CI.
> >
> > Please fix or revert ASAP.
>
> Cc: Jani, Suresh
>
> Ville, please file a bug at gitlab so we can track this, thanks.
https://gitlab.freedesktop.org/drm/intel/-/issues/9671
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
intel-gfx@lists.freedesktop.org, "Kurmi,
Suresh Kumar" <suresh.kumar.kurmi@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.
Date: Tue, 14 Nov 2023 15:39:57 +0200 [thread overview]
Message-ID: <ZVN4rQjLxROOjTE-@intel.com> (raw)
In-Reply-To: <87bkbwsebl.fsf@intel.com>
On Tue, Nov 14, 2023 at 02:35:10PM +0200, Jani Nikula wrote:
> On Tue, 14 Nov 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Oct 02, 2023 at 09:38:44PM +0200, maarten.lankhorst@linux.intel.com wrote:
> >> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >>
> >> Now that we can use -EPROBE_DEFER, it's no longer required to spin off
> >> the snd_hdac_i915_init into a workqueue.
> >>
> >> Use the -EPROBE_DEFER mechanism instead, which must be returned in the
> >> probe function.
> >
> > This completely broke i915 audio!
> >
> > I also can't see any trace of this stuff ever being posted to
> > intel-gfx so it never went through the CI.
> >
> > Please fix or revert ASAP.
>
> Cc: Jani, Suresh
>
> Ville, please file a bug at gitlab so we can track this, thanks.
https://gitlab.freedesktop.org/drm/intel/-/issues/9671
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.
Date: Tue, 14 Nov 2023 15:39:57 +0200 [thread overview]
Message-ID: <ZVN4rQjLxROOjTE-@intel.com> (raw)
In-Reply-To: <87bkbwsebl.fsf@intel.com>
On Tue, Nov 14, 2023 at 02:35:10PM +0200, Jani Nikula wrote:
> On Tue, 14 Nov 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Oct 02, 2023 at 09:38:44PM +0200, maarten.lankhorst@linux.intel.com wrote:
> >> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >>
> >> Now that we can use -EPROBE_DEFER, it's no longer required to spin off
> >> the snd_hdac_i915_init into a workqueue.
> >>
> >> Use the -EPROBE_DEFER mechanism instead, which must be returned in the
> >> probe function.
> >
> > This completely broke i915 audio!
> >
> > I also can't see any trace of this stuff ever being posted to
> > intel-gfx so it never went through the CI.
> >
> > Please fix or revert ASAP.
>
> Cc: Jani, Suresh
>
> Ville, please file a bug at gitlab so we can track this, thanks.
https://gitlab.freedesktop.org/drm/intel/-/issues/9671
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-11-14 13:41 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 19:38 [Intel-xe] [PATCH 01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 02/14] Revert "sound/hda: Allow XE as i915 replacement for sound" maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 03/14] ASoC/SOF/core: Ensure sof_ops_free() is still called when probe never ran maarten.lankhorst
2023-10-03 7:58 ` Jani Nikula
2023-10-02 19:38 ` [Intel-xe] [PATCH 04/14] ASoC: SOF: core: Add probe_early and remove_late callbacks maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 05/14] ASoC: SOF: Intel: hda: start splitting the probe maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 06/14] ALSA: hda/intel: Fix error handling in azx_probe() maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 07/14] ALSA: hda/i915: Allow override of gpu binding maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 08/14] ALSA: hda/i915: Add an allow_modprobe argument to snd_hdac_i915_init maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 09/14] ALSA: hda/i915: Allow xe as match for i915_component_master_match maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 10/14] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 11/14] ALSA: hda/intel: " maarten.lankhorst
2023-11-14 11:06 ` Ville Syrjälä
2023-11-14 11:06 ` Ville Syrjälä
2023-11-14 11:06 ` [Intel-gfx] " Ville Syrjälä
2023-11-14 12:35 ` Jani Nikula
2023-11-14 12:35 ` Jani Nikula
2023-11-14 12:35 ` [Intel-gfx] " Jani Nikula
2023-11-14 13:29 ` Maarten Lankhorst
2023-11-14 13:29 ` Maarten Lankhorst
2023-11-14 13:29 ` [Intel-gfx] " Maarten Lankhorst
2023-11-14 13:31 ` Saarinen, Jani
2023-11-14 13:31 ` Saarinen, Jani
2023-11-14 13:31 ` [Intel-gfx] " Saarinen, Jani
2023-11-14 16:52 ` Takashi Iwai
2023-11-14 16:52 ` Takashi Iwai
2023-11-14 16:52 ` [Intel-gfx] " Takashi Iwai
2023-11-14 17:24 ` Jani Nikula
2023-11-14 17:24 ` Jani Nikula
2023-11-14 17:24 ` [Intel-gfx] " Jani Nikula
2023-11-15 8:15 ` Kai Vehmanen
2023-11-15 8:15 ` Kai Vehmanen
2023-11-15 8:15 ` [Intel-gfx] " Kai Vehmanen
2023-11-14 13:39 ` Ville Syrjälä [this message]
2023-11-14 13:39 ` Ville Syrjälä
2023-11-14 13:39 ` [Intel-gfx] " Ville Syrjälä
2023-11-14 14:39 ` Maarten Lankhorst
2023-11-14 14:39 ` Maarten Lankhorst
2023-11-14 14:39 ` [Intel-gfx] " Maarten Lankhorst
2023-11-14 15:50 ` Takashi Iwai
2023-11-14 15:50 ` Takashi Iwai
2023-11-14 15:50 ` [Intel-gfx] " Takashi Iwai
2023-11-14 15:52 ` Maarten Lankhorst
2023-11-14 15:52 ` Maarten Lankhorst
2023-11-14 15:52 ` [Intel-gfx] " Maarten Lankhorst
2023-11-14 15:09 ` Takashi Iwai
2023-11-14 15:09 ` Takashi Iwai
2023-11-14 15:09 ` [Intel-gfx] " Takashi Iwai
2023-10-02 19:38 ` [Intel-xe] [PATCH 12/14] ASoC: Intel: Skylake: " maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 13/14] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe maarten.lankhorst
2023-10-02 19:38 ` [Intel-xe] [PATCH 14/14] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init maarten.lankhorst
2023-10-02 20:28 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" Patchwork
2023-10-03 10:50 ` [Intel-xe] ✓ CI.Patch_applied: success " Patchwork
2023-10-03 10:50 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-03 10:51 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-03 10:58 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-03 10:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-03 11:00 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-10-03 11:37 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-11-14 16:30 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" (rev3) Patchwork
2023-11-15 23:27 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [01/14] Revert "sound/soc/sof: Remove deferred probe for SOF" (rev4) Patchwork
2023-11-17 21:33 ` Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-10-03 12:00 [Intel-xe] [PATCH 00/14] Update sound patches to upstreamable versions maarten.lankhorst
2023-10-03 12:00 ` [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work maarten.lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVN4rQjLxROOjTE-@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jani.saarinen@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=suresh.kumar.kurmi@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.