All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-xe] [PATCH v3 00/20] drm/xe: Probe tweaks and reordering
@ 2023-11-14 13:02 Michał Winiarski
  2023-11-14 13:02 ` [Intel-xe] [PATCH v3 01/20] drm/xe: Skip calling drm_dev_put on probe error Michał Winiarski
                   ` (26 more replies)
  0 siblings, 27 replies; 56+ messages in thread
From: Michał Winiarski @ 2023-11-14 13:02 UTC (permalink / raw)
  To: intel-xe; +Cc: Matt Roper, Lucas De Marchi, Michał Winiarski

When Xe is loaded on SR-IOV VF, it won't be able to get most of the
information about the hardware directly from registers (it's necessary
to communicate with GuC in order to get the data, as VF doesn't have the
same level of MMIO surface as native device).
In order to keep the probe relatively uniform between native and VF
mode, it's necessary to slightly reorder the current driver init.

The series starts with generic tweaks (dead code removal and devres
usage), followed by initial reordering focused around MMIO init and info
init, followed by GGTT / GuC reordering.

v1 -> v2:
- Add GGTT / GuC reordering
- Don't reorder VRAM init check, as the value also hints at pcode status
  (Matt Roper)
- Add comments to "early" functions introduced as part of the series
  (Lucas)
- Move xe_info_init_early usage in kunit to correct patch (Matt Brost)
- Drop "shutdown" dead code removal
- Make "xe_tile_alloc" static

v2 -> v3:
- Fix warn with W=1 - xe_pci_clear_master should be static (CI)

Michał Winiarski (20):
  drm/xe: Skip calling drm_dev_put on probe error
  drm/xe: Use managed pci_enable_device
  drm/xe/irq: Don't call pci_free_irq_vectors
  drm/xe: Move xe_set_dma_info outside of MMIO setup
  drm/xe: Move xe_mmio_probe_tiles outside of MMIO setup
  drm/xe: Split xe_info_init
  drm/xe: Introduce xe_tile_init_early and use at earlier point in probe
  drm/xe: Map the entire BAR0 and hold onto the initial mapping
  drm/xe/device: Introduce xe_device_probe_early
  drm/xe: Don't "peek" into GMD_ID
  drm/xe: Move system memory management init to earlier point in probe
  drm/xe: Move force_wake init to earlier point in probe
  drm/xe: Reorder GGTT init to earlier point in probe
  drm/xe/uc: Split xe_uc_fw_init
  drm/xe/uc: Store firmware binary in system-memory backed BO
  drm/xe/uc: Extract xe_uc_sanitize_reset
  drm/xe/guc: Split GuC params used for "hwconfig" and "post-hwconfig"
  drm/xe/guc: Allocate GuC data structures in system memory for initial
    load
  drm/xe/guc: Move GuC power control init to "post-hwconfig"
  drm/xe: Initialize GuC earlier during probe

 drivers/gpu/drm/xe/regs/xe_gt_regs.h |   1 +
 drivers/gpu/drm/xe/tests/xe_pci.c    |   1 +
 drivers/gpu/drm/xe/xe_device.c       |  81 ++++++++++++++---
 drivers/gpu/drm/xe/xe_device.h       |   5 +
 drivers/gpu/drm/xe/xe_ggtt.c         |  20 +++-
 drivers/gpu/drm/xe/xe_ggtt.h         |   2 +-
 drivers/gpu/drm/xe/xe_gt.c           |  25 ++---
 drivers/gpu/drm/xe/xe_guc.c          | 107 +++++++++++++++++++---
 drivers/gpu/drm/xe/xe_guc_ads.c      |   2 +-
 drivers/gpu/drm/xe/xe_guc_ct.c       |   2 +-
 drivers/gpu/drm/xe/xe_guc_log.c      |   2 +-
 drivers/gpu/drm/xe/xe_irq.c          |   5 +-
 drivers/gpu/drm/xe/xe_mmio.c         |  58 +++---------
 drivers/gpu/drm/xe/xe_mmio.h         |   2 +
 drivers/gpu/drm/xe/xe_pci.c          | 131 +++++++++++++++------------
 drivers/gpu/drm/xe/xe_tile.c         |  36 +++++++-
 drivers/gpu/drm/xe/xe_tile.h         |   2 +-
 drivers/gpu/drm/xe/xe_uc.c           |  49 +++++++---
 drivers/gpu/drm/xe/xe_uc.h           |   2 +-
 drivers/gpu/drm/xe/xe_uc_fw.c        |  80 ++++++++++++----
 20 files changed, 420 insertions(+), 193 deletions(-)

-- 
2.42.1


^ permalink raw reply	[flat|nested] 56+ messages in thread

end of thread, other threads:[~2023-11-21 16:54 UTC | newest]

Thread overview: 56+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-14 13:02 [Intel-xe] [PATCH v3 00/20] drm/xe: Probe tweaks and reordering Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 01/20] drm/xe: Skip calling drm_dev_put on probe error Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 02/20] drm/xe: Use managed pci_enable_device Michał Winiarski
2023-11-15 20:47   ` Matt Roper
2023-11-21 12:45     ` Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 03/20] drm/xe/irq: Don't call pci_free_irq_vectors Michał Winiarski
2023-11-15 20:49   ` Matt Roper
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 04/20] drm/xe: Move xe_set_dma_info outside of MMIO setup Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 05/20] drm/xe: Move xe_mmio_probe_tiles " Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 06/20] drm/xe: Split xe_info_init Michał Winiarski
2023-11-20 19:47   ` Lucas De Marchi
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 07/20] drm/xe: Introduce xe_tile_init_early and use at earlier point in probe Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 08/20] drm/xe: Map the entire BAR0 and hold onto the initial mapping Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 09/20] drm/xe/device: Introduce xe_device_probe_early Michał Winiarski
2023-11-15 14:41   ` Matthew Brost
2023-11-15 21:31   ` Matt Roper
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 10/20] drm/xe: Don't "peek" into GMD_ID Michał Winiarski
2023-11-15 14:45   ` Matthew Brost
2023-11-15 21:51   ` Matt Roper
2023-11-20 19:57     ` Lucas De Marchi
2023-11-21 13:27       ` Michał Winiarski
2023-11-21 16:54         ` Lucas De Marchi
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 11/20] drm/xe: Move system memory management init to earlier point in probe Michał Winiarski
2023-11-15 21:55   ` Matt Roper
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 12/20] drm/xe: Move force_wake " Michał Winiarski
2023-11-15 21:59   ` Matt Roper
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 13/20] drm/xe: Reorder GGTT " Michał Winiarski
2023-11-15 22:19   ` Matt Roper
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 14/20] drm/xe/uc: Split xe_uc_fw_init Michał Winiarski
2023-11-15 22:28   ` Matt Roper
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 15/20] drm/xe/uc: Store firmware binary in system-memory backed BO Michał Winiarski
2023-11-15 22:34   ` Matt Roper
2023-11-20 20:04   ` Lucas De Marchi
2023-11-20 21:34     ` Daniele Ceraolo Spurio
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 16/20] drm/xe/uc: Extract xe_uc_sanitize_reset Michał Winiarski
2023-11-16 12:56   ` Matthew Brost
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 17/20] drm/xe/guc: Split GuC params used for "hwconfig" and "post-hwconfig" Michał Winiarski
2023-11-20 13:25   ` Matthew Brost
2023-11-20 20:09   ` Lucas De Marchi
2023-11-21 13:36     ` Michał Winiarski
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 18/20] drm/xe/guc: Allocate GuC data structures in system memory for initial load Michał Winiarski
2023-11-20 20:20   ` Lucas De Marchi
2023-11-21 13:42     ` Michał Winiarski
2023-11-21 16:49       ` Lucas De Marchi
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 19/20] drm/xe/guc: Move GuC power control init to "post-hwconfig" Michał Winiarski
2023-11-20 13:30   ` Matthew Brost
2023-11-14 13:02 ` [Intel-xe] [PATCH v3 20/20] drm/xe: Initialize GuC earlier during probe Michał Winiarski
2023-11-15 15:09   ` Matthew Brost
2023-11-21 16:07     ` Michał Winiarski
2023-11-14 13:07 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Probe tweaks and reordering (rev2) Patchwork
2023-11-14 13:08 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-14 13:09 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-14 13:16 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-14 13:16 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-14 13:18 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-14 13:51 ` [Intel-xe] ✓ CI.BAT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.