All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com,
	linux-arm-kernel@lists.infradead.org, quic_asartor@quicinc.com,
	quic_lingutla@quicinc.com
Subject: Re: [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count
Date: Thu, 30 Nov 2023 13:00:02 +0000	[thread overview]
Message-ID: <ZWiHUt-N8GvG5z_O@pluto> (raw)
In-Reply-To: <20231129065748.19871-4-quic_sibis@quicinc.com>

On Wed, Nov 29, 2023 at 12:27:48PM +0530, Sibi Sankar wrote:
> The number of opps on certain variants of the X1E80100 SoC are greater
> than current maximum, so increase the MAX_OPP count to the next log level
> to accommodate that.
> 

Hi,


> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>  drivers/firmware/arm_scmi/perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index 3344ce3a2026..edf34a3c4d6a 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -24,7 +24,7 @@
>  #include "protocols.h"
>  #include "notify.h"
>  
> -#define MAX_OPPS		16
> +#define MAX_OPPS		24
>

There is an hashtable, opps_by_freq, sized by an ilog2()....

....so, can we stick to a power-of-2 like 32 instead ?
(and be more future proof too...)

Other than this, LGTM

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com,
	linux-arm-kernel@lists.infradead.org, quic_asartor@quicinc.com,
	quic_lingutla@quicinc.com
Subject: Re: [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count
Date: Thu, 30 Nov 2023 13:00:02 +0000	[thread overview]
Message-ID: <ZWiHUt-N8GvG5z_O@pluto> (raw)
In-Reply-To: <20231129065748.19871-4-quic_sibis@quicinc.com>

On Wed, Nov 29, 2023 at 12:27:48PM +0530, Sibi Sankar wrote:
> The number of opps on certain variants of the X1E80100 SoC are greater
> than current maximum, so increase the MAX_OPP count to the next log level
> to accommodate that.
> 

Hi,


> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>  drivers/firmware/arm_scmi/perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index 3344ce3a2026..edf34a3c4d6a 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -24,7 +24,7 @@
>  #include "protocols.h"
>  #include "notify.h"
>  
> -#define MAX_OPPS		16
> +#define MAX_OPPS		24
>

There is an hashtable, opps_by_freq, sized by an ilog2()....

....so, can we stick to a power-of-2 like 32 instead ?
(and be more future proof too...)

Other than this, LGTM

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-30 13:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29  6:57 [PATCH 0/3] firmware: arm_scmi: Miscellaneous fixes and opp count increase Sibi Sankar
2023-11-29  6:57 ` Sibi Sankar
2023-11-29  6:57 ` [PATCH 1/3] firmware: arm_scmi: Fix null pointer dereference during fastchannel init Sibi Sankar
2023-11-29  6:57   ` Sibi Sankar
2023-11-30 12:36   ` Cristian Marussi
2023-11-30 12:36     ` Cristian Marussi
2023-11-29  6:57 ` [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the perf protocol Sibi Sankar
2023-11-29  6:57   ` Sibi Sankar
2023-11-30 12:05   ` Sudeep Holla
2023-11-30 12:05     ` Sudeep Holla
2023-11-30 12:49     ` Cristian Marussi
2023-11-30 12:49       ` Cristian Marussi
2023-11-30 13:56       ` Sudeep Holla
2023-11-30 13:56         ` Sudeep Holla
2023-11-30 16:25         ` Cristian Marussi
2023-11-30 16:25           ` Cristian Marussi
2023-11-30 19:32           ` Sibi Sankar
2023-11-30 19:32             ` Sibi Sankar
2023-11-30 20:14             ` Sudeep Holla
2023-11-30 20:14               ` Sudeep Holla
2023-11-30 19:51           ` Sudeep Holla
2023-11-30 19:51             ` Sudeep Holla
2023-11-29  6:57 ` [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count Sibi Sankar
2023-11-29  6:57   ` Sibi Sankar
2023-11-30 13:00   ` Cristian Marussi [this message]
2023-11-30 13:00     ` Cristian Marussi
2023-11-30 19:16     ` Sibi Sankar
2023-11-30 19:16       ` Sibi Sankar
2023-12-04 13:55 ` (subset) [PATCH 0/3] firmware: arm_scmi: Miscellaneous fixes and opp count increase Sudeep Holla
2023-12-04 13:55   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZWiHUt-N8GvG5z_O@pluto \
    --to=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_asartor@quicinc.com \
    --cc=quic_lingutla@quicinc.com \
    --cc=quic_mdtipton@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.