[PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions()

[PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions()

[Daniel Mentz]

The variable phys is defined as (struct resource *) which aligns with
the printk format specifier %pr. Taking the address of it results in a
value of type (struct resource **) which is incompatible with the format
specifier %pr. Therefore, remove the address of operator (&).

Fixes: a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
Signed-off-by: Daniel Mentz <danielmentz@google.com>
---
 drivers/iommu/of_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 157b286e36bf..d1f3b92560bc 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -191,7 +191,7 @@ iommu_resv_region_get_type(struct device *dev,
 	if (start == phys->start && end == phys->end)
 		return IOMMU_RESV_DIRECT;
 
-	dev_warn(dev, "treating non-direct mapping [%pr] -> [%pap-%pap] as reservation\n", &phys,
+	dev_warn(dev, "treating non-direct mapping [%pr] -> [%pap-%pap] as reservation\n", phys,
 		 &start, &end);
 	return IOMMU_RESV_RESERVED;
 }
-- 
2.42.0.869.gea05f2083d-goog

Re: [PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions()

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

On Tue, Nov 07, 2023 at 10:22:26PM -0800, Daniel Mentz wrote:
> The variable phys is defined as (struct resource *) which aligns with
> the printk format specifier %pr. Taking the address of it results in a
> value of type (struct resource **) which is incompatible with the format
> specifier %pr. Therefore, remove the address of operator (&).
> 
> Fixes: a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
> Signed-off-by: Daniel Mentz <danielmentz@google.com>
> ---
>  drivers/iommu/of_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ugh... I don't know why I missed that, because I thought I had tested
that path. In any case, this fix is correct, so:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions()

[Joerg Roedel]

On Tue, Nov 07, 2023 at 10:22:26PM -0800, Daniel Mentz wrote:
>  drivers/iommu/of_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.
-- 
Jörg Rödel
jroedel@suse.de

SUSE Software Solutions Germany GmbH
Frankenstraße 146
90461 Nürnberg
Germany

(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman