From: Sean Christopherson <seanjc@google.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()
Date: Tue, 12 Dec 2023 07:28:54 -0800 [thread overview]
Message-ID: <ZXh8Nq_y_szj1WN0@google.com> (raw)
In-Reply-To: <CALMp9eTT97oDmQT7pxeOMLQbt-371aMtC2Kev+-kWXVRDVrjeg@mail.gmail.com>
On Sun, Dec 10, 2023, Jim Mattson wrote:
> On Thu, Dec 7, 2023 at 8:21?AM Sean Christopherson <seanjc@google.com> wrote:
> > Doh. We got the less obvious cases and missed the obvious one.
> >
> > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(). That
> > thing should really be folded into vmx_has_nested_events().
> >
> > Good gravy. And vmx_interrupt_blocked() does the wrong thing because that
> > specifically checks if L1 interrupts are blocked.
> >
> > Compile tested only, and definitely needs to be chunked into multiple patches,
> > but I think something like this mess?
>
> The proposed patch does not fix the problem. In fact, it messes things
> up so much that I don't get any test results back.
Drat.
> Google has an internal K-U-T test that demonstrates the problem. I
> will post it soon.
Received, I'll dig in soonish, though "soonish" might unfortunately might mean
2024.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: alexandru.elisei@arm.com, anup@brainfault.org,
aou@eecs.berkeley.edu, atishp@atishpatra.org,
borntraeger@linux.ibm.com, chenhuacai@kernel.org,
david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com,
james.morse@arm.com, kvm-riscv@lists.infradead.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
maz@kernel.org, mlevitsk@redhat.com, oliver.upton@linux.dev,
palmer@dabbelt.com, paul.walmsley@sifive.com,
pbonzini@redhat.com, suzuki.poulose@arm.com
Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()
Date: Tue, 12 Dec 2023 07:28:54 -0800 [thread overview]
Message-ID: <ZXh8Nq_y_szj1WN0@google.com> (raw)
In-Reply-To: <CALMp9eTT97oDmQT7pxeOMLQbt-371aMtC2Kev+-kWXVRDVrjeg@mail.gmail.com>
On Sun, Dec 10, 2023, Jim Mattson wrote:
> On Thu, Dec 7, 2023 at 8:21 AM Sean Christopherson <seanjc@google.com> wrote:
> > Doh. We got the less obvious cases and missed the obvious one.
> >
> > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(). That
> > thing should really be folded into vmx_has_nested_events().
> >
> > Good gravy. And vmx_interrupt_blocked() does the wrong thing because that
> > specifically checks if L1 interrupts are blocked.
> >
> > Compile tested only, and definitely needs to be chunked into multiple patches,
> > but I think something like this mess?
>
> The proposed patch does not fix the problem. In fact, it messes things
> up so much that I don't get any test results back.
Drat.
> Google has an internal K-U-T test that demonstrates the problem. I
> will post it soon.
Received, I'll dig in soonish, though "soonish" might unfortunately might mean
2024.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: alexandru.elisei@arm.com, anup@brainfault.org,
aou@eecs.berkeley.edu, atishp@atishpatra.org,
borntraeger@linux.ibm.com, chenhuacai@kernel.org,
david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com,
james.morse@arm.com, kvm-riscv@lists.infradead.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
maz@kernel.org, mlevitsk@redhat.com, oliver.upton@linux.dev,
palmer@dabbelt.com, paul.walmsley@sifive.com,
pbonzini@redhat.com, suzuki.poulose@arm.com
Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()
Date: Tue, 12 Dec 2023 07:28:54 -0800 [thread overview]
Message-ID: <ZXh8Nq_y_szj1WN0@google.com> (raw)
In-Reply-To: <CALMp9eTT97oDmQT7pxeOMLQbt-371aMtC2Kev+-kWXVRDVrjeg@mail.gmail.com>
On Sun, Dec 10, 2023, Jim Mattson wrote:
> On Thu, Dec 7, 2023 at 8:21 AM Sean Christopherson <seanjc@google.com> wrote:
> > Doh. We got the less obvious cases and missed the obvious one.
> >
> > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(). That
> > thing should really be folded into vmx_has_nested_events().
> >
> > Good gravy. And vmx_interrupt_blocked() does the wrong thing because that
> > specifically checks if L1 interrupts are blocked.
> >
> > Compile tested only, and definitely needs to be chunked into multiple patches,
> > but I think something like this mess?
>
> The proposed patch does not fix the problem. In fact, it messes things
> up so much that I don't get any test results back.
Drat.
> Google has an internal K-U-T test that demonstrates the problem. I
> will post it soon.
Received, I'll dig in soonish, though "soonish" might unfortunately might mean
2024.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm@vger.kernel.org, david@redhat.com, atishp@atishpatra.org,
linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org,
imbrenda@linux.ibm.com, frankja@linux.ibm.com, maz@kernel.org,
chenhuacai@kernel.org, mlevitsk@redhat.com, palmer@dabbelt.com,
borntraeger@linux.ibm.com, aou@eecs.berkeley.edu,
suzuki.poulose@arm.com, paul.walmsley@sifive.com,
alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, oliver.upton@linux.dev,
james.morse@arm.com, kvm-riscv@lists.infradead.org,
anup@brainfault.org, pbonzini@redhat.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()
Date: Tue, 12 Dec 2023 07:28:54 -0800 [thread overview]
Message-ID: <ZXh8Nq_y_szj1WN0@google.com> (raw)
In-Reply-To: <CALMp9eTT97oDmQT7pxeOMLQbt-371aMtC2Kev+-kWXVRDVrjeg@mail.gmail.com>
On Sun, Dec 10, 2023, Jim Mattson wrote:
> On Thu, Dec 7, 2023 at 8:21 AM Sean Christopherson <seanjc@google.com> wrote:
> > Doh. We got the less obvious cases and missed the obvious one.
> >
> > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(). That
> > thing should really be folded into vmx_has_nested_events().
> >
> > Good gravy. And vmx_interrupt_blocked() does the wrong thing because that
> > specifically checks if L1 interrupts are blocked.
> >
> > Compile tested only, and definitely needs to be chunked into multiple patches,
> > but I think something like this mess?
>
> The proposed patch does not fix the problem. In fact, it messes things
> up so much that I don't get any test results back.
Drat.
> Google has an internal K-U-T test that demonstrates the problem. I
> will post it soon.
Received, I'll dig in soonish, though "soonish" might unfortunately might mean
2024.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: alexandru.elisei@arm.com, anup@brainfault.org,
aou@eecs.berkeley.edu, atishp@atishpatra.org,
borntraeger@linux.ibm.com, chenhuacai@kernel.org,
david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com,
james.morse@arm.com, kvm-riscv@lists.infradead.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
maz@kernel.org, mlevitsk@redhat.com, oliver.upton@linux.dev,
palmer@dabbelt.com, paul.walmsley@sifive.com,
pbonzini@redhat.com, suzuki.poulose@arm.com
Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()
Date: Tue, 12 Dec 2023 07:28:54 -0800 [thread overview]
Message-ID: <ZXh8Nq_y_szj1WN0@google.com> (raw)
In-Reply-To: <CALMp9eTT97oDmQT7pxeOMLQbt-371aMtC2Kev+-kWXVRDVrjeg@mail.gmail.com>
On Sun, Dec 10, 2023, Jim Mattson wrote:
> On Thu, Dec 7, 2023 at 8:21 AM Sean Christopherson <seanjc@google.com> wrote:
> > Doh. We got the less obvious cases and missed the obvious one.
> >
> > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(). That
> > thing should really be folded into vmx_has_nested_events().
> >
> > Good gravy. And vmx_interrupt_blocked() does the wrong thing because that
> > specifically checks if L1 interrupts are blocked.
> >
> > Compile tested only, and definitely needs to be chunked into multiple patches,
> > but I think something like this mess?
>
> The proposed patch does not fix the problem. In fact, it messes things
> up so much that I don't get any test results back.
Drat.
> Google has an internal K-U-T test that demonstrates the problem. I
> will post it soon.
Received, I'll dig in soonish, though "soonish" might unfortunately might mean
2024.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-12 15:28 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 0:31 [PATCH v4 00/12] KVM: x86: never write to memory from kvm_vcpu_check_block Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 01/12] KVM: x86: make vendor code check for all nested events Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 02/12] KVM: nVMX: Make an event request when pending an MTF nested VM-Exit Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 03/12] KVM: x86: Rename and expose helper to detect if INIT/SIPI are allowed Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 04/12] KVM: x86: Rename kvm_apic_has_events() to make it INIT/SIPI specific Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 05/12] KVM: x86: lapic does not have to process INIT if it is blocked Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 06/12] KVM: SVM: Make an event request if INIT or SIPI is pending when GIF is set Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 07/12] KVM: nVMX: Make an event request if INIT or SIPI is pending on VM-Enter Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 08/12] KVM: nVMX: Make event request on VMXOFF iff INIT/SIPI is pending Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 09/12] KVM: x86: Don't snapshot pending INIT/SIPI prior to checking nested events Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2022-09-21 0:31 ` Sean Christopherson
2023-12-07 1:03 ` Jim Mattson
2023-12-07 1:03 ` Jim Mattson
2023-12-07 1:03 ` Jim Mattson
2023-12-07 1:03 ` Jim Mattson
2023-12-07 1:03 ` Jim Mattson
2023-12-07 16:21 ` Sean Christopherson
2023-12-07 16:21 ` Sean Christopherson
2023-12-07 16:21 ` Sean Christopherson
2023-12-07 16:21 ` Sean Christopherson
2023-12-07 16:21 ` Sean Christopherson
2023-12-10 22:52 ` Jim Mattson
2023-12-10 22:52 ` Jim Mattson
2023-12-10 22:52 ` Jim Mattson
2023-12-10 22:52 ` Jim Mattson
2023-12-10 22:52 ` Jim Mattson
2023-12-12 15:28 ` Sean Christopherson [this message]
2023-12-12 15:28 ` Sean Christopherson
2023-12-12 15:28 ` Sean Christopherson
2023-12-12 15:28 ` Sean Christopherson
2023-12-12 15:28 ` Sean Christopherson
2023-12-13 22:25 ` Maxim Levitsky
2023-12-13 22:25 ` Maxim Levitsky
2023-12-13 22:25 ` Maxim Levitsky
2023-12-13 22:25 ` Maxim Levitsky
2023-12-13 22:25 ` Maxim Levitsky
2023-12-13 22:31 ` Jim Mattson
2023-12-13 22:31 ` Jim Mattson
2023-12-13 22:31 ` Jim Mattson
2023-12-13 22:31 ` Jim Mattson
2023-12-13 22:31 ` Jim Mattson
2023-12-13 22:44 ` Maxim Levitsky
2023-12-13 22:44 ` Maxim Levitsky
2023-12-13 22:44 ` Maxim Levitsky
2023-12-13 22:44 ` Maxim Levitsky
2023-12-13 22:44 ` Maxim Levitsky
2023-12-13 22:59 ` Sean Christopherson
2023-12-13 22:59 ` Sean Christopherson
2023-12-13 22:59 ` Sean Christopherson
2023-12-13 22:59 ` Sean Christopherson
2023-12-13 22:59 ` Sean Christopherson
2022-09-21 0:32 ` [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-22 13:17 ` Philippe Mathieu-Daudé
2022-09-22 13:17 ` Philippe Mathieu-Daudé
2022-09-22 13:17 ` Philippe Mathieu-Daudé
2022-09-22 13:17 ` Philippe Mathieu-Daudé
2022-09-22 13:17 ` Philippe Mathieu-Daudé
2022-09-22 13:17 ` Philippe Mathieu-Daudé
2022-09-21 0:32 ` [PATCH v4 12/12] KVM: remove KVM_REQ_UNHALT Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-21 0:32 ` Sean Christopherson
2022-09-22 14:52 ` Marc Zyngier
2022-09-22 14:52 ` Marc Zyngier
2022-09-22 14:52 ` Marc Zyngier
2022-09-22 14:52 ` Marc Zyngier
2022-09-22 14:52 ` Marc Zyngier
2022-09-22 14:52 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXh8Nq_y_szj1WN0@google.com \
--to=seanjc@google.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.