From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in atomic context
Date: Mon, 18 Dec 2023 09:02:29 +0000 [thread overview]
Message-ID: <ZYAKpXOgF1j03KPF@gofer.mess.org> (raw)
In-Reply-To: <20231212160838.k4z4csy455a7qnje@pengutronix.de>
On Tue, Dec 12, 2023 at 05:08:38PM +0100, Uwe Kleine-König wrote:
> Hello Sean,
>
> On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote:
> > @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev)
> > {
> > struct bcm2835_pwm *pc = dev_get_drvdata(dev);
> >
> > + clk_rate_exclusive_put(pc->clk);
> > clk_disable_unprepare(pc->clk);
>
> I thought this was the remove function, but that's suspend. Adding
> clk_rate_exclusive_put() there is wrong.
Nice catch - fixed in v9.
Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in atomic context
Date: Mon, 18 Dec 2023 09:02:29 +0000 [thread overview]
Message-ID: <ZYAKpXOgF1j03KPF@gofer.mess.org> (raw)
In-Reply-To: <20231212160838.k4z4csy455a7qnje@pengutronix.de>
On Tue, Dec 12, 2023 at 05:08:38PM +0100, Uwe Kleine-König wrote:
> Hello Sean,
>
> On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote:
> > @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev)
> > {
> > struct bcm2835_pwm *pc = dev_get_drvdata(dev);
> >
> > + clk_rate_exclusive_put(pc->clk);
> > clk_disable_unprepare(pc->clk);
>
> I thought this was the remove function, but that's suspend. Adding
> clk_rate_exclusive_put() there is wrong.
Nice catch - fixed in v9.
Sean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-18 9:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:33 [PATCH v8 0/6] Improve pwm-ir-tx precision Sean Young
2023-12-12 8:34 ` [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep() Sean Young
2023-12-12 8:34 ` Sean Young
2023-12-12 8:34 ` Sean Young
2023-12-12 11:41 ` Uwe Kleine-König
2023-12-12 11:41 ` Uwe Kleine-König
2023-12-12 11:41 ` Uwe Kleine-König
2023-12-12 11:41 ` Uwe Kleine-König
2023-12-12 15:22 ` Guenter Roeck
2023-12-12 15:22 ` Guenter Roeck
2023-12-12 15:22 ` Guenter Roeck
2023-12-12 15:22 ` Guenter Roeck
2023-12-12 15:27 ` Mark Brown
2023-12-12 15:27 ` Mark Brown
2023-12-12 15:27 ` Mark Brown
2023-12-12 15:27 ` Mark Brown
2023-12-12 8:34 ` [PATCH v8 2/6] pwm: Replace ENOTSUPP with EOPNOTSUPP Sean Young
2023-12-12 11:31 ` Uwe Kleine-König
2023-12-12 8:34 ` [PATCH v8 3/6] pwm: renesas: Remove unused include Sean Young
2023-12-12 11:28 ` Uwe Kleine-König
2023-12-12 8:34 ` [PATCH v8 4/6] pwm: Make it possible to apply PWM changes in atomic context Sean Young
2023-12-12 11:48 ` Uwe Kleine-König
2023-12-18 9:03 ` Sean Young
2023-12-12 8:34 ` [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used " Sean Young
2023-12-12 8:34 ` Sean Young
2023-12-12 11:50 ` Uwe Kleine-König
2023-12-12 11:50 ` Uwe Kleine-König
2023-12-12 16:08 ` Uwe Kleine-König
2023-12-12 16:08 ` Uwe Kleine-König
2023-12-12 16:11 ` Florian Fainelli
2023-12-12 16:11 ` Florian Fainelli
2023-12-12 18:14 ` Uwe Kleine-König
2023-12-12 18:14 ` Uwe Kleine-König
2023-12-18 9:02 ` Sean Young
2023-12-18 9:02 ` Sean Young
2023-12-18 9:02 ` Sean Young [this message]
2023-12-18 9:02 ` Sean Young
2023-12-12 8:34 ` [PATCH v8 6/6] media: pwm-ir-tx: Trigger edges from hrtimer interrupt context Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYAKpXOgF1j03KPF@gofer.mess.org \
--to=sean@mess.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.