Re: [PATCH] Bluetooth: hci_bcm4377: do not mark valid bd_addr as invalid

From: Johan Hovold <johan@kernel.org>
To: Felix Zhang <mrman@mrman314.tech>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_bcm4377: do not mark valid bd_addr as invalid
Date: Wed, 27 Dec 2023 19:35:53 +0100	[thread overview]
Message-ID: <ZYxuiTYxToF7FpdW@hovoldconsulting.com> (raw)
In-Reply-To: <f06dbc4d10ff5eb038228e9c7abb75c85514cf36.camel@mrman314.tech>

On Wed, Dec 27, 2023 at 01:19:39PM -0500, Felix Zhang wrote:
> On Wed, 2023-12-27 at 11:10 +0100, Johan Hovold wrote:
> > A recent commit restored the original (and still documented)
> > semantics
> > for the HCI_QUIRK_USE_BDADDR_PROPERTY quirk so that the device
> > address
> > is considered invalid unless an address is provided by firmware.
> > 
> > This specifically means that this flag must only be set for devices
> > with
> > invalid addresses, but the Broadcom BCM4377 driver has so far been
> > setting this flag unconditionally.
> > 
> > Fortunately the driver already checks for invalid addresses during
> > setup
> > and sets the HCI_QUIRK_INVALID_BDADDR flag, which can simply be
> > replaced
> > with HCI_QUIRK_USE_BDADDR_PROPERTY to indicate that the default
> > address
> > is invalid but can be overridden by firmware (long term, this should
> > probably just always be allowed).
> > 
> > Fixes: 6945795bc81a ("Bluetooth: fix use-bdaddr-property quirk")
> > Cc: stable@vger.kernel.org      # 6.5
> > Reported-by: Felix Zhang <mrman@mrman314.tech>
> > Link:
> > https://lore.kernel.org/r/77419ffacc5b4875e920e038332575a2a5bff29f.camel@mrman314.tech/
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

> Thanks for the patch!  I have just tested the patch on my MacBookAir9,1
> with some modifications to make it patch with the master branch of the
> Linux kernel, and it works great!  The device is recognized by the
> system; and I can scan, pair, connect, and play audio just fine.  If
> you want me to send over the modified patch that I have used, please
> let me know.

Thanks for confirming. You should not need to modify the patch, though,
as it has been created against 6.7-rc6 and there hasn't been any changes
to this driver since rc1.

Johan