From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Matthew Wilcox <willy@infradead.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Lorenzo Stoakes <lstoakes@gmail.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Kravetz <mike.kravetz@oracle.com>,
Mike Rapoport <rppt@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Jones <andrew.jones@linux.dev>,
linux-arm-kernel@lists.infradead.org,
Michael Ellerman <mpe@ellerman.id.au>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
linuxppc-dev@lists.ozlabs.org, Rik van Riel <riel@surriel.com>,
linux-riscv@lists.infradead.org, Yang Shi <shy828301@gmail.com>,
James Houghton <jthoughton@google.com>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()
Date: Tue, 2 Jan 2024 13:37:14 +0800 [thread overview]
Message-ID: <ZZOhCuuozrBscdRC@x1n> (raw)
In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev>
On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
> > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
> > #endif /* pmd_write */
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > +#ifndef pmd_thp_or_huge
>
> I think it may be the time to rename to pmd_thp_or_hugetlb,
> the "huge" is really confusing. thp is not huge? Actually,
> it is huge. It is better to make it more specific from now on, like
> "hugetlb".
The rename will need to touch ARM code, which I wanted to avoid, see:
arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd))
So far this series only touches generic code. Would you mind I keep this
patch as-is, and leave renaming to later?
>
> BTW, please cc me via the new email (muchun.song@linux.dev) next edition.
Sure. Thanks for taking a look.
--
Peter Xu
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: James Houghton <jthoughton@google.com>,
David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>,
Andrew Jones <andrew.jones@linux.dev>,
linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>,
linux-riscv@lists.infradead.org,
Andrea Arcangeli <aarcange@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Jason Gunthorpe <jgg@nvidia.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Rik van Riel <riel@surriel.com>,
John Hubbard <jhubbard@nvidia.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
linux-arm-kernel@lists.infradead.org,
Lorenzo Stoakes <lstoakes@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Mike Rapoport <rppt@kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()
Date: Tue, 2 Jan 2024 13:37:14 +0800 [thread overview]
Message-ID: <ZZOhCuuozrBscdRC@x1n> (raw)
In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev>
On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
> > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
> > #endif /* pmd_write */
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > +#ifndef pmd_thp_or_huge
>
> I think it may be the time to rename to pmd_thp_or_hugetlb,
> the "huge" is really confusing. thp is not huge? Actually,
> it is huge. It is better to make it more specific from now on, like
> "hugetlb".
The rename will need to touch ARM code, which I wanted to avoid, see:
arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd))
So far this series only touches generic code. Would you mind I keep this
patch as-is, and leave renaming to later?
>
> BTW, please cc me via the new email (muchun.song@linux.dev) next edition.
Sure. Thanks for taking a look.
--
Peter Xu
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Matthew Wilcox <willy@infradead.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Lorenzo Stoakes <lstoakes@gmail.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Kravetz <mike.kravetz@oracle.com>,
Mike Rapoport <rppt@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Jones <andrew.jones@linux.dev>,
linux-arm-kernel@lists.infradead.org,
Michael Ellerman <mpe@ellerman.id.au>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
linuxppc-dev@lists.ozlabs.org, Rik van Riel <riel@surriel.com>,
linux-riscv@lists.infradead.org, Yang Shi <shy828301@gmail.com>,
James Houghton <jthoughton@google.com>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()
Date: Tue, 2 Jan 2024 13:37:14 +0800 [thread overview]
Message-ID: <ZZOhCuuozrBscdRC@x1n> (raw)
In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev>
On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
> > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
> > #endif /* pmd_write */
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > +#ifndef pmd_thp_or_huge
>
> I think it may be the time to rename to pmd_thp_or_hugetlb,
> the "huge" is really confusing. thp is not huge? Actually,
> it is huge. It is better to make it more specific from now on, like
> "hugetlb".
The rename will need to touch ARM code, which I wanted to avoid, see:
arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd))
So far this series only touches generic code. Would you mind I keep this
patch as-is, and leave renaming to later?
>
> BTW, please cc me via the new email (muchun.song@linux.dev) next edition.
Sure. Thanks for taking a look.
--
Peter Xu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Matthew Wilcox <willy@infradead.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Lorenzo Stoakes <lstoakes@gmail.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Kravetz <mike.kravetz@oracle.com>,
Mike Rapoport <rppt@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Jones <andrew.jones@linux.dev>,
linux-arm-kernel@lists.infradead.org,
Michael Ellerman <mpe@ellerman.id.au>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
linuxppc-dev@lists.ozlabs.org, Rik van Riel <riel@surriel.com>,
linux-riscv@lists.infradead.org, Yang Shi <shy828301@gmail.com>,
James Houghton <jthoughton@google.com>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()
Date: Tue, 2 Jan 2024 13:37:14 +0800 [thread overview]
Message-ID: <ZZOhCuuozrBscdRC@x1n> (raw)
In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev>
On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
> > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
> > #endif /* pmd_write */
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > +#ifndef pmd_thp_or_huge
>
> I think it may be the time to rename to pmd_thp_or_hugetlb,
> the "huge" is really confusing. thp is not huge? Actually,
> it is huge. It is better to make it more specific from now on, like
> "hugetlb".
The rename will need to touch ARM code, which I wanted to avoid, see:
arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd))
So far this series only touches generic code. Would you mind I keep this
patch as-is, and leave renaming to later?
>
> BTW, please cc me via the new email (muchun.song@linux.dev) next edition.
Sure. Thanks for taking a look.
--
Peter Xu
next prev parent reply other threads:[~2024-01-02 5:37 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 7:55 [PATCH 00/13] mm/gup: Unify hugetlb, part 2 peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 02/13] mm/hugetlb: Declare hugetlbfs_pagecache_present() non-static peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-25 6:29 ` Muchun Song
2023-12-25 6:29 ` Muchun Song
2023-12-25 6:29 ` Muchun Song
2023-12-25 6:29 ` Muchun Song
2024-01-02 5:37 ` Peter Xu [this message]
2024-01-02 5:37 ` Peter Xu
2024-01-02 5:37 ` Peter Xu
2024-01-02 5:37 ` Peter Xu
2024-01-02 6:30 ` Muchun Song
2024-01-02 6:30 ` Muchun Song
2024-01-02 6:30 ` Muchun Song
2024-01-02 6:30 ` Muchun Song
2023-12-19 7:55 ` [PATCH 04/13] mm: Make HPAGE_PXD_* macros even if !THP peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 05/13] mm: Introduce vma_pgtable_walk_{begin|end}() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-25 6:34 ` Muchun Song
2023-12-25 6:34 ` Muchun Song
2023-12-25 6:34 ` Muchun Song
2023-12-25 6:34 ` Muchun Song
2024-01-02 5:39 ` Peter Xu
2024-01-02 5:39 ` Peter Xu
2024-01-02 5:39 ` Peter Xu
2024-01-02 5:39 ` Peter Xu
2024-01-02 6:29 ` Muchun Song
2024-01-02 6:29 ` Muchun Song
2024-01-02 6:29 ` Muchun Song
2024-01-02 6:29 ` Muchun Song
2023-12-19 7:55 ` [PATCH 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 07/13] mm/gup: Refactor record_subpages() to find 1st small page peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 08/13] mm/gup: Handle hugetlb for no_page_table() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 09/13] mm/gup: Cache *pudp in follow_pud_mask() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 16:28 ` James Houghton
2023-12-19 16:28 ` James Houghton
2023-12-19 16:28 ` James Houghton
2023-12-19 16:28 ` James Houghton
2023-12-20 1:43 ` Peter Xu
2023-12-20 1:43 ` Peter Xu
2023-12-20 1:43 ` Peter Xu
2023-12-20 1:43 ` Peter Xu
2023-12-19 7:55 ` [PATCH 10/13] mm/gup: Handle huge pud for follow_pud_mask() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 11/13] mm/gup: Handle huge pmd for follow_pmd_mask() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 12/13] mm/gup: Handle hugepd for follow_page() peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` [PATCH 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-19 7:55 ` peterx
2023-12-22 1:35 ` [PATCH 00/13] mm/gup: Unify hugetlb, part 2 Peter Xu
2023-12-22 1:35 ` Peter Xu
2023-12-22 1:35 ` Peter Xu
2023-12-22 1:35 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZOhCuuozrBscdRC@x1n \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.jones@linux.dev \
--cc=aneesh.kumar@kernel.org \
--cc=axelrasmussen@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jthoughton@google.com \
--cc=kirill@shutemov.name \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lstoakes@gmail.com \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=muchun.song@linux.dev \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.