From: Daniel Golle <daniel@makrotopia.org>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
"Russell King \(Oracle\)" <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Alexander Couzens <lynxis@fe80.eu>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x
Date: Tue, 2 Jan 2024 21:01:23 +0100 [thread overview]
Message-ID: <ZZRrk85SCDmo76NJ@pidgin.makrotopia.org> (raw)
In-Reply-To: <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com>
On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote:
> [...]
>
> So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else.
Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to
change phylink for it to work.
This should be enough:
https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Frank Wunderlich <frank-w@public-files.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x
Date: Tue, 2 Jan 2024 21:01:23 +0100 [thread overview]
Message-ID: <ZZRrk85SCDmo76NJ@pidgin.makrotopia.org> (raw)
In-Reply-To: <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com>
On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote:
> [...]
>
> So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else.
Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to
change phylink for it to work.
This should be enough:
https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Alexander Couzens <lynxis@fe80.eu>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Frank Wunderlich <frank-w@public-files.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x
Date: Tue, 2 Jan 2024 21:01:23 +0100 [thread overview]
Message-ID: <ZZRrk85SCDmo76NJ@pidgin.makrotopia.org> (raw)
In-Reply-To: <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com>
On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote:
> [...]
>
> So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else.
Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to
change phylink for it to work.
This should be enough:
https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/
next prev parent reply other threads:[~2024-01-02 20:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 7:44 [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x Eric Woudstra
2024-01-02 7:44 ` Eric Woudstra
2024-01-02 12:10 ` Russell King (Oracle)
2024-01-02 12:10 ` Russell King (Oracle)
2024-01-02 12:10 ` Russell King (Oracle)
2024-01-02 12:55 ` Eric Woudstra
2024-01-02 12:55 ` Eric Woudstra
2024-01-02 12:55 ` Eric Woudstra
2024-01-02 19:33 ` Eric Woudstra
2024-01-02 19:33 ` Eric Woudstra
2024-01-02 19:33 ` Eric Woudstra
2024-01-02 20:01 ` Daniel Golle [this message]
2024-01-02 20:01 ` Daniel Golle
2024-01-02 20:01 ` Daniel Golle
2024-01-02 22:13 ` Eric Woudstra
2024-01-02 22:13 ` Eric Woudstra
2024-01-02 22:13 ` Eric Woudstra
2024-01-02 23:10 ` Daniel Golle
2024-01-02 23:10 ` Daniel Golle
2024-01-02 23:10 ` Daniel Golle
2024-01-03 8:51 ` Eric Woudstra
2024-01-03 8:51 ` Eric Woudstra
2024-01-03 8:51 ` Eric Woudstra
2024-01-03 11:20 ` Russell King (Oracle)
2024-01-03 11:20 ` Russell King (Oracle)
2024-01-03 11:20 ` Russell King (Oracle)
2024-01-03 9:50 ` Russell King (Oracle)
2024-01-03 9:50 ` Russell King (Oracle)
2024-01-03 9:50 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZRrk85SCDmo76NJ@pidgin.makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.