* [PATCH] android: removed asm-generic/errno-base.h
@ 2023-12-26 17:09 Tanzir Hasan
2024-01-04 15:09 ` Carlos Llamas
2024-01-04 15:36 ` Christophe JAILLET
0 siblings, 2 replies; 7+ messages in thread
From: Tanzir Hasan @ 2023-12-26 17:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan
Cc: linux-kernel, Nick Desaulniers, Al Viro, Tanzir Hasan
asm-generic/errno-base.h can be replaced by linux/errno.h and the file
will still build correctly. It is an asm-generic file which should be
avoided if possible.
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---
drivers/android/binderfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 1224ab7aa070..d04ff6029480 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -29,7 +29,7 @@
#include <linux/uaccess.h>
#include <linux/user_namespace.h>
#include <linux/xarray.h>
-#include <uapi/asm-generic/errno-base.h>
+#include <linux/errno.h>
#include <uapi/linux/android/binder.h>
#include <uapi/linux/android/binderfs.h>
---
base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
change-id: 20231218-binderfs-a758e162e0ba
Best regards,
--
Tanzir Hasan <tanzirh@google.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] android: removed asm-generic/errno-base.h
2023-12-26 17:09 [PATCH] android: removed asm-generic/errno-base.h Tanzir Hasan
@ 2024-01-04 15:09 ` Carlos Llamas
2024-01-04 15:36 ` Christophe JAILLET
1 sibling, 0 replies; 7+ messages in thread
From: Carlos Llamas @ 2024-01-04 15:09 UTC (permalink / raw)
To: Tanzir Hasan
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, linux-kernel, Nick Desaulniers, Al Viro
On Tue, Dec 26, 2023 at 05:09:23PM +0000, Tanzir Hasan wrote:
> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
> drivers/android/binderfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 1224ab7aa070..d04ff6029480 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -29,7 +29,7 @@
> #include <linux/uaccess.h>
> #include <linux/user_namespace.h>
> #include <linux/xarray.h>
> -#include <uapi/asm-generic/errno-base.h>
> +#include <linux/errno.h>
> #include <uapi/linux/android/binder.h>
> #include <uapi/linux/android/binderfs.h>
>
>
> ---
> base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
> change-id: 20231218-binderfs-a758e162e0ba
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
Acked-by: Carlos Llamas <cmllamas@google.com>
Thanks,
--
Carlos Llamas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] android: removed asm-generic/errno-base.h
2023-12-26 17:09 [PATCH] android: removed asm-generic/errno-base.h Tanzir Hasan
2024-01-04 15:09 ` Carlos Llamas
@ 2024-01-04 15:36 ` Christophe JAILLET
2024-01-04 16:08 ` Joel Fernandes
2024-01-04 17:18 ` Carlos Llamas
1 sibling, 2 replies; 7+ messages in thread
From: Christophe JAILLET @ 2024-01-04 15:36 UTC (permalink / raw)
To: Tanzir Hasan, Greg Kroah-Hartman, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
Carlos Llamas, Suren Baghdasaryan
Cc: linux-kernel, Nick Desaulniers, Al Viro
Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
> drivers/android/binderfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 1224ab7aa070..d04ff6029480 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -29,7 +29,7 @@
> #include <linux/uaccess.h>
> #include <linux/user_namespace.h>
> #include <linux/xarray.h>
> -#include <uapi/asm-generic/errno-base.h>
> +#include <linux/errno.h>
linux/errno.h is already included a few lines above.
CJ
> #include <uapi/linux/android/binder.h>
> #include <uapi/linux/android/binderfs.h>
>
>
> ---
> base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
> change-id: 20231218-binderfs-a758e162e0ba
>
> Best regards,
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] android: removed asm-generic/errno-base.h
2024-01-04 15:36 ` Christophe JAILLET
@ 2024-01-04 16:08 ` Joel Fernandes
2024-01-04 17:18 ` Carlos Llamas
1 sibling, 0 replies; 7+ messages in thread
From: Joel Fernandes @ 2024-01-04 16:08 UTC (permalink / raw)
To: Christophe JAILLET, Tanzir Hasan, Greg Kroah-Hartman,
Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Christian Brauner, Carlos Llamas, Suren Baghdasaryan
Cc: linux-kernel, Nick Desaulniers, Al Viro
On 1/4/2024 10:36 AM, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
>> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
>> will still build correctly. It is an asm-generic file which should be
>> avoided if possible.
>>
>> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
>> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
>> ---
>> drivers/android/binderfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
>> index 1224ab7aa070..d04ff6029480 100644
>> --- a/drivers/android/binderfs.c
>> +++ b/drivers/android/binderfs.c
>> @@ -29,7 +29,7 @@
>> #include <linux/uaccess.h>
>> #include <linux/user_namespace.h>
>> #include <linux/xarray.h>
>> -#include <uapi/asm-generic/errno-base.h>
>> +#include <linux/errno.h>
>
> linux/errno.h is already included a few lines above.
>
Good point! With that nit addressed:
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] android: removed asm-generic/errno-base.h
2024-01-04 15:36 ` Christophe JAILLET
2024-01-04 16:08 ` Joel Fernandes
@ 2024-01-04 17:18 ` Carlos Llamas
2024-01-04 17:32 ` Tanzir Hasan
1 sibling, 1 reply; 7+ messages in thread
From: Carlos Llamas @ 2024-01-04 17:18 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Tanzir Hasan, Greg Kroah-Hartman, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, linux-kernel, Nick Desaulniers, Al Viro
On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > will still build correctly. It is an asm-generic file which should be
> > avoided if possible.
> >
> > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > ---
> > drivers/android/binderfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > index 1224ab7aa070..d04ff6029480 100644
> > --- a/drivers/android/binderfs.c
> > +++ b/drivers/android/binderfs.c
> > @@ -29,7 +29,7 @@
> > #include <linux/uaccess.h>
> > #include <linux/user_namespace.h>
> > #include <linux/xarray.h>
> > -#include <uapi/asm-generic/errno-base.h>
> > +#include <linux/errno.h>
>
> linux/errno.h is already included a few lines above.
>
> CJ
>
Good catch! Then we should just drop the errno-base.h include.
--
Carlos Llamas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] android: removed asm-generic/errno-base.h
2024-01-04 17:18 ` Carlos Llamas
@ 2024-01-04 17:32 ` Tanzir Hasan
2024-01-04 18:16 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Tanzir Hasan @ 2024-01-04 17:32 UTC (permalink / raw)
To: Carlos Llamas
Cc: Christophe JAILLET, Greg Kroah-Hartman, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, linux-kernel, Nick Desaulniers, Al Viro
On Thu, Jan 4, 2024 at 9:18 AM Carlos Llamas <cmllamas@google.com> wrote:
>
> On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> > Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > > will still build correctly. It is an asm-generic file which should be
> > > avoided if possible.
> > >
> > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > > ---
> > > drivers/android/binderfs.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > > index 1224ab7aa070..d04ff6029480 100644
> > > --- a/drivers/android/binderfs.c
> > > +++ b/drivers/android/binderfs.c
> > > @@ -29,7 +29,7 @@
> > > #include <linux/uaccess.h>
> > > #include <linux/user_namespace.h>
> > > #include <linux/xarray.h>
> > > -#include <uapi/asm-generic/errno-base.h>
> > > +#include <linux/errno.h>
> >
> > linux/errno.h is already included a few lines above.
> >
> > CJ
> >
>
> Good catch! Then we should just drop the errno-base.h include.
>
> --
> Carlos Llamas
Thanks for bringing that up. I will correct it and just remove the
asm-generic header instead.
Best,
Tanzir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] android: removed asm-generic/errno-base.h
2024-01-04 17:32 ` Tanzir Hasan
@ 2024-01-04 18:16 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2024-01-04 18:16 UTC (permalink / raw)
To: Tanzir Hasan
Cc: Carlos Llamas, Christophe JAILLET, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, linux-kernel, Nick Desaulniers, Al Viro
On Thu, Jan 04, 2024 at 09:32:37AM -0800, Tanzir Hasan wrote:
> On Thu, Jan 4, 2024 at 9:18 AM Carlos Llamas <cmllamas@google.com> wrote:
> >
> > On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> > > Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > > > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > > > will still build correctly. It is an asm-generic file which should be
> > > > avoided if possible.
> > > >
> > > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > > > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > > > ---
> > > > drivers/android/binderfs.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > > > index 1224ab7aa070..d04ff6029480 100644
> > > > --- a/drivers/android/binderfs.c
> > > > +++ b/drivers/android/binderfs.c
> > > > @@ -29,7 +29,7 @@
> > > > #include <linux/uaccess.h>
> > > > #include <linux/user_namespace.h>
> > > > #include <linux/xarray.h>
> > > > -#include <uapi/asm-generic/errno-base.h>
> > > > +#include <linux/errno.h>
> > >
> > > linux/errno.h is already included a few lines above.
> > >
> > > CJ
> > >
> >
> > Good catch! Then we should just drop the errno-base.h include.
> >
> > --
> > Carlos Llamas
>
> Thanks for bringing that up. I will correct it and just remove the
> asm-generic header instead.
Please just send a patch removing the duplicate as I have already
applied this one.
thanks,
gre gk-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-04 18:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-26 17:09 [PATCH] android: removed asm-generic/errno-base.h Tanzir Hasan
2024-01-04 15:09 ` Carlos Llamas
2024-01-04 15:36 ` Christophe JAILLET
2024-01-04 16:08 ` Joel Fernandes
2024-01-04 17:18 ` Carlos Llamas
2024-01-04 17:32 ` Tanzir Hasan
2024-01-04 18:16 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.