[PATCH] tools/libxl: do not use `-c -E` compiler options together

[PATCH] tools/libxl: do not use `-c -E` compiler options together

[Roger Pau Monne]

It makes no sense to request for preprocessor only output and also request
object file generation.  Fix the _libxl.api-for-check target to only use
-E (preprocessor output).

Also Clang 20.0 reports an error if both options are used.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/libs/light/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 37e4d1670986..b690d921593d 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -195,7 +195,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	touch $@
 
 _libxl.api-for-check: $(XEN_INCLUDE)/libxl.h
-	$(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \
+	$(CC) $(CPPFLAGS) $(CFLAGS) -E $< $(APPEND_CFLAGS) \
 		-DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \
 		>$@.new
 	mv -f $@.new $@
-- 
2.48.1

Re: [PATCH] tools/libxl: do not use `-c -E` compiler options together

[Andrew Cooper]

On 07/04/2025 12:09 pm, Roger Pau Monne wrote:
> It makes no sense to request for preprocessor only output and also request
> object file generation.  Fix the _libxl.api-for-check target to only use
> -E (preprocessor output).
>
> Also Clang 20.0 reports an error if both options are used.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

As this is impacting GitlabCI, it wants backporting (ideally everywhere,
although I'm still accumulating other CI fixes on 4.18 and earlier).

~Andrew

Re: [PATCH] tools/libxl: do not use `-c -E` compiler options together

[Anthony PERARD]

On Mon, Apr 07, 2025 at 01:09:38PM +0200, Roger Pau Monne wrote:
> It makes no sense to request for preprocessor only output and also request
> object file generation.  Fix the _libxl.api-for-check target to only use
> -E (preprocessor output).
>
> Also Clang 20.0 reports an error if both options are used.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

--

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech