* [PATCH] tools/libxl: do not use `-c -E` compiler options together
@ 2025-04-07 11:09 Roger Pau Monne
2025-04-07 11:11 ` Andrew Cooper
2025-04-07 11:51 ` Anthony PERARD
0 siblings, 2 replies; 3+ messages in thread
From: Roger Pau Monne @ 2025-04-07 11:09 UTC (permalink / raw)
To: xen-devel; +Cc: Roger Pau Monne, Anthony PERARD, Juergen Gross, Andrew Cooper
It makes no sense to request for preprocessor only output and also request
object file generation. Fix the _libxl.api-for-check target to only use
-E (preprocessor output).
Also Clang 20.0 reports an error if both options are used.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
tools/libs/light/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 37e4d1670986..b690d921593d 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -195,7 +195,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
touch $@
_libxl.api-for-check: $(XEN_INCLUDE)/libxl.h
- $(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \
+ $(CC) $(CPPFLAGS) $(CFLAGS) -E $< $(APPEND_CFLAGS) \
-DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \
>$@.new
mv -f $@.new $@
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tools/libxl: do not use `-c -E` compiler options together
2025-04-07 11:09 [PATCH] tools/libxl: do not use `-c -E` compiler options together Roger Pau Monne
@ 2025-04-07 11:11 ` Andrew Cooper
2025-04-07 11:51 ` Anthony PERARD
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2025-04-07 11:11 UTC (permalink / raw)
To: Roger Pau Monne, xen-devel; +Cc: Anthony PERARD, Juergen Gross, Jan Beulich
On 07/04/2025 12:09 pm, Roger Pau Monne wrote:
> It makes no sense to request for preprocessor only output and also request
> object file generation. Fix the _libxl.api-for-check target to only use
> -E (preprocessor output).
>
> Also Clang 20.0 reports an error if both options are used.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
As this is impacting GitlabCI, it wants backporting (ideally everywhere,
although I'm still accumulating other CI fixes on 4.18 and earlier).
~Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/libxl: do not use `-c -E` compiler options together
2025-04-07 11:09 [PATCH] tools/libxl: do not use `-c -E` compiler options together Roger Pau Monne
2025-04-07 11:11 ` Andrew Cooper
@ 2025-04-07 11:51 ` Anthony PERARD
1 sibling, 0 replies; 3+ messages in thread
From: Anthony PERARD @ 2025-04-07 11:51 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Juergen Gross, Andrew Cooper
On Mon, Apr 07, 2025 at 01:09:38PM +0200, Roger Pau Monne wrote:
> It makes no sense to request for preprocessor only output and also request
> object file generation. Fix the _libxl.api-for-check target to only use
> -E (preprocessor output).
>
> Also Clang 20.0 reports an error if both options are used.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-07 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 11:09 [PATCH] tools/libxl: do not use `-c -E` compiler options together Roger Pau Monne
2025-04-07 11:11 ` Andrew Cooper
2025-04-07 11:51 ` Anthony PERARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.