From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Lee Jones <lee@kernel.org>, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer
Date: Sun, 21 Jan 2024 15:49:23 +0200 [thread overview]
Message-ID: <Za0g47CgOH4MhdRe@smile.fi.intel.com> (raw)
In-Reply-To: <878r4rovk4.fsf@minerva.mail-host-address-is-not-set>
On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
...
> > + {}
>
> While at it, maybe add the { /* sentinel */ } convention to the last entry ?
Maybe. Is it a common for this subsystem?
...
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thank you for the review!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-fbdev@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
Helge Deller <deller@gmx.de>, Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer
Date: Sun, 21 Jan 2024 15:49:23 +0200 [thread overview]
Message-ID: <Za0g47CgOH4MhdRe@smile.fi.intel.com> (raw)
In-Reply-To: <878r4rovk4.fsf@minerva.mail-host-address-is-not-set>
On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
...
> > + {}
>
> While at it, maybe add the { /* sentinel */ } convention to the last entry ?
Maybe. Is it a common for this subsystem?
...
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thank you for the review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-21 13:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 15:25 [PATCH v1 0/4] backlight: hx8357: Clean up and make OF-independent Andy Shevchenko
2024-01-14 15:25 ` Andy Shevchenko
2024-01-14 15:25 ` [PATCH v1 1/4] backlight: hx8357: Make use of device properties Andy Shevchenko
2024-01-14 15:25 ` Andy Shevchenko
2024-01-15 8:20 ` Javier Martinez Canillas
2024-01-21 13:48 ` Andy Shevchenko
2024-01-21 13:48 ` Andy Shevchenko
2024-01-22 10:35 ` Daniel Thompson
2024-01-22 10:35 ` Daniel Thompson
2024-01-24 17:19 ` Daniel Thompson
2024-01-24 17:19 ` Daniel Thompson
2024-01-28 14:38 ` Andy Shevchenko
2024-01-28 14:38 ` Andy Shevchenko
2024-01-14 15:25 ` [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer Andy Shevchenko
2024-01-14 15:25 ` Andy Shevchenko
2024-01-15 8:22 ` Javier Martinez Canillas
2024-01-21 13:49 ` Andy Shevchenko [this message]
2024-01-21 13:49 ` Andy Shevchenko
2024-01-22 10:43 ` Daniel Thompson
2024-01-22 10:43 ` Daniel Thompson
2024-01-24 17:21 ` Daniel Thompson
2024-01-24 17:21 ` Daniel Thompson
2024-01-14 15:25 ` [PATCH v1 3/4] backlight: hx8357: Make use of dev_err_probe() Andy Shevchenko
2024-01-14 15:25 ` Andy Shevchenko
2024-01-15 8:24 ` Javier Martinez Canillas
2024-01-24 17:24 ` Daniel Thompson
2024-01-24 17:24 ` Daniel Thompson
2024-01-14 15:25 ` [PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device Andy Shevchenko
2024-01-14 15:25 ` Andy Shevchenko
2024-01-15 8:27 ` Javier Martinez Canillas
2024-01-24 17:25 ` Daniel Thompson
2024-01-24 17:25 ` Daniel Thompson
2024-01-28 14:39 ` Andy Shevchenko
2024-01-28 14:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za0g47CgOH4MhdRe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.