From: Charlie Jenkins <charlie@rivosinc.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Evan Green" <evan@rivosinc.com>,
"Clément Léger" <cleger@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] riscv: lib: Introduce has_fast_misaligned_access function
Date: Fri, 2 Feb 2024 15:11:37 -0800 [thread overview]
Message-ID: <Zb12qZ8cpv/O3s+4@ghost> (raw)
In-Reply-To: <20240202224939.GA2055@sol.localdomain>
On Fri, Feb 02, 2024 at 02:49:39PM -0800, Eric Biggers wrote:
> On Thu, Feb 01, 2024 at 03:30:45PM -0800, Charlie Jenkins wrote:
> > - if (((unsigned long)buff & OFFSET_MASK) == 0)
> > + if (has_fast_misaligned_accesses() || (((unsigned long)buff & OFFSET_MASK) == 0b101))
> > return do_csum_no_alignment(buff, len);
>
> Why did the 0 change into 0b101?
>
> - Eric
Whoops, thank you.
- Charlie
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Charlie Jenkins <charlie@rivosinc.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Evan Green" <evan@rivosinc.com>,
"Clément Léger" <cleger@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] riscv: lib: Introduce has_fast_misaligned_access function
Date: Fri, 2 Feb 2024 15:11:37 -0800 [thread overview]
Message-ID: <Zb12qZ8cpv/O3s+4@ghost> (raw)
In-Reply-To: <20240202224939.GA2055@sol.localdomain>
On Fri, Feb 02, 2024 at 02:49:39PM -0800, Eric Biggers wrote:
> On Thu, Feb 01, 2024 at 03:30:45PM -0800, Charlie Jenkins wrote:
> > - if (((unsigned long)buff & OFFSET_MASK) == 0)
> > + if (has_fast_misaligned_accesses() || (((unsigned long)buff & OFFSET_MASK) == 0b101))
> > return do_csum_no_alignment(buff, len);
>
> Why did the 0 change into 0b101?
>
> - Eric
Whoops, thank you.
- Charlie
next prev parent reply other threads:[~2024-02-02 23:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 23:30 [PATCH v2 0/2] riscv: Use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to set misaligned access speed Charlie Jenkins
2024-02-01 23:30 ` Charlie Jenkins
2024-02-01 23:30 ` [PATCH v2 1/2] riscv: lib: Introduce has_fast_misaligned_access function Charlie Jenkins
2024-02-01 23:30 ` Charlie Jenkins
2024-02-02 22:49 ` Eric Biggers
2024-02-02 22:49 ` Eric Biggers
2024-02-02 23:11 ` Charlie Jenkins [this message]
2024-02-02 23:11 ` Charlie Jenkins
2024-02-01 23:30 ` [PATCH v2 2/2] riscv: Disable misaligned access probe when CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS Charlie Jenkins
2024-02-01 23:30 ` Charlie Jenkins
2024-02-02 4:31 ` Elliot Berman
2024-02-02 4:31 ` Elliot Berman
2024-02-02 4:55 ` Charlie Jenkins
2024-02-02 4:55 ` Charlie Jenkins
2024-02-02 23:01 ` Eric Biggers
2024-02-02 23:01 ` Eric Biggers
2024-02-02 23:13 ` Charlie Jenkins
2024-02-02 23:13 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb12qZ8cpv/O3s+4@ghost \
--to=charlie@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=cleger@rivosinc.com \
--cc=ebiggers@kernel.org \
--cc=evan@rivosinc.com \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.