From: Leo Liang <ycliang@andestech.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Yanhong Wang <yanhong.wang@starfivetech.com>,
Tom Rini <trini@konsulko.com>, Shengyu Qu <wiagn233@outlook.com>,
Chanho Park <chanho61.park@samsung.com>,
Minda Chen <minda.chen@starfivetech.com>,
"Simon Glass" <sjg@chromium.org>,
open list <u-boot@lists.denx.de>, E Shattow <lucent@gmail.com>
Subject: Re: [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE
Date: Wed, 31 Jan 2024 11:02:33 +0800 [thread overview]
Message-ID: <Zbm4SW4LnSYJMlR9@swlinux02> (raw)
In-Reply-To: <20240127134850.582763-1-aurelien@aurel32.net>
On Sat, Jan 27, 2024 at 02:48:45PM +0100, Aurelien Jarno wrote:
> The VisionFive 2 board supports saving the u-boot environment settings
> are saved to on-board SPI flash. However the defconfig enables both
> ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command
> to work. Fix that by disabling ENV_IS_NOWHERE.
>
> Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
>
> Reported-by: E Shattow <lucent@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> configs/starfive_visionfive2_defconfig | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
prev parent reply other threads:[~2024-01-31 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 13:48 [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE Aurelien Jarno
2024-01-28 10:47 ` Shengyu Qu
2024-01-31 3:02 ` Leo Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbm4SW4LnSYJMlR9@swlinux02 \
--to=ycliang@andestech.com \
--cc=aurelien@aurel32.net \
--cc=chanho61.park@samsung.com \
--cc=lucent@gmail.com \
--cc=minda.chen@starfivetech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.