* [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE
@ 2024-01-27 13:48 Aurelien Jarno
2024-01-28 10:47 ` Shengyu Qu
2024-01-31 3:02 ` Leo Liang
0 siblings, 2 replies; 3+ messages in thread
From: Aurelien Jarno @ 2024-01-27 13:48 UTC (permalink / raw)
To: Yanhong Wang, Tom Rini, Leo Yu-Chi Liang, Shengyu Qu, Chanho Park,
Minda Chen, Simon Glass, open list
Cc: Aurelien Jarno, E Shattow
The VisionFive 2 board supports saving the u-boot environment settings
are saved to on-board SPI flash. However the defconfig enables both
ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command
to work. Fix that by disabling ENV_IS_NOWHERE.
Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
Reported-by: E Shattow <lucent@gmail.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
configs/starfive_visionfive2_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
index 1b7d57bac7..c68f3c2def 100644
--- a/configs/starfive_visionfive2_defconfig
+++ b/configs/starfive_visionfive2_defconfig
@@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y
CONFIG_CMD_BOOTSTAGE=y
CONFIG_OF_BOARD=y
CONFIG_ENV_OVERWRITE=y
-CONFIG_ENV_IS_NOWHERE=y
CONFIG_ENV_IS_IN_SPI_FLASH=y
CONFIG_ENV_SECT_SIZE_AUTO=y
CONFIG_SYS_RELOC_GD_ENV_ADDR=y
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE
2024-01-27 13:48 [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE Aurelien Jarno
@ 2024-01-28 10:47 ` Shengyu Qu
2024-01-31 3:02 ` Leo Liang
1 sibling, 0 replies; 3+ messages in thread
From: Shengyu Qu @ 2024-01-28 10:47 UTC (permalink / raw)
To: Aurelien Jarno, Yanhong Wang, Tom Rini, Leo Yu-Chi Liang,
Chanho Park, Minda Chen, Simon Glass, open list
Cc: wiagn233, E Shattow
[-- Attachment #1.1.1: Type: text/plain, Size: 1159 bytes --]
LGTM.
Maintainers, please also apply this patch to 2024.04 branch when
accepting it.
Best regards,
Shengyu
> The VisionFive 2 board supports saving the u-boot environment settings
> are saved to on-board SPI flash. However the defconfig enables both
> ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command
> to work. Fix that by disabling ENV_IS_NOWHERE.
>
> Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
>
> Reported-by: E Shattow <lucent@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> configs/starfive_visionfive2_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
> index 1b7d57bac7..c68f3c2def 100644
> --- a/configs/starfive_visionfive2_defconfig
> +++ b/configs/starfive_visionfive2_defconfig
> @@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y
> CONFIG_CMD_BOOTSTAGE=y
> CONFIG_OF_BOARD=y
> CONFIG_ENV_OVERWRITE=y
> -CONFIG_ENV_IS_NOWHERE=y
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_ENV_SECT_SIZE_AUTO=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE
2024-01-27 13:48 [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE Aurelien Jarno
2024-01-28 10:47 ` Shengyu Qu
@ 2024-01-31 3:02 ` Leo Liang
1 sibling, 0 replies; 3+ messages in thread
From: Leo Liang @ 2024-01-31 3:02 UTC (permalink / raw)
To: Aurelien Jarno
Cc: Yanhong Wang, Tom Rini, Shengyu Qu, Chanho Park, Minda Chen,
Simon Glass, open list, E Shattow
On Sat, Jan 27, 2024 at 02:48:45PM +0100, Aurelien Jarno wrote:
> The VisionFive 2 board supports saving the u-boot environment settings
> are saved to on-board SPI flash. However the defconfig enables both
> ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command
> to work. Fix that by disabling ENV_IS_NOWHERE.
>
> Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
>
> Reported-by: E Shattow <lucent@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> configs/starfive_visionfive2_defconfig | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-31 3:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-27 13:48 [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE Aurelien Jarno
2024-01-28 10:47 ` Shengyu Qu
2024-01-31 3:02 ` Leo Liang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.